Skip to content

Add package attributes to csproj files to meet packaging requirements - #1356

Merged
Naiyuan Tian (nytian) merged 1 commit into
mainfrom
nytian/attribute
May 21, 2026
Merged

Add package attributes to csproj files to meet packaging requirements#1356
Naiyuan Tian (nytian) merged 1 commit into
mainfrom
nytian/attribute

Conversation

@nytian

Copy link
Copy Markdown
Contributor

As titled.

CopilotAI review requested due to automatic review settings May 20, 2026 23:14
@nytianNaiyuan Tian (nytian) changed the title "Add package attributes to csproj files to meet packaging requirementsAdd package attributes to csproj files to meet packaging requirementsMay 20, 2026

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the repository’s NuGet packaging metadata to comply with current NuGet requirements by switching from deprecated URL-based icon metadata to file-based package assets and centralizing shared packaging settings in DurableTask.props.

Changes:

  • Replace deprecated PackageIconUrl usage with PackageIcon and add PackageReadmeFile in the shared props.
  • Ensure logo.png and README.md are packed into NuGet packages from a shared location for packable projects.
  • Remove NU5048 suppression from props and affected .csproj files after eliminating the deprecated metadata usage.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
FileDescription
tools/DurableTask.propsCentralizes package icon/readme metadata and packs shared logo.png + README.md; removes NU5048 from NoWarn.
src/DurableTask.Emulator/DurableTask.Emulator.csprojRemoves NU5048 suppression now that deprecated icon metadata is no longer used.
src/DurableTask.Core/DurableTask.Core.csprojRemoves per-project readme packing/config in favor of shared props; removes NU5048 suppression.
src/DurableTask.AzureStorage/DurableTask.AzureStorage.csprojRemoves per-project readme packing/config in favor of shared props; removes NU5048 suppression.
src/DurableTask.ApplicationInsights/DurableTask.ApplicationInsights.csprojRemoves NU5048 suppression now that deprecated icon metadata is no longer used.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@nytian
Naiyuan Tian (nytian) merged commit e05dd0c into mainMay 21, 2026
51 checks passed
@nytian
Naiyuan Tian (nytian) deleted the nytian/attribute branch May 21, 2026 16:33
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@nytian@bachuv