Skip to content

Move Azure Service Fabric unit-test binding redirects to active test/ project - #1371

Draft
shankarsama with Copilot wants to merge 2 commits into
mainfrom
copilot/fix-code-review-suggestion
Draft

Move Azure Service Fabric unit-test binding redirects to active test/ project#1371
shankarsama with Copilot wants to merge 2 commits into
mainfrom
copilot/fix-code-review-suggestion

Conversation

CopilotAI commented Jun 19, 2026

Copy link
Copy Markdown

The review flagged that the added binding redirects were placed under the legacy Test/ tree, which is not referenced by DurableTask.sln. This update applies the same redirect configuration to the active unit test project under test/.

  • Scope

    • Addresses only review comment #discussion_r3444200514.
    • No production code changes.
  • What changed

    • Added test/DurableTask.AzureServiceFabric.Tests/App.config.
    • Included the binding redirects needed for the Azure Service Fabric unit test project (net48) in the active test path.
  • Resulting alignment

    • Redirect config now sits with the test project actually included in solution builds/runs.
<!-- test/DurableTask.AzureServiceFabric.Tests/App.config -->
<dependentAssembly>
<assemblyIdentityname="Newtonsoft.Json"publicKeyToken="30ad4fe6b2a6aeed"culture="neutral" />
<bindingRedirectoldVersion="0.0.0.0-13.0.0.0"newVersion="13.0.0.0" />
</dependentAssembly>

CopilotAI requested review from Copilot and removed request for CopilotJune 19, 2026 19:19
CopilotAI requested review from Copilot and removed request for CopilotJune 19, 2026 19:34
CopilotAI changed the title [WIP] Fix code issue from review commentMove Azure Service Fabric unit-test binding redirects to active test/ projectJun 19, 2026
CopilotAI requested a review from shankarsamaJune 19, 2026 19:35
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@shankarsama