Uh oh!
There was an error while loading. Please reload this page.
Added a "LatestEvents" field to the FetchedInstanceHistory log - #1373
Conversation
There was a problem hiding this comment.
Pull request overview
This PR extends the Azure Storage tracking telemetry for “FetchedInstanceHistory” by adding a new structured log/ETW field (LatestEvents) that records the last 10 history event types returned by a fetch instance history query.
Changes:
- Add
LatestEventsto theFetchedInstanceHistorystructured log event and propagate it throughLogHelperandAnalyticsEventSource. - Populate
LatestEventsfrom the last 10 event types when reading history entities inAzureTableTrackingStore.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/DurableTask.AzureStorage/Tracking/AzureTableTrackingStore.cs | Adds computation of the last 10 history event types and passes them into the logger. |
| src/DurableTask.AzureStorage/Logging/LogHelper.cs | Extends FetchedInstanceHistory helper to accept and forward the LatestEvents field. |
| src/DurableTask.AzureStorage/Logging/LogEvents.cs | Adds a new structured field/property (LatestEvents) to the FetchedInstanceHistory log event. |
| src/DurableTask.AzureStorage/AnalyticsEventSource.cs | Extends the ETW FetchedInstanceHistory event payload to include LatestEvents. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
As per the title, this PR introduces a new log field to log the last 10 events from a fetch instance history call to improve our telemetry.