Uh oh!
There was an error while loading. Please reload this page.
Pk/upstream changes to push - #63
Merged
Simon Porter (simonporter) merged 3 commits intoSep 12, 2016
Merged
Conversation
added 2 commits
August 31, 2016 10:37
… that service fabric implementation can reference those and stress test executable can reference the service fabric.
| @@ -0,0 +1,66 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <Project ToolsVersion="14.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | |||
Contributor
There was a problem hiding this comment.
Add this import: Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory),DurableTask.sln))\tools\DurableTask.props"
ContributorAuthor
There was a problem hiding this comment.
Done.
Simon Porter (simonporter)
commented
Sep 7, 2016
Contributor
Added two minor comments if you can update I'll merge them in. |
ContributorAuthor
Simon Porter (@simonporter) , Took care of the comments - can you merge the changes? Thanks! |
Pradeep Kadubandi (PradeepKadubandi)
deleted the
pk/upstream_changes_to_push
branch
September 22, 2016 22:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Affan Dar (@affandar) / Simon Porter (@simonporter) ,
What do you think about this change? I made this in my fork for service fabric custom provider so that I could reuse the test orchestration code, I would like to push these changes to main repository so that there will be less conflicts or changes in future for pull from remote. I think the change is good and no risk.
Let me know if you have any comments and I can fix it.