Uh oh!
There was an error while loading. Please reload this page.
Adding RaiseEvent to client for scalability, Allow creating queue with specific size - #70
Conversation
Matt Hawley (matthawley)
commented
Nov 17, 2016
I also added ability to set the maximum service bus queue size (issue #68) |
Matt Hawley (matthawley)
commented
Dec 1, 2016
Also fixed issue #73 which was throwing a null ref exception when a work item was aborted. |
| await SafeCreateQueueAsync(namespaceManager, path, requiresSessions, requiresDuplicateDetection, maxDeliveryCount, maxSizeInMegabytes); | ||
| } | ||
| private static readonly long[] ValidQueueSizes = { 1024L, 2048L, 3072L, 4096L, 5120L }; |
There was a problem hiding this comment.
convention is to not include modifier for private
| var executionStartedEvent = message.Event as ExecutionStartedEvent; | ||
| if (executionStartedEvent != null) | ||
| var brokeredMessages = new BrokeredMessage[messages.Length]; | ||
| for (int i = 0; i < messages.Length; i++) |
There was a problem hiding this comment.
GetBrokeredMessageFromObjectAsync could end up going to blob storage or another slow external storage so running this as tasks would be better so the latency is not sequential.
| /// <summary> | ||
| /// Maximum queue size, in megabytes, for the service bus queues | ||
| /// </summary> |
There was a problem hiding this comment.
1024L as default for consistency with the valid sizes list
| /// <param name="orchestrationVersion">Name of the orchestration as specified by the ObjectCreator</param> | ||
| /// <param name="instanceId">Instance id for the orchestration to be created, must be unique across the Task Hub</param> | ||
| /// <param name="eventName">Name of the event</param> | ||
| /// <param name="eventData">Data for the event</param> |
There was a problem hiding this comment.
I think the naming of RaiseEventAsync here is a bit confusing as the meaning for an already running instance is quite different.
I think it would be better to have a CreateOrchestrationInstanceWithRaisedEventAsync (open to other naming suggestions) and have the various permutations for with/without tags etc.
Likely best to have an InternalCreateOrchestrationInstanceAsync that this and the CreateOrchestrationInstanceAsync can call to avoid duplication.
A common pattern for long-running orchestrations is to create an orchestration then raise an event on it. This causes twice as many messages to service bus. This change will do this process in a batch send.