fix: bump the min maxUnavailable to 1 - #803
Merged
Ryan Zhang (ryanzhang-oss) merged 1 commit intoMay 9, 2024
Merged
Conversation
Ryan Zhang (ryanzhang-oss)
force-pushed
the
fix-max-unavailable
branch
from
May 8, 2024 21:22
427b7bc to
95933cd
Compare
Ryan Zhang (ryanzhang-oss)
requested review from
Liqian Luo (circy9) and
Zhiying Lin (zhiying-lin)
May 8, 2024 21:23
| @@ -513,7 +513,7 @@ type RollingUpdateConfig struct { | |||
| // The desired number equals to the number of clusters scheduler selected when the placement type is `PickAll`. | |||
Contributor
There was a problem hiding this comment.
// The desired number equals to the NumberOfClusters field when the placement type is PickN.
What is the desired number?
Liqian Luo (circy9)
approved these changes
May 9, 2024
Britania Rodriguez Reyes (britaniar)
pushed a commit
that referenced
this pull request
Sep 2, 2026
…s) (#803) Renamed API types Signed-off-by: michaelawyu <chenyu1@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Bump the min maxUnavailable to 1 to avoid rolling out stuck.
Fixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer