chore: upgrade controller-runtime package - #851
Merged
Zhiying Lin (zhiying-lin) merged 1 commit intoJun 17, 2024
Merged
Conversation
Ryan Zhang (ryanzhang-oss)
approved these changes
Jun 17, 2024
Ryan Zhang (ryanzhang-oss)
left a comment
Contributor
There was a problem hiding this comment.
We need to look at the hard coded replace items
Britania Rodriguez Reyes (britaniar)
pushed a commit
that referenced
this pull request
Sep 2, 2026
The setup-qemu target added in #745 pinned the MCR qemu-user-static mirror to sha256:cb0dff99, which no registry can serve: docker: Error response from daemon: manifest for mcr.microsoft.com/ mirror/docker/multiarch/qemu-user-static@sha256:cb0dff99... not found: manifest unknown The image has no manifest list, upstream or mirrored. When a request carries no Accept header, or names only the manifest-list media type, MCR answers with a deprecated schema-1 `v1+prettyjws` view synthesised on demand from the schema-2 manifest. The digest that view advertises is stable, but it is never stored as a manifest revision, so fetching by it 404s: GET /manifests/7.2.0-1 (Accept: manifest.list.v2) -> cb0dff99, v1+prettyjws GET /manifests/sha256:cb0dff99... -> HTTP 404 GET /manifests/7.2.0-1 (Accept: manifest.v2) -> fe60359c, schema 2 GET /manifests/sha256:fe60359c... -> HTTP 200 Repin to the real schema-2 manifest (linux/amd64, entrypoint /register), which is all setup-qemu needs since the QEMU_IMAGE branch runs only when TARGET_ARCH is amd64. The new digest is the one Docker Hub also serves for multiarch/qemu-user-static:7.2.0-1, so the mirror and upstream agree. Document how to obtain the digest, and which tools report it correctly, so the next version bump does not reintroduce the schema-1 value. Signed-off-by: Yetkin Timocin <ytimocin@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
upgrade controller-runtime package to fix CVEs
Fixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer