Skip to content

Allow domain hint - #181

Merged
Abhidnya (abhidnya13) merged 3 commits into
devfrom
allow_domain_hint
Apr 14, 2020
Merged

Abhidnya (abhidnya13) merged 3 commits into
devfrom
allow_domain_hint

Conversation

@abhidnya13

@abhidnya13 Abhidnya (abhidnya13) commented Apr 13, 2020

Copy link
Copy Markdown
Contributor

Allows user to pass in domain hint when generating authorization URL


UPDATED (by Ray):
This PR will fix #158. (This line will trigger an automatic close of that issue. This is probably fine, because we will cut a new release shortly after this merge.)

@rayluo Ray Luo (rayluo) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The feature implementation is clean! Added a question for the docs.

Comment thread msal/application.py Outdated
Comment thread msal/application.py Outdated

@rayluo Ray Luo (rayluo) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! Squash and merge!

@abhidnya13
Abhidnya (abhidnya13) merged commit 61785a7 into dev Apr 14, 2020
@abhidnya13
Abhidnya (abhidnya13) deleted the allow_domain_hint branch April 14, 2020 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

How to properly pass domain_hint?

2 participants