New initialize_auth_code_flow() and acquire_token_by_auth_code_flow() - #276
Merged
Merged
Conversation
Ray Luo (rayluo)
force-pushed
the
acquire_token_by_auth_code_flow
branch
4 times, most recently
from
November 23, 2020 11:09
43f8782 to
9586af0
Compare
Navya Canumalla (navyasric)
approved these changes
Nov 24, 2020
Ray Luo (rayluo)
force-pushed
the
acquire_token_by_auth_code_flow
branch
from
November 25, 2020 01:15
9586af0 to
06c2b65
Compare
This was referenced Dec 3, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the recent new API proposal (its internal link here). It will become the foundation of the upcoming Interactive flow feature.
The new API
initiate_auth_code_flow()andacquire_token_by_auth_code_flow()also provide PKCE support automatically, without needing the app developer to provide any PKCE-relevant parameters, so that different app developers would not hit this issue any more. This PR will close #255.Inline-documentation and end-to-end test cases are included. Docs will soon be available at https://msal-python.readthedocs.io/en/latest/
I'll also provide a corresponding PR in our web app sample repo, to demonstrate how to use this feature.