Detecting Regional Endpoint from env var - #425
Merged
Merged
Conversation
Ray Luo (rayluo)
force-pushed
the
region-env-var
branch
from
October 22, 2021 03:58
f4ef3c7 to
07cc82b
Compare
Ray Luo (rayluo)
force-pushed
the
region-env-var
branch
from
October 28, 2021 17:34
07cc82b to
56e4b01
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds back the behavior of detecting region based on env var
REGION_NAME. Both short name (aseastus) or long name style (asWest Us 2) are supported.This time, we also make sure the entire regional endpoint behavior requires opt-in (as reiterated by this internal design), by either
or
The default behavior does not utilize regional endpoint.
In other words, the re-introduction of reading
REGION_NAMEenv var would not regress The REGION_NAME env var should be prefixed with MSAL_ #382.