Uh oh!
There was an error while loading. Please reload this page.
Closing Time was Set Before Midnight - #178
Merged
Merged
Conversation
BrianRamsay
approved these changes
Feb 24, 2022
BrianRamsay
left a comment
Contributor
There was a problem hiding this comment.
This change looks good, but there is some work to do on the setup PR
BrianRamsay
approved these changes
Mar 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #176 where the closing time was not set to midnight on the closing date.
Fix: Change the code that sets the time of the end date to 23:59 instead of 11:55 because we are working in a 24hr format time.