Skip to content

XCode15, NDK 25, up v8 and jsc - #59

Closed
CedricGuillemet wants to merge 41 commits into
BabylonJS:mainfrom
CedricGuillemet:xcode15NDK25
Closed

XCode15, NDK 25, up v8 and jsc#59
CedricGuillemet wants to merge 41 commits into
BabylonJS:mainfrom
CedricGuillemet:xcode15NDK25

Conversation

@CedricGuillemet

@CedricGuillemetCedricGuillemet commented Oct 4, 2023•
edited
Loading

Copy link
Copy Markdown
Collaborator

fixes#51

@CedricGuillemetCedricGuillemet changed the title XCode15 for iOS qnd NDK version parameterXCode15 for iOS and NDK version parameterOct 4, 2023
@CedricGuillemetCedricGuillemet changed the title XCode15 for iOS and NDK version parameterXCode15 for iOS and NDK version parameter set to 25Oct 4, 2023
bghgary
bghgary approved these changes Oct 4, 2023
View reviewed changes
Comment threadTests/UnitTests/Android/app/build.gradle Outdated
Comment thread.github/azure-pipelines.yml Outdated
Comment thread.github/jobs/android.yml Outdated
Comment thread.github/jobs/ios.yml Outdated
Comment threadCore/AppRuntime/V8Inspector/Source/V8InspectorTCP.h
Comment on lines +6 to +11
// 'allocator<void>' is deprecated
// Android with NDK25
// 23/10/04 : allocator still present in latest asio main branch
#if defined(__clang__)
#pragma clang diagnostic ignored "-Wdeprecated-declarations"
#endif

@bghgarybghgaryOct 4, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should submit a fix to asio. @ryantrem and I did some simple replacements locally to fix this.

@CedricGuillemet

CedricGuillemet commented Nov 14, 2023

Copy link
Copy Markdown
CollaboratorAuthor

#66

@CedricGuillemet
CedricGuillemet marked this pull request as draft November 14, 2023 11:11
@CedricGuillemetCedricGuillemet changed the title XCode15 for iOS and NDK version parameter set to 25XCode15, NDK 25, up v8 and jscNov 14, 2023
@CedricGuillemet
CedricGuillemet marked this pull request as ready for review January 26, 2024 16:56
@CedricGuillemetCedricGuillemet mentioned this pull request Jan 31, 2024
Merged
@CedricGuillemet

CedricGuillemet commented Feb 2, 2024

Copy link
Copy Markdown
CollaboratorAuthor

Closing as these changes are part of #70

@CedricGuillemet
CedricGuillemet deleted the xcode15NDK25 branch June 26, 2024 14:42
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bghgarybghgarybghgary approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Android NDK25

2 participants

@CedricGuillemet@bghgary