Uh oh!
There was an error while loading. Please reload this page.
Closed
VAPI-3162: Add ReferCompleteCallback and ReferCallStatusEnum (fixes spec parse error in #211)#212
Conversation
- Add referCallStatusEnum schema to bandwidth.yml - Add referCompleteCallback schema to bandwidth.yml with standard call context fields plus refer-specific fields (referTo, referCallStatus, referSipResponseCode, notifySipResponseCode) - Copy OpenAPI-generator-produced model files: lib/bandwidth-sdk/models/refer_call_status_enum.rb lib/bandwidth-sdk/models/refer_complete_callback.rb - Register both models in lib/bandwidth-sdk.rb and .openapi-generator/FILES - Add unit tests covering success, failure (405 rejected), and failure (202 + notifySipResponseCode) scenarios
bwappsec
commented
Jun 19, 2026
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the CI failures seen in PR #211 (
VAPI-3162-REFER).Root cause:
spec/unit/models/refer_complete_callback_spec.rbin PR #211 accidentally contains a spurious first line — a GitHub diff-table header (Original file line number\tDiff line number\tDiff line change) — that was pasted in when the file was authored. Ruby cannot parse it, causing:Changes
bandwidth.yml— addsreferCallStatusEnumandreferCompleteCallbackschemaslib/bandwidth-sdk/models/refer_call_status_enum.rb— new enum modellib/bandwidth-sdk/models/refer_complete_callback.rb— new callback modellib/bandwidth-sdk.rb— registers both new models.openapi-generator/FILES— registers both new filesspec/unit/models/refer_call_status_enum_spec.rb— unit tests for the enumspec/unit/models/refer_complete_callback_spec.rb— unit tests for the callback (without the bad header line)