Write extent tombstones only for extents that exist - #625
Merged
Merged
Conversation
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #625 +/- ##
==========================================
+ Coverage 83.23% 83.24% +0.01%
==========================================
Files 104 104
Lines 47003 47048 +45
==========================================
+ Hits 39122 39167 +45
Misses 7881 7881
🚀 New features to boost your workflow:
|
Owner
|
Looks great, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Pierre, great project!
I recently encountered an issue while trimming a large block device on NBD. Currently, a trim writes one tombstone per 32k extent in the requested range, regardless of whether the extent has a key. Because Bloom filters count every row, SSTs become bloated with filter blocks of hundreds of MBs when trimming large sparse devices.
File-range deletes are affected by the same issue.
In this fix we reuse the existing range scan (used for debiting) to determine which extents actually need to be deleted.
Thank you for your work!