Skip to content

Install Chrome so the puppeteer tests can run#2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arnelirobles merged 2 commits into from
Aug 24, 2026
Merged

Install Chrome so the puppeteer tests can run #2

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a384bcc
ci: install Chrome so the puppeteer tests can run
arnelirobles Aug 19, 2026
e7e7241
Filter the Chrome install to the package that has puppeteer
arnelirobles Aug 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -35,6 +35,16 @@ jobs:

- run: pnpm install --frozen-lockfile

# mermaid-export renders through puppeteer, which needs a real Chrome. The
# browser normally arrives via puppeteer's postinstall script, which does not
# run here, so eleven of its tests failed with "Could not find Chrome (ver. …)".
#
# Filtered to the one package that depends on puppeteer. A bare `pnpm exec` runs
# from the workspace root, where the binary does not exist, and fails with
# "Command \"puppeteer\" not found" before it reaches the package that has it.
- name: Install Chrome for puppeteer
run: pnpm --filter mermaid-export exec puppeteer browsers install chrome

- name: Typecheck
run: pnpm typecheck

Expand Down
Loading