Skip to content

fix(prism): threshold cheap Suspicious in combine_final - #94

Merged
echobt merged 1 commit into
mainfrom
fix/prism-suspicious-threshold
Aug 8, 2026
Merged

fix(prism): threshold cheap Suspicious in combine_final#94
echobt merged 1 commit into
mainfrom
fix/prism-suspicious-threshold

Conversation

@echobt

Copy link
Copy Markdown
Contributor

Summary

  • combine_final now compares cheap LLM Suspicious confidence against SUSPICIOUS_HARD_ZERO_THRESHOLD (0.9) and skips Score(0) when evidence is generic-trope-only (RMSNorm / SwiGLU / LayerNorm).
  • Pre-pod reject shares the same cheap_similarity_hard_zeros helper; Copied remains hard Score(0).
  • Closes the fix(prism): fair review for generic LM tropes #91 gap where all remaining Suspicious kinds were treated equally (0.7 tropes vs 0.99 real copy).

Test plan

  • cargo test -p prism-review -p prism-challenge --lib
  • cargo clippy -p prism-review -p prism-challenge --all-targets -- -D warnings
  • cargo run -p xtask -- external-docs-check / spec-check
  • CI green
  • Deploy prism-challenge; confirm precheck + tops-only corpus unchanged
  • Miner hotkeys can resubmit (no invented bpb on old rejects)

Score(0) only for Copied or Suspicious at/above 0.9 with non-trope
evidence so 0.7 RMSNorm/SwiGLU false positives no longer wipe leaves.
@echobt
echobt merged commit 93315e4 into mainAug 8, 2026
1 check passed
@coderabbitai

Copy link
Copy Markdown

Warning

Review limit reached

@echobt, you've reached your PR review limit, so we couldn't start this review.

Next review available in:22 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 385cd15b-a201-4cd8-a8dd-fe9cd5cdf34f

📥 Commits

Reviewing files that changed from the base of the PR and between 8c0dc59 and 2e9a1c2.

📒 Files selected for processing (9)
  • crates/prism-challenge/src/orchestrator.rs
  • crates/prism-challenge/src/score.rs
  • crates/prism-review/src/generic_arch.rs
  • crates/prism-review/src/lib.rs
  • docs/COMPLETENESS.md
  • docs/PRISM.md
  • docs/PRISM_RECIPE.md
  • docs/external-miner/prism.md
  • docs/external-miner/troubleshoot.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@echobt