Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 18
Add WebP support and update dependencies#486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
Changes from all commits
f57f759db240d650732ce56120c3d8070be803eb3917492e88ad12c890876fc0a61e3bfc805aec5fb607eb5e0fa13624d5a169e0cFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,38 +1,16 @@ | ||
| module.exports = { | ||
| plugins: [ | ||
| { cleanupAttrs: true }, | ||
| { removeDoctype: true }, | ||
| { removeXMLProcInst: true }, | ||
| { removeComments: true }, | ||
| { removeMetadata: true }, | ||
| { removeTitle: true }, | ||
| { removeDesc: true }, | ||
| { removeUselessDefs: true }, | ||
| { removeEditorsNSData: true }, | ||
| { removeEmptyAttrs: true }, | ||
| { removeHiddenElems: true }, | ||
| { removeEmptyText: true }, | ||
| { removeEmptyContainers: true }, | ||
| { cleanupEnableBackground: true }, | ||
| { convertStyleToAttrs: true }, | ||
| { convertColors: true }, | ||
| { convertPathData: true }, | ||
| { convertTransform: true }, | ||
| { removeUnknownsAndDefaults: true }, | ||
| { removeNonInheritableGroupAttrs: true }, | ||
| { removeUselessStrokeAndFill: true }, | ||
| { removeUnusedNS: true }, | ||
| { cleanupIDs: true }, | ||
| { cleanupNumericValues: true }, | ||
| { moveElemsAttrsToGroup: true }, | ||
| { moveGroupAttrsToElems: true }, | ||
| { collapseGroups: true }, | ||
| { removeRasterImages: false }, | ||
| { mergePaths: true }, | ||
| { convertShapeToPath: true }, | ||
| { sortAttrs: true }, | ||
| { removeDimensions: false }, | ||
| { prefixIds: true }, | ||
| { removeViewBox: false }, | ||
| { | ||
| name: 'preset-default', | ||
| params: { | ||
| overrides: { | ||
| // Disable a plugin included by default that you don't want (false) | ||
| removeViewBox: false, | ||
| }, | ||
| }, | ||
| }, | ||
| // Plugins that are not in the "preset-default" and that you want to activate | ||
| 'removeTitle', | ||
| 'convertStyleToAttrs', | ||
| ], | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -6,7 +6,7 @@ const loaders = require('./loaders') | ||
| const mode = 'development' | ||
| module.exports = merge(common, { | ||
| mode: mode, | ||
| mode, | ||
francoistibo marked this conversation as resolved.
Uh oh!There was an error while loading. Please reload this page. | ||
| stats: 'errors-only', | ||
| devtool: 'inline-source-map', | ||
| devServer: { | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -5,7 +5,7 @@ const loaders = require('./loaders') | ||
| const mode = 'production' | ||
| module.exports = merge(common, { | ||
| mode: mode, | ||
| mode, | ||
francoistibo marked this conversation as resolved.
Uh oh!There was an error while loading. Please reload this page. | ||
| stats: 'minimal', | ||
| output: { | ||
| filename: '[name]-min.js', | ||
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ImageMinimizerPlugin moved from optimization.minimizer to plugins array
Medium Severity
ImageMinimizerPluginwith itsminimizerconfig was moved fromoptimization.minimizer(inwebpack.common.js) to thepluginsarray (inplugins.js). The PR description itself shows the correct pattern: the minimizer belongs inoptimization.minimizerand only the generator belongs inplugins. Placing it in thepluginsarray bypasses webpack's optimization pipeline, losing caching and deduplication benefits. Community reports indicate this can cause significantly slower builds and high CPU usage with larger image sets. The plugin needs to be inoptimization.minimizer— either back inwebpack.common.jsor inwebpack.prod.js.Additional Locations (1)
config/webpack.common.js#L12-L14Reviewed by Cursor Bugbot for commit eb5e0fa. Configure here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@firestar300 Le fait que t'as déplacé ça, le bugbot remonte ce soucis ? logique pour toi ?