Uh oh!
There was an error while loading. Please reload this page.
Added feature to make languages sortable in the language admin page - #489
Merged
Conversation
Add reorder mode toggle to the languages settings page that enables drag-and-drop reordering of enabled languages using the DraggableList component. Hide the SortableJS fallback clone at the initial position to prevent a ghost chip visual artifact during drag. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Move the CSS fix for hiding the SortableJS fallback clone from the
languages template into the SortableGrid hook so any draggable_list
with hide_source={true} gets the behavior automatically.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>ddon added a commit
that referenced
this pull request
Apr 13, 2026
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ddon
commented
Apr 13, 2026
Contributor
Posted a review at TL;DR — approve with minor suggestions. Small, focused PR that reuses existing Suggested polish before merge:
Non-blocking:
Nice contrast to #488 — this is what a focused feature PR looks like. |
ddon added a commit
that referenced
this pull request
Apr 13, 2026
- Move wiggle keyframes from inline <style> in heex into phoenix_kit.js and phoenix_kit_sortable.js injectStyles(); rename class to pk-sortable-wiggle and respect prefers-reduced-motion. - Dedup ordered_codes in Languages.reorder_languages/1 (Enum.uniq) and use MapSet for the remaining filter. - Add reorder_languages/1 integration tests covering reorder, partial list, unknown codes, empty list, and duplicate codes. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.