Uh oh!
There was an error while loading. Please reload this page.
Add V102 smart catalogues migration and multilang debounce flow - #500
Merged
Conversation
- V102: `kind` + `discount_percentage` on catalogues, `discount_percentage` + `default_value` / `default_unit` on items, new `phoenix_kit_cat_item_catalogue_rules` table with CHECK constraints, UNIQUE (item_uuid, referenced_catalogue_uuid), and ON DELETE CASCADE on both FKs. Idempotent up/down; partial index on `kind='smart'`. - MultilangForm: trailing-debounce `attach_hook/4` + client-side skeleton toggle via composed JS. Rapid language-tab clicks no longer flash stale content or re-mount non-translatable fields. - Core form components (input/select/textarea/checkbox): realign `class` attr so it merges onto the styled element (input / daisyUI select wrapper / textarea / checkbox). `<.input>` gains `wrapper_class` for the outer `phx-feedback-for` div — matches the Phoenix 1.7 generator convention. - AGENTS.md: document the Core Form Components and Multilang Form Components sections, including the wrapper-scope rule and why language switching is client-side-first. - Bump to 1.7.99 and add test_load_filters / test_ignore_filters for Elixir 1.19 mix test hygiene. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
ddon pushed a commit
that referenced
this pull request
Apr 20, 2026
Covers three merged PRs since 1.7.98: - #498: V100 staff + V101 projects migrations - #499: MediaBrowser Embed macro, selection menu/bulk download, admin attr, drag-drop file→folder move, toggleable search, drag-drop upload at any folder level, unified sidebar/content card, site icon + tab title + logo settings - #500: V102 smart-catalogue + discount migration, multilang debounce flow (attach_hook + client-side skeleton toggles), core form class/wrapper_class realignment, CSS sources abs-path fix, Elixir 1.19 test filters, AGENTS.md core form + multilang docs + CHANGELOG ownership rule Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kind+discount_percentageon catalogues,discount_percentage+default_value/default_uniton items, newphoenix_kit_cat_item_catalogue_rulestable with CHECK constraints, UNIQUE (item_uuid, referenced_catalogue_uuid), and ON DELETE CASCADE on both FKs. Idempotent up/down; partial index onkind='smart'.attach_hook/4+ client-side skeleton toggle via composed JS. Rapid language-tab clicks no longer flash stale content or re-mount non-translatable fields.classattr so it merges onto the styled element (input / daisyUI select wrapper / textarea / checkbox).<.input>gainswrapper_classfor the outerphx-feedback-fordiv — matches the Phoenix 1.7 generator convention.