Uh oh!
There was an error while loading. Please reload this page.
Add ecommerce gettext manifest and ru/et translations - #547
Merged
Conversation
Add EcommerceGettextManifest to core so mix gettext.extract records 253 ecommerce admin strings into priv/gettext/default.pot. The manifest re-emits all gettext calls from phoenix_kit_ecommerce admin LiveViews (dashboard, carts, categories, products, imports, settings, shipping) using the PhoenixKitWeb.Gettext backend — required because mix gettext.extract does not walk into dep source files. Fill Russian (ru) and Estonian (et) translations for all 253 new msgids. Other locales (de, en, es, fr, it, pl) received the empty entries from the extract run; translations for those remain pending. Extraction command: mix gettext.extract --merge (from /app).
- De-fuzz 91 entries per locale that mix gettext.extract --merge had
incorrectly borrowed from unrelated strings (roles, buckets, notes, etc.)
- Replace every wrong msgstr with correct ecommerce-admin-sense translation
- Fix 4 placeholder mismatches: %{role_name}→%{count} in category/product
delete confirmations; %{count}→%{max} in file upload limit; %{count}→%{name}
in permanent-delete confirmation
- Fill 2 ngettext plural blocks: 1 category/%{count} categories and
1 product/%{count} products (ru: 3 forms, et: 2 forms)
- De-fuzz %{count} item restored and Move %{count} item to folder plurals- Remove mistargeted credo:disable-for-next-line comment (no quote block present) - Add explicit sidebar PhoenixKitEcommerce.Gettext subsystem OUT note to scope
- Execution plan for ecommerce admin UI i18n (ru/et) - Phase 3 two-stage review report (spec + quality) - Phase 4 live verification report (Decor 3D Print) - fuzzy_fix_list working notes - Carry over PR BeamLabEU#531 original review doc
- The admin header label used gettext("Admin"), mistranslated as
"Administrator" in ru; changed the msgid to "Admin Panel" with correct
ru ("Админ-панель") and et ("Halduspaneel") translations. Wrapped the
matching user-dashboard nav link too.
- MediaGallery pick button is now "Choose image" / "Choose images"
depending on single/multiple mode.
- Wrapped previously hardcoded MediaSelectorModal strings in gettext
(ngettext for the selection counter).
- Extracted/merged gettext catalogs; added ru and et translations.…er fix, lib upgrades # Conflicts: # lib/phoenix_kit_web/components/media_gallery.html.heex
ddon pushed a commit
that referenced
this pull request
May 18, 2026
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
ddon pushed a commit
that referenced
this pull request
May 18, 2026
Complete the 1.7.112 entry to cover all unreleased work since v1.7.111: PR #548 (table_default sort/DnD, bulk_actions_bar, empty_state, sort_selector, form_section/form_actions, Reorder/Values/Format utils), PR #544 (MediaBrowser folder management overhaul), PR #545 (V120 document-creator taxonomy), PR #547/#542 (i18n manifests), and this session's post-merge cleanup. Re-dated to 2026-05-18. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brings ecommerce i18n support and supporting documentation into
dev.ecommerce_gettext_manifest.ex) and filledru/ettranslations.ru/etPO files.The media-module components (
MediaGallery,MediaViewer) themselves are already indevfrom prior PRs; this change adds only the i18n work and documentation on top.