Skip to content

Trim implementation-detail comments in magic_link.html.heex - #564

Closed
mdon wants to merge 1 commit into
BeamLabEU:devfrom
mdon:followup-trim-magic-link-comments
Closed

Trim implementation-detail comments in magic_link.html.heex#564
mdon wants to merge 1 commit into
BeamLabEU:devfrom
mdon:followup-trim-magic-link-comments

Conversation

@mdon

@mdonmdon commented May 22, 2026

Copy link
Copy Markdown
Contributor

Summary

Codex final-review CONCERN from PR #559: the long inline comments
explaining the data-phx-skip / 183px / form-ownership root causes
in magic_link.html.heex belong in the PR description, not in
templates where they'll age out faster than the fix.

Kept short comments naming the root rules ("fieldset default
min-width", "double-swap broke the DOM merge") so a future edit
sees the intent without the wall of text.

Notes

Test plan

  • mix compile clean
  • mix format --check-formatted clean on the touched file
  • Visual check at /phoenix_kit/users/log-in/magic-link
    submit button still fills the card, no overflow

Codex final-review CONCERN: the long inline comments explaining
the data-phx-skip / 183px / form-ownership root causes belong in
the PR description, not in templates where they'll age out faster
than the fix. Kept short comments naming the root rules ('fieldset
default min-width', 'double-swap broke the DOM merge') so a future
edit sees the intent without the wall of text.
@mdon

mdon commented May 22, 2026

Copy link
Copy Markdown
ContributorAuthor

Superseded by #565 — consolidated translation follow-ups into one PR per module per @mdon convention. The same commits are cherry-picked onto the new branch verbatim.

@mdonmdon closed this May 22, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@mdon