Uh oh!
There was an error while loading. Please reload this page.
Trim implementation-detail comments in magic_link.html.heex - #564
Closed
mdon wants to merge 1 commit into
Closed
Conversation
Codex final-review CONCERN: the long inline comments explaining
the data-phx-skip / 183px / form-ownership root causes belong in
the PR description, not in templates where they'll age out faster
than the fix. Kept short comments naming the root rules ('fieldset
default min-width', 'double-swap broke the DOM merge') so a future
edit sees the intent without the wall of text.5 tasks
mdon
commented
May 22, 2026
ContributorAuthor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Codex final-review CONCERN from PR #559: the long inline comments
explaining the
data-phx-skip/ 183px / form-ownership root causesin
magic_link.html.heexbelong in the PR description, not intemplates where they'll age out faster than the fix.
Kept short comments naming the root rules ("fieldset default
min-width", "double-swap broke the DOM merge") so a future edit
sees the intent without the wall of text.
Notes
on the merged branch. This PR re-applies it cleanly off
upstream/dev.min-w-0on<fieldset>+ removedphx-disable-withto avoid double-swap DOM conflict) remainsin place; only the explanatory comments are trimmed.
Test plan
mix compilecleanmix format --check-formattedclean on the touched file/phoenix_kit/users/log-in/magic-link—submit button still fills the card, no overflow