Uh oh!
There was an error while loading. Please reload this page.
V148: phoenix_kit_crm_party_roles table (unblocks phoenix_kit_crm #10) - #637
Merged
Merged
Conversation
Ships the core migration that creates the phoenix_kit_crm_party_roles table backing phoenix_kit_crm's supplier/client party roles (merged in phoenix_kit_crm PR #10). Without it the CRM party-roles feature crashes at runtime — the release-blocking finding from that PR's post-merge review. Polymorphic role edge (a CRM company or contact holds supplier/client/partner roles); no FK on roleable_uuid (polymorphic target); unique on (roleable_type, roleable_uuid, role). Idempotent; rebased onto current main (V147). Full migration-chain integration test passes (V03->V148).
This was referenced Jul 14, 2026
ddon pushed a commit
that referenced
this pull request
Jul 14, 2026
V148's uuid DEFAULT called uuid_generate_v7() unqualified, which resolves via search_path and fails on named-schema (prefixed) installs since the function only exists inside the prefix schema. Qualified with the prefix, matching V138/V144 precedent. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This was referenced Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the core migration that creates
phoenix_kit_crm_party_roles— the table backing phoenix_kit_crm's supplier/client party roles merged in phoenix_kit_crm#10. That PR's post-merge review flagged this as the one release-blocking gap: without the migration, the feature crashes at runtime.Polymorphic role edge marking a CRM company or contact as supplier/client/partner (one party can hold several roles). No FK on
roleable_uuid(polymorphic company-or-contact target), mirroring V138'sinteraction_parties.staff_person_uuidsoft-ref; unique on(roleable_type, roleable_uuid, role). Idempotent up/down.Rebased onto current
main(V147). Full migration-chain integration test passes (V03→V148).