Uh oh!
There was an error while loading. Please reload this page.
Update etcher to 0.8.2 — fix invisible circles on rotated canvas - #655
Merged
Conversation
etcher 0.8.2 fixes circles rendering with radius 0 (invisible) when drawn on a rotated Fresco canvas — the media annotation viewer's circle tool. Lock-only bump; the fix is in etcher's JS, which the host app loads. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MsjUy1HnuJnCSrqdbnANYL
ddon pushed a commit
that referenced
this pull request
Jul 20, 2026
Post-merge review of the V154 OG migration + admin list-UI bundle, the cheap timezone-label accessor, and the etcher 0.8.2 patch bump. No bugs found; two low-confidence nitpicks recorded on PR #650 (a likely no-op @disable_ddl_transaction on V154, and a possible array/object mismatch on the OG template's canvas JSONB default). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
ddon pushed a commit
that referenced
this pull request
Jul 20, 2026
Bumps version and adds the CHANGELOG entry for the merged-but-unpublished PRs #650 (V154 OpenGraph tables + admin list-UI/breadcrumb/sidebar enhancements), #653 (V155 delivery CRM contact id + per-broadcast dedup), #654 (cheap timezone-label accessor), and #655 (etcher 0.8.2). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lock-only bump: etcher 0.8.1 → 0.8.2.
The bug (fixed in etcher 0.8.2)
Drawing a circle on a rotated Fresco canvas (the media annotation viewer) produced an invisible shape — it existed and hit-tested correctly, but painted with radius 0 until you rotated back to 0°/180°. Markers and every other tool worked.
Cause (etcher, not fresco): the circle renderer took its screen radius from only the x-component of the projected edge point (
rp.x - c.x). At 90°/270° an image-x offset projects to a screen-y offset, so that difference collapses to ~0. Fresco's rotation transforms were correct. Fixed to use the full projected distance (hypot), which equalsr × scaleat any rotation; same fix applied to the circle edge-anchor helper. Verified by simulation: rot 90/270 old radius = 0, new = correct.Notes
🤖 Generated with Claude Code
https://claude.ai/code/session_01MsjUy1HnuJnCSrqdbnANYL