You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
now recognizes versions that have the -1 version suffix. will create a version without the suffix even if its that way in the .properties file.
for example, 17.11-1 will be 17.11 version
• Adds bundle templates for PostgreSQL 14.24, 15.19, 16.15, 17.11, and 18.6.
• Resolves -1 source keys while preserving unsuffixed Bearsampp release versions.
• Advances the bundle release identifier to the August 2026 release.
Diagram
graph TD
A["Release task"] --> B["Bundle version"] --> C{"Source key"}
C -->|"version-1 preferred"| D["Untouched properties"] --> E["PostgreSQL binaries"] --> F["Version templates"] --> G["Release archive"]
C -->|"version fallback"| D
Loading
High-Level Assessment
The following are alternative approaches to this PR:
1. Generalize packaging-revision lookup
➕ Supports future keys such as 17.11-2 without another build-script change.
➕ Can select the latest available packaging revision automatically.
➖ Requires explicit revision ordering and collision rules.
➖ May silently choose an unintended artifact when multiple revisions exist.
Recommendation: Keep the explicit -1 preference with an unsuffixed fallback because it matches the current repository convention and preserves stable bundle names. Generalize revision discovery only if modules-untouched begins publishing multiple numeric packaging revisions.
• Checks for a '<version>-1' properties key before the unsuffixed key, allowing packaging-revision artifacts to produce unsuffixed Bearsampp bundles. String concatenation avoids Groovy 'GString' key-equality failures with 'Properties.containsKey()'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
now recognizes versions that have the -1 version suffix. will create a version without the suffix even if its that way in the .properties file.
for example, 17.11-1 will be 17.11 version