Skip to content

chore(root): clean up unused code change entries - #1

Merged
drav0011 merged 1 commit into
mainfrom
sentry-fixes
Jul 25, 2026
Merged

chore(root): clean up unused code change entries#1
drav0011 merged 1 commit into
mainfrom
sentry-fixes

Conversation

@drav0011

@drav0011drav0011 commented Jul 25, 2026

Copy link
Copy Markdown
Member

This pull request introduces several improvements and fixes to error reporting, dependency management, download handling, and testing in the web application. The most significant changes include filtering out unactionable Sentry errors, updating TanStack dependencies, improving download file name resolution, and adding a dedicated Vitest configuration.

Error reporting improvements:

  • Added a centralized Sentry configuration in sentry.ts to filter out errors from third-party scripts and browser extensions, ignore unactionable events, and prevent reporting errors without usable stack traces. This configuration is integrated into Sentry initialization in router.tsx. [1][2][3]
  • Added .mcp.json for Sentry MCP server configuration.

Dependency updates:

  • Updated several @tanstack dependencies to their latest versions in package.json to keep the codebase current and benefit from bug fixes and improvements. [1][2]

Download handling improvements:

  • Improved file name resolution for downloads by introducing resolveDownloadFileName in packs.ts, updating its usage in SelectedPacks.tsx, and adding comprehensive tests in packs.test.ts. This ensures robust handling of various URL formats and edge cases. [1][2][3][4]

Testing setup:

  • Added a standalone vitest.config.ts to configure module aliasing and test environment, separating test configuration from the main Vite build.

Other changes:

  • Updated the generated route tree in routeTree.gen.ts for improved consistency and type safety. [1][2][3]
  • Limited the display of TanStack Devtools to development mode only in __root.tsx. [1][2]

- Remove empty code change entries from the changes log
- Streamline the commit history for better readability
CopilotAI review requested due to automatic review settings July 25, 2026 00:28

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the web app’s download UX and client-side observability setup, while also bumping several TanStack-related dependencies and introducing a dedicated Vitest config for the app.

Changes:

  • Hardened download filename derivation so malformed/relative URLs won’t break the download click path, with regression tests.
  • Added centralized Sentry client filtering (ignore/deny lists + beforeSend) and reduced devtools exposure by gating TanStack Devtools to dev builds.
  • Updated TanStack package versions (and lockfile) and added apps/web/vitest.config.ts to keep tests isolated from Vite/Nitro plugin setup.

Reviewed changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated 2 comments.

Show a summary per file
FileDescription
pnpm-lock.yamlUpdates lockfile to reflect dependency upgrades (notably TanStack stack + transitive updates).
apps/web/vitest.config.tsAdds Vitest config with @ alias so tests don’t import Nitro/TanStack Start/Sentry build plugins.
apps/web/src/utils/packs.tsAdds resolveDownloadFileName helper to safely derive a.download from possibly malformed/relative URLs.
apps/web/src/utils/packs.test.tsAdds Vitest coverage for filename parsing/decoding and “does not throw” regression cases.
apps/web/src/routeTree.gen.tsRegenerated route tree (ordering/structure changes likely from dependency updates).
apps/web/src/routes/__root.tsxWraps <TanStackDevtools /> with import.meta.env.DEV so it’s dev-only.
apps/web/src/router.tsxAdds Sentry config: drops BrowserApiErrors, adds ignore/deny lists and beforeSend filtering.
apps/web/src/config/sentry.tsIntroduces centralized Sentry filtering configuration and a beforeSend event dropper.
apps/web/src/components/pack-selection/SelectedPacks.tsxUses resolveDownloadFileName to avoid new URL(...) throwing and aborting downloads.
apps/web/package.jsonBumps TanStack dependencies and eslint plugin query version.
.mcp.jsonAdds an MCP server definition for Sentry.
Comments suppressed due to low confidence (1)

apps/web/src/config/sentry.ts:65

  • This function is typed with ErrorEvent, but Sentry passes a Sentry Event object into beforeSend. Keeping ErrorEvent here will cause TypeScript errors and can mislead future changes.
export function dropUnactionableEvent(event: ErrorEvent): ErrorEvent | null {

Comment threadapps/web/src/config/sentry.ts
Comment threadapps/web/package.json
@drav0011
drav0011 merged commit a9b3bb3 into mainJul 25, 2026
1 check passed
@drav0011
drav0011 deleted the sentry-fixes branch July 25, 2026 04:07
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@drav0011