fix(driver): reject unavailable page source - #150
Open
BenSheridanEdwards wants to merge 1 commit into
Open
BenSheridanEdwards wants to merge 1 commit into
BenSheridanEdwards wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #149
Summary
browser.getPageSource()failures instead of converting them to empty XML.Proof
npm run check— Biome checked 57 files; TypeScript passed.npm test— 230 passed, 0 failed.Better than exact
mainExact baseline:
dfa57e72047c155a97e512121ed8608368108597.With the new regression tests applied to that baseline:
On this PR head:
Observable change: persistent source failure now rejects positive and negative assertions with the original source error; a transient failure is retried; a negative assertion passes only after a successful snapshot proves absence. A fresh consumer installed from
npm packrecovered on the second source read and then proved legitimate absence for both iOS and Android.Reviewer view
Not applicablewith the reason for a trivial PR: reviewwdioDriver.sourceand the six platform-parameterized assertion cases; no locator, expect, config, or CLI implementation changed.src/driver.ts(Driver.source,wdioDriver);test/driver.test.ts;node --import tsx --test test/driver.test.ts;npm run check;npm test;npm run build.Risk
waitUntilrecovery remains unchanged and retries transient source errors. Successful empty/absent snapshots still satisfy negative assertions.detect-changes: 2 files, 3 symbols, 3 affected flows; medium risk (Locator → WdioDriver,Launch → WdioDriver,Navigate → WdioDriver).eef00117adac9c705e9ef8084e4e62b818709159.Notes
PR Proof Law
.agents/DEFINITION_OF_DONE.mdand.agents/skills/pr-inline-screenshot-proof/SKILL.md., or the proof section saysNot applicablewith the technical reason.