fix(publish): read release body via env, not inline shell interpolation - #11

Merged
tastybento merged 1 commit into
masterfrom
fix/publish-changelog-shell-injection
Jul 1, 2026
Merged

fix(publish): read release body via env, not inline shell interpolation#11
tastybento merged 1 commit into
masterfrom
fix/publish-changelog-shell-injection

Conversation

@tastybento

Copy link
Copy Markdown
Member

Problem

publish-platforms.yml's prep step staged the changelog with:

BODY=${{ toJSON(github.event.release.body) }}

toJSON escapes ", \ and newlines, but not backticks or $(...), which remain live inside the resulting double-quoted shell string. A release whose body contains an inline `code` span therefore executes it as a command:

line 26: Util.componentToLegacy: command not found
##[error]Process completed with exit code 127.

This broke BentoBox's 3.18.1 CurseForge/Hangar publish (failed run), is a shell-injection vector (a crafted release body could run arbitrary commands on the runner), and also left literal \r\n in changelog.md.

Fix

Pass the body through the environment and read it with "$RELEASE_BODY", so the shell never parses its contents:

env:
RELEASE_BODY: ${{ github.event.release.body }}run: | ... BODY="${RELEASE_BODY:-}" if [ -z "$BODY" ] || [ "$BODY" = "null" ]; then BODY="Release $VERSION"; fi

Backticks, $(...) and $VAR in release notes are now preserved literally, real newlines survive, and manual workflow_dispatch (no release event → empty body) still falls back to Release $VERSION.

Blast radius

This reusable workflow is used by every BentoBox repo's publish, so the fix applies org-wide. Consumers pin it by SHA; they'll pick up the fix when they re-pin to the merge commit.

🤖 Generated with Claude Code

https://claude.ai/code/session_0153KLwL66bB31pTc4BtsTMd

The prep step set BODY=${{ toJSON(github.event.release.body) }}. toJSON
escapes quotes/backslashes/newlines but NOT backticks or $(...), so those
stay live inside the resulting double-quoted shell string. A release body
containing an inline `code` span (backticks) therefore ran as a command
(exit 127 "command not found") and aborted the publish; it was also a
shell-injection vector and left literal \r\n in changelog.md.
Pass the body through the environment (RELEASE_BODY) and read it with
"$RELEASE_BODY" so the shell never parses its contents. Manual dispatch
(no release event) yields an empty body and still falls back to
"Release $VERSION".
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0153KLwL66bB31pTc4BtsTMd
@tastybento
tastybento merged commit fe4b1f0 into masterJul 1, 2026
tastybento added a commit to BentoBoxWorld/BentoBox that referenced this pull request Jul 1, 2026
Picks up BentoBoxWorld/.github#11 — the publish prep step now reads the
release body from an env var instead of inlining it into the shell, so
backticks/$() in release notes no longer break the CurseForge/Hangar
publish (as happened on 3.18.1).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0153KLwL66bB31pTc4BtsTMd
@tastybento
tastybento deleted the fix/publish-changelog-shell-injection branch July 1, 2026 06:10
tastybento added a commit to BentoBoxWorld/Biomes that referenced this pull request Jul 1, 2026
Picks up BentoBoxWorld/.github#11 — the publish prep step now reads the
release
body from an environment variable instead of inlining it into the shell.
Inline
interpolation left backticks and command-substitution live inside the
shell
string, which broke the CurseForge/Hangar publish when release notes
contained
inline code (as happened on BentoBox 3.18.1). No change to this repo's
build.
Generated with Claude Code.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@tastybento
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

fix(publish): read release body via env, not inline shell interpolation - #11

Merged
tastybento merged 1 commit into
masterfrom
fix/publish-changelog-shell-injection
Jul 1, 2026
Merged

fix(publish): read release body via env, not inline shell interpolation#11
tastybento merged 1 commit into
masterfrom
fix/publish-changelog-shell-injection

Conversation

@tastybento

Copy link
Copy Markdown
Member

Problem

publish-platforms.yml's prep step staged the changelog with:

BODY=${{ toJSON(github.event.release.body) }}

toJSON escapes ", \ and newlines, but not backticks or $(...), which remain live inside the resulting double-quoted shell string. A release whose body contains an inline `code` span therefore executes it as a command:

line 26: Util.componentToLegacy: command not found
##[error]Process completed with exit code 127.

This broke BentoBox's 3.18.1 CurseForge/Hangar publish (failed run), is a shell-injection vector (a crafted release body could run arbitrary commands on the runner), and also left literal \r\n in changelog.md.

Fix

Pass the body through the environment and read it with "$RELEASE_BODY", so the shell never parses its contents:

env:
RELEASE_BODY: ${{ github.event.release.body }}run: | ... BODY="${RELEASE_BODY:-}" if [ -z "$BODY" ] || [ "$BODY" = "null" ]; then BODY="Release $VERSION"; fi

Backticks, $(...) and $VAR in release notes are now preserved literally, real newlines survive, and manual workflow_dispatch (no release event → empty body) still falls back to Release $VERSION.

Blast radius

This reusable workflow is used by every BentoBox repo's publish, so the fix applies org-wide. Consumers pin it by SHA; they'll pick up the fix when they re-pin to the merge commit.

🤖 Generated with Claude Code

https://claude.ai/code/session_0153KLwL66bB31pTc4BtsTMd

The prep step set BODY=${{ toJSON(github.event.release.body) }}. toJSON
escapes quotes/backslashes/newlines but NOT backticks or $(...), so those
stay live inside the resulting double-quoted shell string. A release body
containing an inline `code` span (backticks) therefore ran as a command
(exit 127 "command not found") and aborted the publish; it was also a
shell-injection vector and left literal \r\n in changelog.md.
Pass the body through the environment (RELEASE_BODY) and read it with
"$RELEASE_BODY" so the shell never parses its contents. Manual dispatch
(no release event) yields an empty body and still falls back to
"Release $VERSION".
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0153KLwL66bB31pTc4BtsTMd
@tastybento
tastybento merged commit fe4b1f0 into masterJul 1, 2026
tastybento added a commit to BentoBoxWorld/BentoBox that referenced this pull request Jul 1, 2026
Picks up BentoBoxWorld/.github#11 — the publish prep step now reads the
release body from an env var instead of inlining it into the shell, so
backticks/$() in release notes no longer break the CurseForge/Hangar
publish (as happened on 3.18.1).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0153KLwL66bB31pTc4BtsTMd
@tastybento
tastybento deleted the fix/publish-changelog-shell-injection branch July 1, 2026 06:10
tastybento added a commit to BentoBoxWorld/Biomes that referenced this pull request Jul 1, 2026
Picks up BentoBoxWorld/.github#11 — the publish prep step now reads the
release
body from an environment variable instead of inlining it into the shell.
Inline
interpolation left backticks and command-substitution live inside the
shell
string, which broke the CurseForge/Hangar publish when release notes
contained
inline code (as happened on BentoBox 3.18.1). No change to this repo's
build.
Generated with Claude Code.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@tastybento
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(publish): read release body via env, not inline shell interpolation - #11

Merged
tastybento merged 1 commit into
masterfrom
fix/publish-changelog-shell-injection
Jul 1, 2026
Merged

fix(publish): read release body via env, not inline shell interpolation#11
tastybento merged 1 commit into
masterfrom
fix/publish-changelog-shell-injection

Conversation

@tastybento

Copy link
Copy Markdown
Member

Problem

publish-platforms.yml's prep step staged the changelog with:

BODY=${{ toJSON(github.event.release.body) }}

toJSON escapes ", \ and newlines, but not backticks or $(...), which remain live inside the resulting double-quoted shell string. A release whose body contains an inline `code` span therefore executes it as a command:

line 26: Util.componentToLegacy: command not found
##[error]Process completed with exit code 127.

This broke BentoBox's 3.18.1 CurseForge/Hangar publish (failed run), is a shell-injection vector (a crafted release body could run arbitrary commands on the runner), and also left literal \r\n in changelog.md.

Fix

Pass the body through the environment and read it with "$RELEASE_BODY", so the shell never parses its contents:

env:
RELEASE_BODY: ${{ github.event.release.body }}run: | ... BODY="${RELEASE_BODY:-}" if [ -z "$BODY" ] || [ "$BODY" = "null" ]; then BODY="Release $VERSION"; fi

Backticks, $(...) and $VAR in release notes are now preserved literally, real newlines survive, and manual workflow_dispatch (no release event → empty body) still falls back to Release $VERSION.

Blast radius

This reusable workflow is used by every BentoBox repo's publish, so the fix applies org-wide. Consumers pin it by SHA; they'll pick up the fix when they re-pin to the merge commit.

🤖 Generated with Claude Code

https://claude.ai/code/session_0153KLwL66bB31pTc4BtsTMd

The prep step set BODY=${{ toJSON(github.event.release.body) }}. toJSON
escapes quotes/backslashes/newlines but NOT backticks or $(...), so those
stay live inside the resulting double-quoted shell string. A release body
containing an inline `code` span (backticks) therefore ran as a command
(exit 127 "command not found") and aborted the publish; it was also a
shell-injection vector and left literal \r\n in changelog.md.
Pass the body through the environment (RELEASE_BODY) and read it with
"$RELEASE_BODY" so the shell never parses its contents. Manual dispatch
(no release event) yields an empty body and still falls back to
"Release $VERSION".
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0153KLwL66bB31pTc4BtsTMd
@tastybento
tastybento merged commit fe4b1f0 into masterJul 1, 2026
tastybento added a commit to BentoBoxWorld/BentoBox that referenced this pull request Jul 1, 2026
Picks up BentoBoxWorld/.github#11 — the publish prep step now reads the
release body from an env var instead of inlining it into the shell, so
backticks/$() in release notes no longer break the CurseForge/Hangar
publish (as happened on 3.18.1).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0153KLwL66bB31pTc4BtsTMd
@tastybento
tastybento deleted the fix/publish-changelog-shell-injection branch July 1, 2026 06:10
tastybento added a commit to BentoBoxWorld/Biomes that referenced this pull request Jul 1, 2026
Picks up BentoBoxWorld/.github#11 — the publish prep step now reads the
release
body from an environment variable instead of inlining it into the shell.
Inline
interpolation left backticks and command-substitution live inside the
shell
string, which broke the CurseForge/Hangar publish when release notes
contained
inline code (as happened on BentoBox 3.18.1). No change to this repo's
build.
Generated with Claude Code.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@tastybento
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(publish): read release body via env, not inline shell interpolation - #11

Merged
tastybento merged 1 commit into
masterfrom
fix/publish-changelog-shell-injection
Jul 1, 2026
Merged

fix(publish): read release body via env, not inline shell interpolation#11
tastybento merged 1 commit into
masterfrom
fix/publish-changelog-shell-injection

Conversation

@tastybento

Copy link
Copy Markdown
Member

Problem

publish-platforms.yml's prep step staged the changelog with:

BODY=${{ toJSON(github.event.release.body) }}

toJSON escapes ", \ and newlines, but not backticks or $(...), which remain live inside the resulting double-quoted shell string. A release whose body contains an inline `code` span therefore executes it as a command:

line 26: Util.componentToLegacy: command not found
##[error]Process completed with exit code 127.

This broke BentoBox's 3.18.1 CurseForge/Hangar publish (failed run), is a shell-injection vector (a crafted release body could run arbitrary commands on the runner), and also left literal \r\n in changelog.md.

Fix

Pass the body through the environment and read it with "$RELEASE_BODY", so the shell never parses its contents:

env:
RELEASE_BODY: ${{ github.event.release.body }}run: | ... BODY="${RELEASE_BODY:-}" if [ -z "$BODY" ] || [ "$BODY" = "null" ]; then BODY="Release $VERSION"; fi

Backticks, $(...) and $VAR in release notes are now preserved literally, real newlines survive, and manual workflow_dispatch (no release event → empty body) still falls back to Release $VERSION.

Blast radius

This reusable workflow is used by every BentoBox repo's publish, so the fix applies org-wide. Consumers pin it by SHA; they'll pick up the fix when they re-pin to the merge commit.

🤖 Generated with Claude Code

https://claude.ai/code/session_0153KLwL66bB31pTc4BtsTMd

The prep step set BODY=${{ toJSON(github.event.release.body) }}. toJSON
escapes quotes/backslashes/newlines but NOT backticks or $(...), so those
stay live inside the resulting double-quoted shell string. A release body
containing an inline `code` span (backticks) therefore ran as a command
(exit 127 "command not found") and aborted the publish; it was also a
shell-injection vector and left literal \r\n in changelog.md.
Pass the body through the environment (RELEASE_BODY) and read it with
"$RELEASE_BODY" so the shell never parses its contents. Manual dispatch
(no release event) yields an empty body and still falls back to
"Release $VERSION".
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0153KLwL66bB31pTc4BtsTMd
@tastybento
tastybento merged commit fe4b1f0 into masterJul 1, 2026
tastybento added a commit to BentoBoxWorld/BentoBox that referenced this pull request Jul 1, 2026
Picks up BentoBoxWorld/.github#11 — the publish prep step now reads the
release body from an env var instead of inlining it into the shell, so
backticks/$() in release notes no longer break the CurseForge/Hangar
publish (as happened on 3.18.1).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0153KLwL66bB31pTc4BtsTMd
@tastybento
tastybento deleted the fix/publish-changelog-shell-injection branch July 1, 2026 06:10
tastybento added a commit to BentoBoxWorld/Biomes that referenced this pull request Jul 1, 2026
Picks up BentoBoxWorld/.github#11 — the publish prep step now reads the
release
body from an environment variable instead of inlining it into the shell.
Inline
interpolation left backticks and command-substitution live inside the
shell
string, which broke the CurseForge/Hangar publish when release notes
contained
inline code (as happened on BentoBox 3.18.1). No change to this repo's
build.
Generated with Claude Code.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@tastybento
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

fix(publish): read release body via env, not inline shell interpolation - #11

Merged
tastybento merged 1 commit into
masterfrom
fix/publish-changelog-shell-injection
Jul 1, 2026
Merged

fix(publish): read release body via env, not inline shell interpolation#11
tastybento merged 1 commit into
masterfrom
fix/publish-changelog-shell-injection

Conversation

@tastybento

Copy link
Copy Markdown
Member

Problem

publish-platforms.yml's prep step staged the changelog with:

BODY=${{ toJSON(github.event.release.body) }}

toJSON escapes ", \ and newlines, but not backticks or $(...), which remain live inside the resulting double-quoted shell string. A release whose body contains an inline `code` span therefore executes it as a command:

line 26: Util.componentToLegacy: command not found
##[error]Process completed with exit code 127.

This broke BentoBox's 3.18.1 CurseForge/Hangar publish (failed run), is a shell-injection vector (a crafted release body could run arbitrary commands on the runner), and also left literal \r\n in changelog.md.

Fix

Pass the body through the environment and read it with "$RELEASE_BODY", so the shell never parses its contents:

env:
RELEASE_BODY: ${{ github.event.release.body }}run: | ... BODY="${RELEASE_BODY:-}" if [ -z "$BODY" ] || [ "$BODY" = "null" ]; then BODY="Release $VERSION"; fi

Backticks, $(...) and $VAR in release notes are now preserved literally, real newlines survive, and manual workflow_dispatch (no release event → empty body) still falls back to Release $VERSION.

Blast radius

This reusable workflow is used by every BentoBox repo's publish, so the fix applies org-wide. Consumers pin it by SHA; they'll pick up the fix when they re-pin to the merge commit.

🤖 Generated with Claude Code

https://claude.ai/code/session_0153KLwL66bB31pTc4BtsTMd

The prep step set BODY=${{ toJSON(github.event.release.body) }}. toJSON
escapes quotes/backslashes/newlines but NOT backticks or $(...), so those
stay live inside the resulting double-quoted shell string. A release body
containing an inline `code` span (backticks) therefore ran as a command
(exit 127 "command not found") and aborted the publish; it was also a
shell-injection vector and left literal \r\n in changelog.md.
Pass the body through the environment (RELEASE_BODY) and read it with
"$RELEASE_BODY" so the shell never parses its contents. Manual dispatch
(no release event) yields an empty body and still falls back to
"Release $VERSION".
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0153KLwL66bB31pTc4BtsTMd
@tastybento
tastybento merged commit fe4b1f0 into masterJul 1, 2026
tastybento added a commit to BentoBoxWorld/BentoBox that referenced this pull request Jul 1, 2026
Picks up BentoBoxWorld/.github#11 — the publish prep step now reads the
release body from an env var instead of inlining it into the shell, so
backticks/$() in release notes no longer break the CurseForge/Hangar
publish (as happened on 3.18.1).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0153KLwL66bB31pTc4BtsTMd
@tastybento
tastybento deleted the fix/publish-changelog-shell-injection branch July 1, 2026 06:10
tastybento added a commit to BentoBoxWorld/Biomes that referenced this pull request Jul 1, 2026
Picks up BentoBoxWorld/.github#11 — the publish prep step now reads the
release
body from an environment variable instead of inlining it into the shell.
Inline
interpolation left backticks and command-substitution live inside the
shell
string, which broke the CurseForge/Hangar publish when release notes
contained
inline code (as happened on BentoBox 3.18.1). No change to this repo's
build.
Generated with Claude Code.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@tastybento
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(publish): read release body via env, not inline shell interpolation - #11

Merged
tastybento merged 1 commit into
masterfrom
fix/publish-changelog-shell-injection
Jul 1, 2026
Merged

fix(publish): read release body via env, not inline shell interpolation#11
tastybento merged 1 commit into
masterfrom
fix/publish-changelog-shell-injection

Conversation

@tastybento

Copy link
Copy Markdown
Member

Problem

publish-platforms.yml's prep step staged the changelog with:

BODY=${{ toJSON(github.event.release.body) }}

toJSON escapes ", \ and newlines, but not backticks or $(...), which remain live inside the resulting double-quoted shell string. A release whose body contains an inline `code` span therefore executes it as a command:

line 26: Util.componentToLegacy: command not found
##[error]Process completed with exit code 127.

This broke BentoBox's 3.18.1 CurseForge/Hangar publish (failed run), is a shell-injection vector (a crafted release body could run arbitrary commands on the runner), and also left literal \r\n in changelog.md.

Fix

Pass the body through the environment and read it with "$RELEASE_BODY", so the shell never parses its contents:

env:
RELEASE_BODY: ${{ github.event.release.body }}run: | ... BODY="${RELEASE_BODY:-}" if [ -z "$BODY" ] || [ "$BODY" = "null" ]; then BODY="Release $VERSION"; fi

Backticks, $(...) and $VAR in release notes are now preserved literally, real newlines survive, and manual workflow_dispatch (no release event → empty body) still falls back to Release $VERSION.

Blast radius

This reusable workflow is used by every BentoBox repo's publish, so the fix applies org-wide. Consumers pin it by SHA; they'll pick up the fix when they re-pin to the merge commit.

🤖 Generated with Claude Code

https://claude.ai/code/session_0153KLwL66bB31pTc4BtsTMd

The prep step set BODY=${{ toJSON(github.event.release.body) }}. toJSON
escapes quotes/backslashes/newlines but NOT backticks or $(...), so those
stay live inside the resulting double-quoted shell string. A release body
containing an inline `code` span (backticks) therefore ran as a command
(exit 127 "command not found") and aborted the publish; it was also a
shell-injection vector and left literal \r\n in changelog.md.
Pass the body through the environment (RELEASE_BODY) and read it with
"$RELEASE_BODY" so the shell never parses its contents. Manual dispatch
(no release event) yields an empty body and still falls back to
"Release $VERSION".
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0153KLwL66bB31pTc4BtsTMd
@tastybento
tastybento merged commit fe4b1f0 into masterJul 1, 2026
tastybento added a commit to BentoBoxWorld/BentoBox that referenced this pull request Jul 1, 2026
Picks up BentoBoxWorld/.github#11 — the publish prep step now reads the
release body from an env var instead of inlining it into the shell, so
backticks/$() in release notes no longer break the CurseForge/Hangar
publish (as happened on 3.18.1).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0153KLwL66bB31pTc4BtsTMd
@tastybento
tastybento deleted the fix/publish-changelog-shell-injection branch July 1, 2026 06:10
tastybento added a commit to BentoBoxWorld/Biomes that referenced this pull request Jul 1, 2026
Picks up BentoBoxWorld/.github#11 — the publish prep step now reads the
release
body from an environment variable instead of inlining it into the shell.
Inline
interpolation left backticks and command-substitution live inside the
shell
string, which broke the CurseForge/Hangar publish when release notes
contained
inline code (as happened on BentoBox 3.18.1). No change to this repo's
build.
Generated with Claude Code.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@tastybento
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(publish): read release body via env, not inline shell interpolation - #11

Merged
tastybento merged 1 commit into
masterfrom
fix/publish-changelog-shell-injection
Jul 1, 2026
Merged

fix(publish): read release body via env, not inline shell interpolation#11
tastybento merged 1 commit into
masterfrom
fix/publish-changelog-shell-injection

Conversation

@tastybento

Copy link
Copy Markdown
Member

Problem

publish-platforms.yml's prep step staged the changelog with:

BODY=${{ toJSON(github.event.release.body) }}

toJSON escapes ", \ and newlines, but not backticks or $(...), which remain live inside the resulting double-quoted shell string. A release whose body contains an inline `code` span therefore executes it as a command:

line 26: Util.componentToLegacy: command not found
##[error]Process completed with exit code 127.

This broke BentoBox's 3.18.1 CurseForge/Hangar publish (failed run), is a shell-injection vector (a crafted release body could run arbitrary commands on the runner), and also left literal \r\n in changelog.md.

Fix

Pass the body through the environment and read it with "$RELEASE_BODY", so the shell never parses its contents:

env:
RELEASE_BODY: ${{ github.event.release.body }}run: | ... BODY="${RELEASE_BODY:-}" if [ -z "$BODY" ] || [ "$BODY" = "null" ]; then BODY="Release $VERSION"; fi

Backticks, $(...) and $VAR in release notes are now preserved literally, real newlines survive, and manual workflow_dispatch (no release event → empty body) still falls back to Release $VERSION.

Blast radius

This reusable workflow is used by every BentoBox repo's publish, so the fix applies org-wide. Consumers pin it by SHA; they'll pick up the fix when they re-pin to the merge commit.

🤖 Generated with Claude Code

https://claude.ai/code/session_0153KLwL66bB31pTc4BtsTMd

The prep step set BODY=${{ toJSON(github.event.release.body) }}. toJSON
escapes quotes/backslashes/newlines but NOT backticks or $(...), so those
stay live inside the resulting double-quoted shell string. A release body
containing an inline `code` span (backticks) therefore ran as a command
(exit 127 "command not found") and aborted the publish; it was also a
shell-injection vector and left literal \r\n in changelog.md.
Pass the body through the environment (RELEASE_BODY) and read it with
"$RELEASE_BODY" so the shell never parses its contents. Manual dispatch
(no release event) yields an empty body and still falls back to
"Release $VERSION".
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0153KLwL66bB31pTc4BtsTMd
@tastybento
tastybento merged commit fe4b1f0 into masterJul 1, 2026
tastybento added a commit to BentoBoxWorld/BentoBox that referenced this pull request Jul 1, 2026
Picks up BentoBoxWorld/.github#11 — the publish prep step now reads the
release body from an env var instead of inlining it into the shell, so
backticks/$() in release notes no longer break the CurseForge/Hangar
publish (as happened on 3.18.1).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0153KLwL66bB31pTc4BtsTMd
@tastybento
tastybento deleted the fix/publish-changelog-shell-injection branch July 1, 2026 06:10
tastybento added a commit to BentoBoxWorld/Biomes that referenced this pull request Jul 1, 2026
Picks up BentoBoxWorld/.github#11 — the publish prep step now reads the
release
body from an environment variable instead of inlining it into the shell.
Inline
interpolation left backticks and command-substitution live inside the
shell
string, which broke the CurseForge/Hangar publish when release notes
contained
inline code (as happened on BentoBox 3.18.1). No change to this repo's
build.
Generated with Claude Code.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@tastybento
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

fix(publish): read release body via env, not inline shell interpolation - #11

Merged
tastybento merged 1 commit into
masterfrom
fix/publish-changelog-shell-injection
Jul 1, 2026
Merged

fix(publish): read release body via env, not inline shell interpolation#11
tastybento merged 1 commit into
masterfrom
fix/publish-changelog-shell-injection

Conversation

@tastybento

Copy link
Copy Markdown
Member

Problem

publish-platforms.yml's prep step staged the changelog with:

BODY=${{ toJSON(github.event.release.body) }}

toJSON escapes ", \ and newlines, but not backticks or $(...), which remain live inside the resulting double-quoted shell string. A release whose body contains an inline `code` span therefore executes it as a command:

line 26: Util.componentToLegacy: command not found
##[error]Process completed with exit code 127.

This broke BentoBox's 3.18.1 CurseForge/Hangar publish (failed run), is a shell-injection vector (a crafted release body could run arbitrary commands on the runner), and also left literal \r\n in changelog.md.

Fix

Pass the body through the environment and read it with "$RELEASE_BODY", so the shell never parses its contents:

env:
RELEASE_BODY: ${{ github.event.release.body }}run: | ... BODY="${RELEASE_BODY:-}" if [ -z "$BODY" ] || [ "$BODY" = "null" ]; then BODY="Release $VERSION"; fi

Backticks, $(...) and $VAR in release notes are now preserved literally, real newlines survive, and manual workflow_dispatch (no release event → empty body) still falls back to Release $VERSION.

Blast radius

This reusable workflow is used by every BentoBox repo's publish, so the fix applies org-wide. Consumers pin it by SHA; they'll pick up the fix when they re-pin to the merge commit.

🤖 Generated with Claude Code

https://claude.ai/code/session_0153KLwL66bB31pTc4BtsTMd

The prep step set BODY=${{ toJSON(github.event.release.body) }}. toJSON
escapes quotes/backslashes/newlines but NOT backticks or $(...), so those
stay live inside the resulting double-quoted shell string. A release body
containing an inline `code` span (backticks) therefore ran as a command
(exit 127 "command not found") and aborted the publish; it was also a
shell-injection vector and left literal \r\n in changelog.md.
Pass the body through the environment (RELEASE_BODY) and read it with
"$RELEASE_BODY" so the shell never parses its contents. Manual dispatch
(no release event) yields an empty body and still falls back to
"Release $VERSION".
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0153KLwL66bB31pTc4BtsTMd
@tastybento
tastybento merged commit fe4b1f0 into masterJul 1, 2026
tastybento added a commit to BentoBoxWorld/BentoBox that referenced this pull request Jul 1, 2026
Picks up BentoBoxWorld/.github#11 — the publish prep step now reads the
release body from an env var instead of inlining it into the shell, so
backticks/$() in release notes no longer break the CurseForge/Hangar
publish (as happened on 3.18.1).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0153KLwL66bB31pTc4BtsTMd
@tastybento
tastybento deleted the fix/publish-changelog-shell-injection branch July 1, 2026 06:10
tastybento added a commit to BentoBoxWorld/Biomes that referenced this pull request Jul 1, 2026
Picks up BentoBoxWorld/.github#11 — the publish prep step now reads the
release
body from an environment variable instead of inlining it into the shell.
Inline
interpolation left backticks and command-substitution live inside the
shell
string, which broke the CurseForge/Hangar publish when release notes
contained
inline code (as happened on BentoBox 3.18.1). No change to this repo's
build.
Generated with Claude Code.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@tastybento