Fix NPE when a minion breaks the magic block (#525)

[tastybento]

Fixes#525

Problem

When the JetsMinions Miner minion (an armor stand) breaks the magic block, the block disappears and never respawns, and the console logs an NPE. It must be restored manually with /ob respawnBlock.

java.lang.NullPointerException: Cannot invoke "world.bentobox.bentobox.api.user.User.getMetaData(String)" because "this.user" is null
at ...FlagListener.hasBypassEverywhere(FlagListener.java:216)
at ...FlagListener.checkIsland(FlagListener.java:179)
at ...BlockListener.process(BlockListener.java:354)
at ...BlockListener.lambda$onBlockBreakByMinion$1(BlockListener.java:249)

Root cause

onBlockBreakByMinion calls process(...) with player == null (a minion has no player). process then called BentoBox's checkIsland(event, null, ...), which sets user = null and later dereferences it in hasBypassEverywhere → NPE. The handler aborts before the block can respawn.

This is why the issue only appears from 1.22.0 onward — that release introduced the MAGIC_BLOCK protection flag and thus this checkIsland call. Earlier versions never ran the flag check on the minion path.

Fix

Skip the protection-flag check when there is no player:

if (player != null && !checkIsland((@NonNullEvent) e, player, island.getCenter(), addon.MAGIC_BLOCK)) {
return;
}

The flag check evaluates a user's permissions; there is no user for a minion, so it cannot apply. This restores the pre-1.22.0 minion behaviour while keeping full protection for real players. It's also consistent with the existing "minions cannot fulfill requirements" branch in CheckPhase.phaseRequirementsFail.

Testing

Added testOnBlockBreakByMinionProcessesWithoutPlayer in BlockListenerTest2, which asserts a minion break no longer throws and processing continues past the flag check into phase handling (so the block respawns). All BlockListener tests pass.

🤖 Generated with Claude Code

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
40.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[tastybento]

Fixes#525

Problem

When the JetsMinions Miner minion (an armor stand) breaks the magic block, the block disappears and never respawns, and the console logs an NPE. It must be restored manually with /ob respawnBlock.

java.lang.NullPointerException: Cannot invoke "world.bentobox.bentobox.api.user.User.getMetaData(String)" because "this.user" is null
at ...FlagListener.hasBypassEverywhere(FlagListener.java:216)
at ...FlagListener.checkIsland(FlagListener.java:179)
at ...BlockListener.process(BlockListener.java:354)
at ...BlockListener.lambda$onBlockBreakByMinion$1(BlockListener.java:249)

Root cause

onBlockBreakByMinion calls process(...) with player == null (a minion has no player). process then called BentoBox's checkIsland(event, null, ...), which sets user = null and later dereferences it in hasBypassEverywhere → NPE. The handler aborts before the block can respawn.

This is why the issue only appears from 1.22.0 onward — that release introduced the MAGIC_BLOCK protection flag and thus this checkIsland call. Earlier versions never ran the flag check on the minion path.

Fix

Skip the protection-flag check when there is no player:

if (player != null && !checkIsland((@NonNullEvent) e, player, island.getCenter(), addon.MAGIC_BLOCK)) {
return;
}

The flag check evaluates a user's permissions; there is no user for a minion, so it cannot apply. This restores the pre-1.22.0 minion behaviour while keeping full protection for real players. It's also consistent with the existing "minions cannot fulfill requirements" branch in CheckPhase.phaseRequirementsFail.

Testing

Added testOnBlockBreakByMinionProcessesWithoutPlayer in BlockListenerTest2, which asserts a minion break no longer throws and processing continues past the flag check into phase handling (so the block respawns). All BlockListener tests pass.

🤖 Generated with Claude Code

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
40.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[tastybento]

Fixes#525

Problem

When the JetsMinions Miner minion (an armor stand) breaks the magic block, the block disappears and never respawns, and the console logs an NPE. It must be restored manually with /ob respawnBlock.

java.lang.NullPointerException: Cannot invoke "world.bentobox.bentobox.api.user.User.getMetaData(String)" because "this.user" is null
at ...FlagListener.hasBypassEverywhere(FlagListener.java:216)
at ...FlagListener.checkIsland(FlagListener.java:179)
at ...BlockListener.process(BlockListener.java:354)
at ...BlockListener.lambda$onBlockBreakByMinion$1(BlockListener.java:249)

Root cause

onBlockBreakByMinion calls process(...) with player == null (a minion has no player). process then called BentoBox's checkIsland(event, null, ...), which sets user = null and later dereferences it in hasBypassEverywhere → NPE. The handler aborts before the block can respawn.

This is why the issue only appears from 1.22.0 onward — that release introduced the MAGIC_BLOCK protection flag and thus this checkIsland call. Earlier versions never ran the flag check on the minion path.

Fix

Skip the protection-flag check when there is no player:

if (player != null && !checkIsland((@NonNullEvent) e, player, island.getCenter(), addon.MAGIC_BLOCK)) {
return;
}

The flag check evaluates a user's permissions; there is no user for a minion, so it cannot apply. This restores the pre-1.22.0 minion behaviour while keeping full protection for real players. It's also consistent with the existing "minions cannot fulfill requirements" branch in CheckPhase.phaseRequirementsFail.

Testing

Added testOnBlockBreakByMinionProcessesWithoutPlayer in BlockListenerTest2, which asserts a minion break no longer throws and processing continues past the flag check into phase handling (so the block respawns). All BlockListener tests pass.

🤖 Generated with Claude Code

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
40.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[tastybento]

Fixes#525

Problem

When the JetsMinions Miner minion (an armor stand) breaks the magic block, the block disappears and never respawns, and the console logs an NPE. It must be restored manually with /ob respawnBlock.

java.lang.NullPointerException: Cannot invoke "world.bentobox.bentobox.api.user.User.getMetaData(String)" because "this.user" is null
at ...FlagListener.hasBypassEverywhere(FlagListener.java:216)
at ...FlagListener.checkIsland(FlagListener.java:179)
at ...BlockListener.process(BlockListener.java:354)
at ...BlockListener.lambda$onBlockBreakByMinion$1(BlockListener.java:249)

Root cause

onBlockBreakByMinion calls process(...) with player == null (a minion has no player). process then called BentoBox's checkIsland(event, null, ...), which sets user = null and later dereferences it in hasBypassEverywhere → NPE. The handler aborts before the block can respawn.

This is why the issue only appears from 1.22.0 onward — that release introduced the MAGIC_BLOCK protection flag and thus this checkIsland call. Earlier versions never ran the flag check on the minion path.

Fix

Skip the protection-flag check when there is no player:

if (player != null && !checkIsland((@NonNullEvent) e, player, island.getCenter(), addon.MAGIC_BLOCK)) {
return;
}

The flag check evaluates a user's permissions; there is no user for a minion, so it cannot apply. This restores the pre-1.22.0 minion behaviour while keeping full protection for real players. It's also consistent with the existing "minions cannot fulfill requirements" branch in CheckPhase.phaseRequirementsFail.

Testing

Added testOnBlockBreakByMinionProcessesWithoutPlayer in BlockListenerTest2, which asserts a minion break no longer throws and processing continues past the flag check into phase handling (so the block respawns). All BlockListener tests pass.

🤖 Generated with Claude Code

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
40.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[tastybento]

Fixes#525

Problem

When the JetsMinions Miner minion (an armor stand) breaks the magic block, the block disappears and never respawns, and the console logs an NPE. It must be restored manually with /ob respawnBlock.

java.lang.NullPointerException: Cannot invoke "world.bentobox.bentobox.api.user.User.getMetaData(String)" because "this.user" is null
at ...FlagListener.hasBypassEverywhere(FlagListener.java:216)
at ...FlagListener.checkIsland(FlagListener.java:179)
at ...BlockListener.process(BlockListener.java:354)
at ...BlockListener.lambda$onBlockBreakByMinion$1(BlockListener.java:249)

Root cause

onBlockBreakByMinion calls process(...) with player == null (a minion has no player). process then called BentoBox's checkIsland(event, null, ...), which sets user = null and later dereferences it in hasBypassEverywhere → NPE. The handler aborts before the block can respawn.

This is why the issue only appears from 1.22.0 onward — that release introduced the MAGIC_BLOCK protection flag and thus this checkIsland call. Earlier versions never ran the flag check on the minion path.

Fix

Skip the protection-flag check when there is no player:

if (player != null && !checkIsland((@NonNullEvent) e, player, island.getCenter(), addon.MAGIC_BLOCK)) {
return;
}

The flag check evaluates a user's permissions; there is no user for a minion, so it cannot apply. This restores the pre-1.22.0 minion behaviour while keeping full protection for real players. It's also consistent with the existing "minions cannot fulfill requirements" branch in CheckPhase.phaseRequirementsFail.

Testing

Added testOnBlockBreakByMinionProcessesWithoutPlayer in BlockListenerTest2, which asserts a minion break no longer throws and processing continues past the flag check into phase handling (so the block respawns). All BlockListener tests pass.

🤖 Generated with Claude Code

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
40.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[tastybento]

Fixes#525

Problem

When the JetsMinions Miner minion (an armor stand) breaks the magic block, the block disappears and never respawns, and the console logs an NPE. It must be restored manually with /ob respawnBlock.

java.lang.NullPointerException: Cannot invoke "world.bentobox.bentobox.api.user.User.getMetaData(String)" because "this.user" is null
at ...FlagListener.hasBypassEverywhere(FlagListener.java:216)
at ...FlagListener.checkIsland(FlagListener.java:179)
at ...BlockListener.process(BlockListener.java:354)
at ...BlockListener.lambda$onBlockBreakByMinion$1(BlockListener.java:249)

Root cause

onBlockBreakByMinion calls process(...) with player == null (a minion has no player). process then called BentoBox's checkIsland(event, null, ...), which sets user = null and later dereferences it in hasBypassEverywhere → NPE. The handler aborts before the block can respawn.

This is why the issue only appears from 1.22.0 onward — that release introduced the MAGIC_BLOCK protection flag and thus this checkIsland call. Earlier versions never ran the flag check on the minion path.

Fix

Skip the protection-flag check when there is no player:

if (player != null && !checkIsland((@NonNullEvent) e, player, island.getCenter(), addon.MAGIC_BLOCK)) {
return;
}

The flag check evaluates a user's permissions; there is no user for a minion, so it cannot apply. This restores the pre-1.22.0 minion behaviour while keeping full protection for real players. It's also consistent with the existing "minions cannot fulfill requirements" branch in CheckPhase.phaseRequirementsFail.

Testing

Added testOnBlockBreakByMinionProcessesWithoutPlayer in BlockListenerTest2, which asserts a minion break no longer throws and processing continues past the flag check into phase handling (so the block respawns). All BlockListener tests pass.

🤖 Generated with Claude Code

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
40.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[tastybento]

Fixes#525

Problem

When the JetsMinions Miner minion (an armor stand) breaks the magic block, the block disappears and never respawns, and the console logs an NPE. It must be restored manually with /ob respawnBlock.

java.lang.NullPointerException: Cannot invoke "world.bentobox.bentobox.api.user.User.getMetaData(String)" because "this.user" is null
at ...FlagListener.hasBypassEverywhere(FlagListener.java:216)
at ...FlagListener.checkIsland(FlagListener.java:179)
at ...BlockListener.process(BlockListener.java:354)
at ...BlockListener.lambda$onBlockBreakByMinion$1(BlockListener.java:249)

Root cause

onBlockBreakByMinion calls process(...) with player == null (a minion has no player). process then called BentoBox's checkIsland(event, null, ...), which sets user = null and later dereferences it in hasBypassEverywhere → NPE. The handler aborts before the block can respawn.

This is why the issue only appears from 1.22.0 onward — that release introduced the MAGIC_BLOCK protection flag and thus this checkIsland call. Earlier versions never ran the flag check on the minion path.

Fix

Skip the protection-flag check when there is no player:

if (player != null && !checkIsland((@NonNullEvent) e, player, island.getCenter(), addon.MAGIC_BLOCK)) {
return;
}

The flag check evaluates a user's permissions; there is no user for a minion, so it cannot apply. This restores the pre-1.22.0 minion behaviour while keeping full protection for real players. It's also consistent with the existing "minions cannot fulfill requirements" branch in CheckPhase.phaseRequirementsFail.

Testing

Added testOnBlockBreakByMinionProcessesWithoutPlayer in BlockListenerTest2, which asserts a minion break no longer throws and processing continues past the flag check into phase handling (so the block respawns). All BlockListener tests pass.

🤖 Generated with Claude Code

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
40.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[tastybento]

Fixes#525

Problem

When the JetsMinions Miner minion (an armor stand) breaks the magic block, the block disappears and never respawns, and the console logs an NPE. It must be restored manually with /ob respawnBlock.

java.lang.NullPointerException: Cannot invoke "world.bentobox.bentobox.api.user.User.getMetaData(String)" because "this.user" is null
at ...FlagListener.hasBypassEverywhere(FlagListener.java:216)
at ...FlagListener.checkIsland(FlagListener.java:179)
at ...BlockListener.process(BlockListener.java:354)
at ...BlockListener.lambda$onBlockBreakByMinion$1(BlockListener.java:249)

Root cause

onBlockBreakByMinion calls process(...) with player == null (a minion has no player). process then called BentoBox's checkIsland(event, null, ...), which sets user = null and later dereferences it in hasBypassEverywhere → NPE. The handler aborts before the block can respawn.

This is why the issue only appears from 1.22.0 onward — that release introduced the MAGIC_BLOCK protection flag and thus this checkIsland call. Earlier versions never ran the flag check on the minion path.

Fix

Skip the protection-flag check when there is no player:

if (player != null && !checkIsland((@NonNullEvent) e, player, island.getCenter(), addon.MAGIC_BLOCK)) {
return;
}

The flag check evaluates a user's permissions; there is no user for a minion, so it cannot apply. This restores the pre-1.22.0 minion behaviour while keeping full protection for real players. It's also consistent with the existing "minions cannot fulfill requirements" branch in CheckPhase.phaseRequirementsFail.

Testing

Added testOnBlockBreakByMinionProcessesWithoutPlayer in BlockListenerTest2, which asserts a minion break no longer throws and processing continues past the flag check into phase handling (so the block respawns). All BlockListener tests pass.

🤖 Generated with Claude Code

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
40.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud