Uh oh!
There was an error while loading. Please reload this page.
Add setting to open the challenges GUI while off-island - #407
Merged
Conversation
New gui-settings option (default off) that skips only the location-on-island check when opening /challenges. Completion checks in TryToComplete are unchanged, so island protection still applies when actually completing challenges. Fixes#349 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NKxodNE4h3TsSHMqDEeC8v
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Fixes#349
What
New opt-in setting
gui-settings.open-anywhere(defaultfalse) that lets players open/challengeswithout standing on their island.How
ChallengesPlayerCommand.canExecute()skips only the location-on-island check when the setting is enabled. The "player has no island" check is unchanged.TryToCompletestill enforces being on the island when world protection is on, so this setting only affects viewing.EditSettingsPanel), with en-US locale strings; entry documented inconfig.yml.Tests
Two new cases in
ChallengesCommandTest: off-island with setting off → refused; off-island with setting on → allowed. Full suite green (460 tests, 0 failures).In-game verification
open-anywhere(config or admin GUI), run/challengesfrom spawn — GUI opens./challengesfrom spawn is refused again.🤖 Generated with Claude Code
https://claude.ai/code/session_01NKxodNE4h3TsSHMqDEeC8v