Uh oh!
There was an error while loading. Please reload this page.
Improve #329: tell players how to answer confirmation prompts - #415
Merged
Conversation
The confirmation conversation only accepts specific words (confirm / cancel / ...) but the prompt never said so, so players didn't know they had to type "confirm" in chat. createConfirmation() now appends a locale-driven instruction line to the question via a new confirm-instruction locale string, so every confirmation (import, reset, wipe, ...) tells the player what to type. Translators can localise the sentence and their own confirm/deny words. Extracted the assembly into ConversationUtils.appendConfirmationInstruction and added JUnit coverage for both the appended and empty-locale cases. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NKxodNE4h3TsSHMqDEeC8v
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Fixes#329
Problem
The import/reset/wipe confirmation asks a yes/no question but silently rejects anything except the locale's confirm/deny words. Players (reasonably) don't know they have to type
confirmin chat — the prompt never tells them.Fix
ConversationUtils.createConfirmation()now appends a standard instruction line to the question, driven by a newchallenges.conversations.confirm-instructionlocale string:One change improves every confirmation (import, reset, wipe, …). Because it's a locale string, translators can localise both the sentence and their own confirm/deny words. If a translator clears the string, the question is shown unchanged.
Test
Extracted the assembly into
appendConfirmationInstruction(User, String)and addedConversationUtilsTestcoverage for the appended case and the empty-locale fallback.🤖 Generated with Claude Code