Top 10 placeholder is wrong

[HamtaBot]

Expected behavior

i expect the top ten being right

Observed/Actual behavior

since the changes you made on bentobox about cache now top 10 islands level is wrong and seems to show only some islands, i guess it only show islands loaded after the restart and not actually all islands

Steps/models to reproduce

self explanatory

BentoBox version

bbox version
[16:47:48 INFO]: Serveur PAPER 1.20.1.
[16:47:48 INFO]: (git-UniverseSpigot-"8ee0821" (MC: 1.20.1))
[16:47:48 INFO]: Version de BentoBox : 2.4.0-SNAPSHOT-b2635
[16:47:48 INFO]: Base de données : MARIADB
[16:47:48 INFO]: Mondes de jeu chargés :
[16:47:48 INFO]: oneblock_world (OneBlock) : Overworld
[16:47:48 INFO]: Addons chargés :
[16:47:48 INFO]: AOneBlock 1.14.1 (ENABLED)
[16:47:48 INFO]: Bank 1.7.0-SNAPSHOT-b83 (ENABLED)
[16:47:48 INFO]: Biomes 2.2.0-SNAPSHOT-b251 (ENABLED)
[16:47:48 INFO]: Chat 1.1.4 (ENABLED)
[16:47:48 INFO]: ControlPanel 1.13.1-SNAPSHOT-b61 (ENABLED)
[16:47:48 INFO]: IslandFly 1.11.0-SNAPSHOT-b159 (ENABLED)
[16:47:48 INFO]: Level 2.13.0-SNAPSHOT-b565 (ENABLED)

Plugin list

No response

Other

No response

[tastybento]

Can you explain some more? What specifically is giving you the wrong data? You mention a placeholder? Which one? Or ones?
If the players do /is top do they see the correct top ten? I'm trying to work out if this is just a placeholder issue or not.

[HamtaBot]

Can you explain some more? What specifically is giving you the wrong data? You mention a placeholder? Which one? Or ones? If the players do /is top do they see the correct top ten? I'm trying to work out if this is just a placeholder issue or not.

So at first this error is printed at startup

[05:18:47 WARN]: [BentoBox] Plugin BentoBox v2.4.0-SNAPSHOT-b2635 generated an exception while executing task 293487
java.util.ConcurrentModificationException: null
 at java.util.HashMap.computeIfAbsent(HashMap.java:1229) ~[?:?]
 at world.bentobox.bentobox.managers.island.IslandCache.getIslandById(IslandCache.java:433) ~[BentoBox-2.4.0-SNAPSHOT-b2635.jar:?]
 at world.bentobox.bentobox.managers.IslandsManager.getIslandById(IslandsManager.java:1665) ~[BentoBox-2.4.0-SNAPSHOT-b2635.jar:?]
 at world.bentobox.level.LevelsManager.lambda$loadTopTens$16(LevelsManager.java:418) ~[Level-2.13.0-SNAPSHOT-b565 (1).jar:?]
 at java.util.ArrayList.forEach(ArrayList.java:1596) ~[?:?]
 at world.bentobox.level.LevelsManager.lambda$loadTopTens$18(LevelsManager.java:416) ~[Level-2.13.0-SNAPSHOT-b565 (1).jar:?]
 at org.bukkit.craftbukkit.v1_20_R1.scheduler.CraftTask.run(CraftTask.java:100) ~[?:git-UniverseSpigot-"8ee0821"]
 at org.bukkit.craftbukkit.v1_20_R1.scheduler.CraftAsyncTask.run(CraftAsyncTask.java:57) ~[?:git-UniverseSpigot-"8ee0821"]
 at com.destroystokyo.paper.ServerSchedulerReportingWrapper.run(ServerSchedulerReportingWrapper.java:22) ~[?:git-UniverseSpigot-"8ee0821"]
 at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144) ~[?:?]
 at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642) ~[?:?]
 at java.lang.Thread.run(Thread.java:1583) ~[?:?]

[HamtaBot]

then my is top or top hologram all uses bentobox placeholder its not the default menu so placeholder used are
%Level_aoneblock_top_name_1% and %Level_aoneblock_top_value_1%
nd that from 1 to 10 , the data is wrong because i have an alt account which i didnt logged to test and cant see it on top which shouldnt happen since normally the account is 2nd on it

[tastybento]

Found the issue. It's two-fold. First the Level addon was loading islands async, which was okay when before all the islands were already loaded, but now if the island is not in the cache, it has to be loaded, and so we were getting concurrency errors. Second, the Level addon was loading all the islands so that it could build up the Top Tens (for each world). This again was invalidating the minimal cache approach because it was filling up the cache with every island that had run a level calculation. So, the fixes are as follows:

1. Add more API to BentoBox to allow the getting and checking of an Island ID without having to cache or load the island.
2. Use that API in the Level addon. I expect there are quite a few Addons that need to check all the known islands when they are loading. They can now do this without having to fill up the cache.

It's all in progress - just need to get the tests run and then you'll be all set.

[HamtaBot]

Found the issue. It's two-fold. First the Level addon was loading islands async, which was okay when before all the islands were already loaded, but now if the island is not in the cache, it has to be loaded, and so we were getting concurrency errors. Second, the Level addon was loading all the islands so that it could build up the Top Tens (for each world). This again was invalidating the minimal cache approach because it was filling up the cache with every island that had run a level calculation. So, the fixes are as follows:

1. Add more API to BentoBox to allow the getting and checking of an Island ID without having to cache or load the island.
2. Use that API in the Level addon. I expect there are quite a few Addons that need to check all the known islands when they are loading. They can now do this without having to fill up the cache.

It's all in progress - just need to get the tests run and then you'll be all set.

alright sounds good , as i see it on the code and remain about it , could it be possible to get thoses values configurable, same for island bank value

in france we dont use the G prefix but instead Mi

[tastybento]

Okay, all built and done.

Please file another one for the kMFT values.