Skip to content

Fixes an issue where items can be a block but not an item #332#333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tastybento merged 2 commits into from
Sep 18, 2024
Merged

Fixes an issue where items can be a block but not an item #332 #333

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b66ecb2
Fixes an issue where items can be a block but not an item #332
tastybento Sep 18, 2024
db2ebac
Remove unused import
tastybento Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/main/java/world/bentobox/level/panels/ValuePanel.java
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -58,6 +58,7 @@ private ValuePanel(Level addon,
this.activeFilter = Filter.NAME_ASC;
this.materialRecordList = Arrays.stream(Material.values()).
filter(Material::isBlock).
filter(Material::isItem). // Remove things like PITCHER_CROP
filter(m -> !m.name().startsWith("LEGACY_")).
filter(this.addon.getBlockConfig()::isNotHiddenBlock).
map(material ->
Expand DownExpand Up@@ -584,6 +585,7 @@ private PanelItem createMaterialButton(ItemTemplateRecord template, TemplatedPan
return null;
}

@SuppressWarnings("deprecation")
int index = this.pageIndex * slot.amountMap().getOrDefault(BLOCK, 1) + slot.slot();

if (index >= this.elementList.size())
Expand Down