Fix top ten ordering: replace LinkedHashMap with ConcurrentHashMap for thread safety - #403

Merged
tastybento merged 2 commits into
developfrom
copilot/fix-top-ten-order
Mar 2, 2026
Merged

Fix top ten ordering: replace LinkedHashMap with ConcurrentHashMap for thread safety#403
tastybento merged 2 commits into
developfrom
copilot/fix-top-ten-order

Conversation

CopilotAI commented Mar 2, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Top ten leaderboard displays islands in wrong order — e.g., level 65 in 1st place, level 1065 in 6th. The sorting logic in calculateTopTen() is correct, but the underlying TopTenData.topTen map is a LinkedHashMap concurrently mutated from async threads (loadTopTens, setIslandResults) and read/modified from the main thread (getTopTen, createAndCleanRankings). This corrupts LinkedHashMap's internal doubly-linked list, producing incorrect iteration results that the downstream sort operates on. A server restart does not fix this — the same race re-occurs during async loadTopTens() repopulation.

Changes

  • TopTenData: LinkedHashMap → ConcurrentHashMap. Insertion order is irrelevant here since calculateTopTen() always sorts into a fresh LinkedHashMap.
  • LevelsManager.addToTopTen(): Invalidate the 1-second sorted cache via cache.remove(world) on level updates, matching the existing pattern in removeEntry().
  • LevelsManagerTest: Added testGetTopTenSortOrder() covering the reported scenario (mixed insertion order, verifies descending output).
Original prompt

This section details on the original issue you should resolve

<issue_title>Top Ten not showing right order</issue_title>
<issue_description>### Expected behavior

Team with higher levels should be higher in the top ten.

Observed/Actual behavior

Image In this example, oofxjonthan's team made up of the members: * Neetje2011 * offxjonathan * debestepanda * sliv0vitz Is listed in 1st place with a level of 65.

However, TechM's team made up of:

  • TechM
  • EpicTechM
  • darkboy5

has a level of 1065 but is listed in 6th place.

Steps/models to reproduce

The adminfreported this as the current state on their server.

BentoBox version

Unknown right now, but assume latest.

Plugin list

No response

Other

The admin is asking how to get the top ten sorted correctly.</issue_description>

<agent_instructions>Focus on how this could occur as much as any potential fix. There may be a legitimate scenario where this could happen, but it doesn't look likely. If more information is needed from the admin, ask for it.</agent_instructions>

Comments on the Issue (you are @copilot in this section)

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

@tastybento
Fix top ten ordering: use ConcurrentHashMap for thread safety and inv…
c5c6ef2
…alidate cache on update
Co-authored-by: tastybento <4407265+tastybento@users.noreply.github.com>
CopilotAI changed the title [WIP] Fix incorrect order in top ten standingsFix top ten ordering: use ConcurrentHashMap for thread-safe accessMar 2, 2026
CopilotAI changed the title Fix top ten ordering: use ConcurrentHashMap for thread-safe accessFix top ten ordering: replace LinkedHashMap with ConcurrentHashMap for thread safetyMar 2, 2026
@tastybento
tastybento marked this pull request as ready for review March 2, 2026 01:44
@tastybento
tastybento merged commit 9c535c5 into developMar 2, 2026
2 checks passed
@tastybento
tastybento deleted the copilot/fix-top-ten-order branch March 2, 2026 01:44
@sonarqubecloud

sonarqubecloudBot commented Mar 2, 2026

Copy link
Copy Markdown

Quality Gate PassedQuality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@tastybentotastybento

Copilot code reviewCopilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Top Ten not showing right order

2 participants

@tastybento
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Fix top ten ordering: replace LinkedHashMap with ConcurrentHashMap for thread safety - #403
Merged
tastybento merged 2 commits into
developfrom 
copilot/fix-top-ten-order
Mar 2, 2026
Merged
Fix top ten ordering: replace LinkedHashMap with ConcurrentHashMap for thread safety#403
tastybento merged 2 commits into
developfrom 
copilot/fix-top-ten-order
Conversation
CopilotAI
commented
Mar 2, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Top ten leaderboard displays islands in wrong order — e.g., level 65 in 1st place, level 1065 in 6th. The sorting logic in calculateTopTen() is correct, but the underlying TopTenData.topTen map is a LinkedHashMap concurrently mutated from async threads (loadTopTens, setIslandResults) and read/modified from the main thread (getTopTen, createAndCleanRankings). This corrupts LinkedHashMap's internal doubly-linked list, producing incorrect iteration results that the downstream sort operates on. A server restart does not fix this — the same race re-occurs during async loadTopTens() repopulation.
Changes
  • TopTenData: LinkedHashMap → ConcurrentHashMap. Insertion order is irrelevant here since calculateTopTen() always sorts into a fresh LinkedHashMap.
  • LevelsManager.addToTopTen(): Invalidate the 1-second sorted cache via cache.remove(world) on level updates, matching the existing pattern in removeEntry().
  • LevelsManagerTest: Added testGetTopTenSortOrder() covering the reported scenario (mixed insertion order, verifies descending output).
Original prompt
This section details on the original issue you should resolve
<issue_title>Top Ten not showing right order</issue_title>

<issue_description>### Expected behavior
Team with higher levels should be higher in the top ten.
Observed/Actual behavior
Image
In this example, oofxjonthan's team made up of the members:
* Neetje2011
* offxjonathan
* debestepanda
* sliv0vitz
Is listed in 1st place with a level of 65.

However, TechM's team made up of:
  • TechM
  • EpicTechM
  • darkboy5
has a level of 1065 but is listed in 6th place.
Steps/models to reproduce
The adminfreported this as the current state on their server.
BentoBox version
Unknown right now, but assume latest.
Plugin list
No response
Other
The admin is asking how to get the top ten sorted correctly.</issue_description>
<agent_instructions>Focus on how this could occur as much as any potential fix. There may be a legitimate scenario where this could happen, but it doesn't look likely. If more information is needed from the admin, ask for it.</agent_instructions>
Comments on the Issue (you are @copilot in this section)
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.
@tastybento
Fix top ten ordering: use ConcurrentHashMap for thread safety and inv…
c5c6ef2
…alidate cache on update
Co-authored-by: tastybento <4407265+tastybento@users.noreply.github.com>
CopilotAI
changed the title
[WIP] Fix incorrect order in top ten standingsFix top ten ordering: use ConcurrentHashMap for thread-safe accessMar 2, 2026
CopilotAI
changed the title
Fix top ten ordering: use ConcurrentHashMap for thread-safe accessFix top ten ordering: replace LinkedHashMap with ConcurrentHashMap for thread safetyMar 2, 2026
@tastybento
tastybento
marked this pull request as ready for review
March 2, 2026 01:44
@tastybento
tastybento
merged commit 9c535c5
into
developMar 2, 2026

2 checks passed

@tastybento
tastybento
deleted the

copilot/fix-top-ten-order

branch
March 2, 2026 01:44
@sonarqubecloud
sonarqubecloudBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Quality Gate PassedQuality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
See analysis details on SonarQube Cloud
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees

@tastybentotastybento
Copilot code reviewCopilot

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Top Ten not showing right order


2 participants

@tastybento

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Fix top ten ordering: replace LinkedHashMap with ConcurrentHashMap for thread safety - #403
Merged
tastybento merged 2 commits into
developfrom 
copilot/fix-top-ten-order
Mar 2, 2026
Merged
Fix top ten ordering: replace LinkedHashMap with ConcurrentHashMap for thread safety#403
tastybento merged 2 commits into
developfrom 
copilot/fix-top-ten-order
Conversation
CopilotAI
commented
Mar 2, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Top ten leaderboard displays islands in wrong order — e.g., level 65 in 1st place, level 1065 in 6th. The sorting logic in calculateTopTen() is correct, but the underlying TopTenData.topTen map is a LinkedHashMap concurrently mutated from async threads (loadTopTens, setIslandResults) and read/modified from the main thread (getTopTen, createAndCleanRankings). This corrupts LinkedHashMap's internal doubly-linked list, producing incorrect iteration results that the downstream sort operates on. A server restart does not fix this — the same race re-occurs during async loadTopTens() repopulation.
Changes
  • TopTenData: LinkedHashMap → ConcurrentHashMap. Insertion order is irrelevant here since calculateTopTen() always sorts into a fresh LinkedHashMap.
  • LevelsManager.addToTopTen(): Invalidate the 1-second sorted cache via cache.remove(world) on level updates, matching the existing pattern in removeEntry().
  • LevelsManagerTest: Added testGetTopTenSortOrder() covering the reported scenario (mixed insertion order, verifies descending output).
Original prompt
This section details on the original issue you should resolve
<issue_title>Top Ten not showing right order</issue_title>

<issue_description>### Expected behavior
Team with higher levels should be higher in the top ten.
Observed/Actual behavior
Image
In this example, oofxjonthan's team made up of the members:
* Neetje2011
* offxjonathan
* debestepanda
* sliv0vitz
Is listed in 1st place with a level of 65.

However, TechM's team made up of:
  • TechM
  • EpicTechM
  • darkboy5
has a level of 1065 but is listed in 6th place.
Steps/models to reproduce
The adminfreported this as the current state on their server.
BentoBox version
Unknown right now, but assume latest.
Plugin list
No response
Other
The admin is asking how to get the top ten sorted correctly.</issue_description>
<agent_instructions>Focus on how this could occur as much as any potential fix. There may be a legitimate scenario where this could happen, but it doesn't look likely. If more information is needed from the admin, ask for it.</agent_instructions>
Comments on the Issue (you are @copilot in this section)
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.
@tastybento
Fix top ten ordering: use ConcurrentHashMap for thread safety and inv…
c5c6ef2
…alidate cache on update
Co-authored-by: tastybento <4407265+tastybento@users.noreply.github.com>
CopilotAI
changed the title
[WIP] Fix incorrect order in top ten standingsFix top ten ordering: use ConcurrentHashMap for thread-safe accessMar 2, 2026
CopilotAI
changed the title
Fix top ten ordering: use ConcurrentHashMap for thread-safe accessFix top ten ordering: replace LinkedHashMap with ConcurrentHashMap for thread safetyMar 2, 2026
@tastybento
tastybento
marked this pull request as ready for review
March 2, 2026 01:44
@tastybento
tastybento
merged commit 9c535c5
into
developMar 2, 2026

2 checks passed

@tastybento
tastybento
deleted the

copilot/fix-top-ten-order

branch
March 2, 2026 01:44
@sonarqubecloud
sonarqubecloudBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Quality Gate PassedQuality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
See analysis details on SonarQube Cloud
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees

@tastybentotastybento
Copilot code reviewCopilot

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Top Ten not showing right order


2 participants

@tastybento

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Fix top ten ordering: replace LinkedHashMap with ConcurrentHashMap for thread safety - #403
Merged
tastybento merged 2 commits into
developfrom 
copilot/fix-top-ten-order
Mar 2, 2026
Merged
Fix top ten ordering: replace LinkedHashMap with ConcurrentHashMap for thread safety#403
tastybento merged 2 commits into
developfrom 
copilot/fix-top-ten-order
Conversation
CopilotAI
commented
Mar 2, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Top ten leaderboard displays islands in wrong order — e.g., level 65 in 1st place, level 1065 in 6th. The sorting logic in calculateTopTen() is correct, but the underlying TopTenData.topTen map is a LinkedHashMap concurrently mutated from async threads (loadTopTens, setIslandResults) and read/modified from the main thread (getTopTen, createAndCleanRankings). This corrupts LinkedHashMap's internal doubly-linked list, producing incorrect iteration results that the downstream sort operates on. A server restart does not fix this — the same race re-occurs during async loadTopTens() repopulation.
Changes
  • TopTenData: LinkedHashMap → ConcurrentHashMap. Insertion order is irrelevant here since calculateTopTen() always sorts into a fresh LinkedHashMap.
  • LevelsManager.addToTopTen(): Invalidate the 1-second sorted cache via cache.remove(world) on level updates, matching the existing pattern in removeEntry().
  • LevelsManagerTest: Added testGetTopTenSortOrder() covering the reported scenario (mixed insertion order, verifies descending output).
Original prompt
This section details on the original issue you should resolve
<issue_title>Top Ten not showing right order</issue_title>

<issue_description>### Expected behavior
Team with higher levels should be higher in the top ten.
Observed/Actual behavior
Image
In this example, oofxjonthan's team made up of the members:
* Neetje2011
* offxjonathan
* debestepanda
* sliv0vitz
Is listed in 1st place with a level of 65.

However, TechM's team made up of:
  • TechM
  • EpicTechM
  • darkboy5
has a level of 1065 but is listed in 6th place.
Steps/models to reproduce
The adminfreported this as the current state on their server.
BentoBox version
Unknown right now, but assume latest.
Plugin list
No response
Other
The admin is asking how to get the top ten sorted correctly.</issue_description>
<agent_instructions>Focus on how this could occur as much as any potential fix. There may be a legitimate scenario where this could happen, but it doesn't look likely. If more information is needed from the admin, ask for it.</agent_instructions>
Comments on the Issue (you are @copilot in this section)
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.
@tastybento
Fix top ten ordering: use ConcurrentHashMap for thread safety and inv…
c5c6ef2
…alidate cache on update
Co-authored-by: tastybento <4407265+tastybento@users.noreply.github.com>
CopilotAI
changed the title
[WIP] Fix incorrect order in top ten standingsFix top ten ordering: use ConcurrentHashMap for thread-safe accessMar 2, 2026
CopilotAI
changed the title
Fix top ten ordering: use ConcurrentHashMap for thread-safe accessFix top ten ordering: replace LinkedHashMap with ConcurrentHashMap for thread safetyMar 2, 2026
@tastybento
tastybento
marked this pull request as ready for review
March 2, 2026 01:44
@tastybento
tastybento
merged commit 9c535c5
into
developMar 2, 2026

2 checks passed

@tastybento
tastybento
deleted the

copilot/fix-top-ten-order

branch
March 2, 2026 01:44
@sonarqubecloud
sonarqubecloudBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Quality Gate PassedQuality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
See analysis details on SonarQube Cloud
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees

@tastybentotastybento
Copilot code reviewCopilot

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Top Ten not showing right order


2 participants

@tastybento

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Fix top ten ordering: replace LinkedHashMap with ConcurrentHashMap for thread safety - #403
Merged
tastybento merged 2 commits into
developfrom 
copilot/fix-top-ten-order
Mar 2, 2026
Merged
Fix top ten ordering: replace LinkedHashMap with ConcurrentHashMap for thread safety#403
tastybento merged 2 commits into
developfrom 
copilot/fix-top-ten-order
Conversation
CopilotAI
commented
Mar 2, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Top ten leaderboard displays islands in wrong order — e.g., level 65 in 1st place, level 1065 in 6th. The sorting logic in calculateTopTen() is correct, but the underlying TopTenData.topTen map is a LinkedHashMap concurrently mutated from async threads (loadTopTens, setIslandResults) and read/modified from the main thread (getTopTen, createAndCleanRankings). This corrupts LinkedHashMap's internal doubly-linked list, producing incorrect iteration results that the downstream sort operates on. A server restart does not fix this — the same race re-occurs during async loadTopTens() repopulation.
Changes
  • TopTenData: LinkedHashMap → ConcurrentHashMap. Insertion order is irrelevant here since calculateTopTen() always sorts into a fresh LinkedHashMap.
  • LevelsManager.addToTopTen(): Invalidate the 1-second sorted cache via cache.remove(world) on level updates, matching the existing pattern in removeEntry().
  • LevelsManagerTest: Added testGetTopTenSortOrder() covering the reported scenario (mixed insertion order, verifies descending output).
Original prompt
This section details on the original issue you should resolve
<issue_title>Top Ten not showing right order</issue_title>

<issue_description>### Expected behavior
Team with higher levels should be higher in the top ten.
Observed/Actual behavior
Image
In this example, oofxjonthan's team made up of the members:
* Neetje2011
* offxjonathan
* debestepanda
* sliv0vitz
Is listed in 1st place with a level of 65.

However, TechM's team made up of:
  • TechM
  • EpicTechM
  • darkboy5
has a level of 1065 but is listed in 6th place.
Steps/models to reproduce
The adminfreported this as the current state on their server.
BentoBox version
Unknown right now, but assume latest.
Plugin list
No response
Other
The admin is asking how to get the top ten sorted correctly.</issue_description>
<agent_instructions>Focus on how this could occur as much as any potential fix. There may be a legitimate scenario where this could happen, but it doesn't look likely. If more information is needed from the admin, ask for it.</agent_instructions>
Comments on the Issue (you are @copilot in this section)
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.
@tastybento
Fix top ten ordering: use ConcurrentHashMap for thread safety and inv…
c5c6ef2
…alidate cache on update
Co-authored-by: tastybento <4407265+tastybento@users.noreply.github.com>
CopilotAI
changed the title
[WIP] Fix incorrect order in top ten standingsFix top ten ordering: use ConcurrentHashMap for thread-safe accessMar 2, 2026
CopilotAI
changed the title
Fix top ten ordering: use ConcurrentHashMap for thread-safe accessFix top ten ordering: replace LinkedHashMap with ConcurrentHashMap for thread safetyMar 2, 2026
@tastybento
tastybento
marked this pull request as ready for review
March 2, 2026 01:44
@tastybento
tastybento
merged commit 9c535c5
into
developMar 2, 2026

2 checks passed

@tastybento
tastybento
deleted the

copilot/fix-top-ten-order

branch
March 2, 2026 01:44
@sonarqubecloud
sonarqubecloudBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Quality Gate PassedQuality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
See analysis details on SonarQube Cloud
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees

@tastybentotastybento
Copilot code reviewCopilot

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Top Ten not showing right order


2 participants

@tastybento

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Fix top ten ordering: replace LinkedHashMap with ConcurrentHashMap for thread safety - #403
Merged
tastybento merged 2 commits into
developfrom 
copilot/fix-top-ten-order
Mar 2, 2026
Merged
Fix top ten ordering: replace LinkedHashMap with ConcurrentHashMap for thread safety#403
tastybento merged 2 commits into
developfrom 
copilot/fix-top-ten-order
Conversation
CopilotAI
commented
Mar 2, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Top ten leaderboard displays islands in wrong order — e.g., level 65 in 1st place, level 1065 in 6th. The sorting logic in calculateTopTen() is correct, but the underlying TopTenData.topTen map is a LinkedHashMap concurrently mutated from async threads (loadTopTens, setIslandResults) and read/modified from the main thread (getTopTen, createAndCleanRankings). This corrupts LinkedHashMap's internal doubly-linked list, producing incorrect iteration results that the downstream sort operates on. A server restart does not fix this — the same race re-occurs during async loadTopTens() repopulation.
Changes
  • TopTenData: LinkedHashMap → ConcurrentHashMap. Insertion order is irrelevant here since calculateTopTen() always sorts into a fresh LinkedHashMap.
  • LevelsManager.addToTopTen(): Invalidate the 1-second sorted cache via cache.remove(world) on level updates, matching the existing pattern in removeEntry().
  • LevelsManagerTest: Added testGetTopTenSortOrder() covering the reported scenario (mixed insertion order, verifies descending output).
Original prompt
This section details on the original issue you should resolve
<issue_title>Top Ten not showing right order</issue_title>

<issue_description>### Expected behavior
Team with higher levels should be higher in the top ten.
Observed/Actual behavior
Image
In this example, oofxjonthan's team made up of the members:
* Neetje2011
* offxjonathan
* debestepanda
* sliv0vitz
Is listed in 1st place with a level of 65.

However, TechM's team made up of:
  • TechM
  • EpicTechM
  • darkboy5
has a level of 1065 but is listed in 6th place.
Steps/models to reproduce
The adminfreported this as the current state on their server.
BentoBox version
Unknown right now, but assume latest.
Plugin list
No response
Other
The admin is asking how to get the top ten sorted correctly.</issue_description>
<agent_instructions>Focus on how this could occur as much as any potential fix. There may be a legitimate scenario where this could happen, but it doesn't look likely. If more information is needed from the admin, ask for it.</agent_instructions>
Comments on the Issue (you are @copilot in this section)
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.
@tastybento
Fix top ten ordering: use ConcurrentHashMap for thread safety and inv…
c5c6ef2
…alidate cache on update
Co-authored-by: tastybento <4407265+tastybento@users.noreply.github.com>
CopilotAI
changed the title
[WIP] Fix incorrect order in top ten standingsFix top ten ordering: use ConcurrentHashMap for thread-safe accessMar 2, 2026
CopilotAI
changed the title
Fix top ten ordering: use ConcurrentHashMap for thread-safe accessFix top ten ordering: replace LinkedHashMap with ConcurrentHashMap for thread safetyMar 2, 2026
@tastybento
tastybento
marked this pull request as ready for review
March 2, 2026 01:44
@tastybento
tastybento
merged commit 9c535c5
into
developMar 2, 2026

2 checks passed

@tastybento
tastybento
deleted the

copilot/fix-top-ten-order

branch
March 2, 2026 01:44
@sonarqubecloud
sonarqubecloudBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Quality Gate PassedQuality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
See analysis details on SonarQube Cloud
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees

@tastybentotastybento
Copilot code reviewCopilot

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Top Ten not showing right order


2 participants

@tastybento

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Fix top ten ordering: replace LinkedHashMap with ConcurrentHashMap for thread safety - #403
Merged
tastybento merged 2 commits into
developfrom 
copilot/fix-top-ten-order
Mar 2, 2026
Merged
Fix top ten ordering: replace LinkedHashMap with ConcurrentHashMap for thread safety#403
tastybento merged 2 commits into
developfrom 
copilot/fix-top-ten-order
Conversation
CopilotAI
commented
Mar 2, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Top ten leaderboard displays islands in wrong order — e.g., level 65 in 1st place, level 1065 in 6th. The sorting logic in calculateTopTen() is correct, but the underlying TopTenData.topTen map is a LinkedHashMap concurrently mutated from async threads (loadTopTens, setIslandResults) and read/modified from the main thread (getTopTen, createAndCleanRankings). This corrupts LinkedHashMap's internal doubly-linked list, producing incorrect iteration results that the downstream sort operates on. A server restart does not fix this — the same race re-occurs during async loadTopTens() repopulation.
Changes
  • TopTenData: LinkedHashMap → ConcurrentHashMap. Insertion order is irrelevant here since calculateTopTen() always sorts into a fresh LinkedHashMap.
  • LevelsManager.addToTopTen(): Invalidate the 1-second sorted cache via cache.remove(world) on level updates, matching the existing pattern in removeEntry().
  • LevelsManagerTest: Added testGetTopTenSortOrder() covering the reported scenario (mixed insertion order, verifies descending output).
Original prompt
This section details on the original issue you should resolve
<issue_title>Top Ten not showing right order</issue_title>

<issue_description>### Expected behavior
Team with higher levels should be higher in the top ten.
Observed/Actual behavior
Image
In this example, oofxjonthan's team made up of the members:
* Neetje2011
* offxjonathan
* debestepanda
* sliv0vitz
Is listed in 1st place with a level of 65.

However, TechM's team made up of:
  • TechM
  • EpicTechM
  • darkboy5
has a level of 1065 but is listed in 6th place.
Steps/models to reproduce
The adminfreported this as the current state on their server.
BentoBox version
Unknown right now, but assume latest.
Plugin list
No response
Other
The admin is asking how to get the top ten sorted correctly.</issue_description>
<agent_instructions>Focus on how this could occur as much as any potential fix. There may be a legitimate scenario where this could happen, but it doesn't look likely. If more information is needed from the admin, ask for it.</agent_instructions>
Comments on the Issue (you are @copilot in this section)
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.
@tastybento
Fix top ten ordering: use ConcurrentHashMap for thread safety and inv…
c5c6ef2
…alidate cache on update
Co-authored-by: tastybento <4407265+tastybento@users.noreply.github.com>
CopilotAI
changed the title
[WIP] Fix incorrect order in top ten standingsFix top ten ordering: use ConcurrentHashMap for thread-safe accessMar 2, 2026
CopilotAI
changed the title
Fix top ten ordering: use ConcurrentHashMap for thread-safe accessFix top ten ordering: replace LinkedHashMap with ConcurrentHashMap for thread safetyMar 2, 2026
@tastybento
tastybento
marked this pull request as ready for review
March 2, 2026 01:44
@tastybento
tastybento
merged commit 9c535c5
into
developMar 2, 2026

2 checks passed

@tastybento
tastybento
deleted the

copilot/fix-top-ten-order

branch
March 2, 2026 01:44
@sonarqubecloud
sonarqubecloudBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Quality Gate PassedQuality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
See analysis details on SonarQube Cloud
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees

@tastybentotastybento
Copilot code reviewCopilot

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Top Ten not showing right order


2 participants

@tastybento

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Fix top ten ordering: replace LinkedHashMap with ConcurrentHashMap for thread safety - #403
Merged
tastybento merged 2 commits into
developfrom 
copilot/fix-top-ten-order
Mar 2, 2026
Merged
Fix top ten ordering: replace LinkedHashMap with ConcurrentHashMap for thread safety#403
tastybento merged 2 commits into
developfrom 
copilot/fix-top-ten-order
Conversation
CopilotAI
commented
Mar 2, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Top ten leaderboard displays islands in wrong order — e.g., level 65 in 1st place, level 1065 in 6th. The sorting logic in calculateTopTen() is correct, but the underlying TopTenData.topTen map is a LinkedHashMap concurrently mutated from async threads (loadTopTens, setIslandResults) and read/modified from the main thread (getTopTen, createAndCleanRankings). This corrupts LinkedHashMap's internal doubly-linked list, producing incorrect iteration results that the downstream sort operates on. A server restart does not fix this — the same race re-occurs during async loadTopTens() repopulation.
Changes
  • TopTenData: LinkedHashMap → ConcurrentHashMap. Insertion order is irrelevant here since calculateTopTen() always sorts into a fresh LinkedHashMap.
  • LevelsManager.addToTopTen(): Invalidate the 1-second sorted cache via cache.remove(world) on level updates, matching the existing pattern in removeEntry().
  • LevelsManagerTest: Added testGetTopTenSortOrder() covering the reported scenario (mixed insertion order, verifies descending output).
Original prompt
This section details on the original issue you should resolve
<issue_title>Top Ten not showing right order</issue_title>

<issue_description>### Expected behavior
Team with higher levels should be higher in the top ten.
Observed/Actual behavior
Image
In this example, oofxjonthan's team made up of the members:
* Neetje2011
* offxjonathan
* debestepanda
* sliv0vitz
Is listed in 1st place with a level of 65.

However, TechM's team made up of:
  • TechM
  • EpicTechM
  • darkboy5
has a level of 1065 but is listed in 6th place.
Steps/models to reproduce
The adminfreported this as the current state on their server.
BentoBox version
Unknown right now, but assume latest.
Plugin list
No response
Other
The admin is asking how to get the top ten sorted correctly.</issue_description>
<agent_instructions>Focus on how this could occur as much as any potential fix. There may be a legitimate scenario where this could happen, but it doesn't look likely. If more information is needed from the admin, ask for it.</agent_instructions>
Comments on the Issue (you are @copilot in this section)
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.
@tastybento
Fix top ten ordering: use ConcurrentHashMap for thread safety and inv…
c5c6ef2
…alidate cache on update
Co-authored-by: tastybento <4407265+tastybento@users.noreply.github.com>
CopilotAI
changed the title
[WIP] Fix incorrect order in top ten standingsFix top ten ordering: use ConcurrentHashMap for thread-safe accessMar 2, 2026
CopilotAI
changed the title
Fix top ten ordering: use ConcurrentHashMap for thread-safe accessFix top ten ordering: replace LinkedHashMap with ConcurrentHashMap for thread safetyMar 2, 2026
@tastybento
tastybento
marked this pull request as ready for review
March 2, 2026 01:44
@tastybento
tastybento
merged commit 9c535c5
into
developMar 2, 2026

2 checks passed

@tastybento
tastybento
deleted the

copilot/fix-top-ten-order

branch
March 2, 2026 01:44
@sonarqubecloud
sonarqubecloudBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Quality Gate PassedQuality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
See analysis details on SonarQube Cloud
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees

@tastybentotastybento
Copilot code reviewCopilot

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Top Ten not showing right order


2 participants

@tastybento