Uh oh!
There was an error while loading. Please reload this page.
FIXED: Negative values in progression while using a non-linear function. - #423
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes incorrect (sometimes negative) “progress to next level” values shown to players when level-calc uses a non-linear formula (e.g., sqrt, log) by computing progress based on the actual current-level interval rather than the configured level_cost.
Changes:
- Derive and store “points accumulated within the current level” (
pointsFromCurrentLevel) in calculation results. - Update
/is leveloutput to display progress using the derived per-level interval for non-linear formulas. - Add a backward scan in
IslandLevelCalculator.tidyUp()to find the start threshold of the current level.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/main/java/world/bentobox/level/commands/IslandLevelCommand.java | Switches progress display to use derived current-level progress/interval for non-linear formulas. |
src/main/java/world/bentobox/level/calculators/Results.java | Adds storage + accessor methods for “points from current level”. |
src/main/java/world/bentobox/level/calculators/IslandLevelCalculator.java | Computes pointsFromCurrentLevel by walking back to the current-level boundary. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+126
to
+130
| /** | ||
| * @return the points already accumulated within the current level | ||
| */ | ||
| public long getPointsFromCurrentLevel() { | ||
| return pointsFromCurrentLevel.get(); |
Comment on lines
+770
to
+774
| long minBlocks = addon.getSettings().isZeroNewIslandLevels() ? results.initialCount.get() : 0; | ||
| long lowerBlocks = blockAndDeathPoints; | ||
| while (lowerBlocks > minBlocks && blockAndDeathPoints - lowerBlocks < MAX_AMOUNT | ||
| && calculateLevel(lowerBlocks - 1) >= currentLevel) { | ||
| lowerBlocks--; |
Uh oh!
There was an error while loading. Please reload this page.
tastybento
commented
May 8, 2026
Member
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Example
If the
level-calcwas set to a linear function:The level progression calculation would work as intended.
However, if the
level-calcwas set to a non-linear function:It would produce results such as Level 3, 62/100 points. Then Level 5, -60/100 points. See Figure 1
This example occurred during testing when two diamond blocks were placed without any other blocks being removed. (Diamond blocks where placed on the side to prevent grass turning into dirt, thus preventing island level from dropping from that).
Screenshots
Figure 1.
