Skip to content

Work around ifx automatic-offloading bugs - #145

Merged
ktras merged 2 commits into
mainfrom
ifx-workaround
May 8, 2024
Merged

Work around ifx automatic-offloading bugs#145
ktras merged 2 commits into
mainfrom
ifx-workaround

Conversation

@rouson

@rousonrouson commented Apr 16, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

This PR works around issues that arise when the following build command is used to tell the ifx compiler to automatically offload do concurrent constructs to a GPU:

fpm test --compiler ifx --flag "-coarray -coarray-num-images=1 -fopenmp-target-do-concurrent -qopenmp -fopenmp-targets=spir64"

The workarounds are

  1. further reduce iterations in trainable_engine_test_m so training converges with ifx without crashing
  2. convert do concurrent with array statements to do loops

@rouson
rouson requested a review from ktrasApril 16, 2024 23:16
@rousonrouson changed the title test(trainable_engine): reduce iterations with ifxWork around ifx automatic-offloading bugsApr 16, 2024
@rouson
rouson marked this pull request as draft April 16, 2024 23:25
@ktras
ktras marked this pull request as ready for review May 8, 2024 17:19
ktras
ktras approved these changes May 8, 2024
View reviewed changes

@ktrasktras left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for fixing working around one ifx bug.

@ktras
ktras merged commit 990e211 into mainMay 8, 2024
@ktras
ktras deleted the ifx-workaround branch May 8, 2024 17:20
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ktrasktrasktras approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rouson@ktras