Uh oh!
There was an error while loading. Please reload this page.
Feature: Faster histogram construction when the number of bins exceeds 80 - #162
Merged
Conversation
This commit switches the `cloud-microphysics` `histogram_t` constructor to using a different algorithm when the number of bins reaches a threshold of 80, at which value the new algorithm outperforms the original algorithm. The original algorithm used `do concurrent`, but required accessing the entire data once per bin. The new algorithm is inherently serial, but only accesses the data set once, keeping a running tally of the bin count.
davytorres
approved these changes
Jun 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request switches the
cloud-microphysicshistogram_tconstructor to using a different algorithm when the number of bins exceeds a threshold of 80, above which the new algorithm out-performs the original algorithm. The original algorithm useddo concurrent, but required accessing the entire data once per bin. The new algorithm is inherently serial, but only accesses the data set once, keeping a running tally of the bin count. In a future commit, the new algorithm will also usedo concurrentwith compilers that support Fortran 2023reducelocality.