Uh oh!
There was an error while loading. Please reload this page.
Conversation
The program cloud-microphysics/app/train-cloud-microphysics.f90 has makes three subroutine calls, two of which have now been tested in parallel: 1. get_command_line_arguments: multi-image execution works 2. create_or_append_plot_file: now happens only on image 1 3. read_train_write: (to do)
This commit fixes the `do concurrent` blocks in the training subroutine so that the iterations can execute concurrently: 1. Add locality specifiers for compilers that support them. 2. Otherwise, define blocks with local variables/allocations for each loop iteration and perform necessary explicit sums. Co-authored-by: Dan Bonachea <dobonachea@lbl.gov>
rouson
marked this pull request as ready for review
September 13, 2024 17:10
bonachea
requested changes
Sep 13, 2024
Uh oh!
There was an error while loading. Please reload this page.
bonachea
requested changes
Sep 13, 2024
bonachea
left a comment
Member
There was a problem hiding this comment.
Probably also need to update the status of do concurrent support and usage in the top-level README
rouson
commented
Sep 14, 2024
ContributorAuthor
@bonachea I think all the changes we've discussed have been made so I'll merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.