Skip to content

Fixes for building with ifx - #237

Merged
rouson merged 4 commits into
BerkeleyLab:mainfrom
aury6623:ifx-fixes
Feb 5, 2025
Merged

Fixes for building with ifx#237
rouson merged 4 commits into
BerkeleyLab:mainfrom
aury6623:ifx-fixes

Conversation

@aury6623

Copy link
Copy Markdown
Contributor

The 0.15.0 build does not currently work with ifx due to a few compiler bugs. These bugs will hopefully be fixed in an upcoming 2025 release of ifx. However, Fiats also has a few bugs that prevent compilation on ifx, which this PR addresses. See the commit messages for each individual commit for more details.

- Compile with fpp
Some files have preprocessor directives but use the 'f90' (instead of
'F90') file extension so fpp doesn't run for them. Plus, using 'F90' can
cause problems on Windows because it's case insensitive.
- Remove -O3, fpm already adds -O3 when using --profile release
- Reorder to make consistent with nagfor command line
The use of ALL is invalid because it requires an array argument and
these argumens are scalar. It looks like this ifx code is supposed to do
the same thing as the non-ifx code but without DO CONCURRENT. I'm not
sure why. But the ifx code is wrong so it either needs to be fixed or
removed. This commit goes with the remove option.

@rousonrouson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rouson
rouson merged commit d69b826 into BerkeleyLab:mainFeb 5, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@aury6623@rouson