Uh oh!
There was an error while loading. Please reload this page.
New and refactored constructors - #247
Merged
Merged
Conversation
This commit
1. Switches the training_data_file_t constructor
default_real_from_json to accepting a file_t argument instead
of a string_t array of lines.
2. Adjusts the demo/app/{tensor_staticis,train_cloud_microphysics}
to use the new training_data_files_t type.
3. Adds and a new trainable_network_t constructor that accepts a
file_t argument and usese the new constructor to simplify
constructor invocations.This commit fixes training_data_files_test_m by changing the supporting code: the training_data_files_t's type-bound to_json function now produces a file_t result from its string_t lines array.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
training_data_file_tconstructordefault_real_from_jsonto accepting afile_targument instead of astring_tarray of lines.training_data_files_ttype.trainable_network_tconstructor that accepts afile_targument and uses the new constructor to simplify constructor invocations.training_data_files_test_mby changing the supporting code: thetraining_data_files_t's type-boundto_jsonfunction now produces afile_tresult from itsstring_tarray of lines.