Skip to content

Add CONTRIBUTING.md first draft - #274

Merged
ktras merged 9 commits into
BerkeleyLab:mainfrom
ktras:add-contributing-doc
Aug 29, 2025
Merged

Add CONTRIBUTING.md first draft#274
ktras merged 9 commits into
BerkeleyLab:mainfrom
ktras:add-contributing-doc

Conversation

@ktras

@ktrasktras commented Aug 29, 2025

Copy link
Copy Markdown
Collaborator

No description provided.

bonachea
bonachea requested changes Aug 29, 2025
View reviewed changes

@bonacheabonachea left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many changes requested

Comment threadCONTRIBUTING.MD
Comment threadCONTRIBUTING.MD Outdated
Comment threadCONTRIBUTING.MD Outdated
Comment threadCONTRIBUTING.MD Outdated
Comment threadCONTRIBUTING.MD Outdated
Comment threadCONTRIBUTING.MD Outdated
Comment threadCONTRIBUTING.MD Outdated
@bonacheabonachea linked an issue Aug 29, 2025 that may be closed by this pull request
[JOSS review]: Community guidelines #272
Closed
@ktras
ktras requested a review from bonacheaAugust 29, 2025 21:40
bonachea
bonachea reviewed Aug 29, 2025
View reviewed changes
Comment threadCONTRIBUTING.md
bonachea
bonachea requested changes Aug 29, 2025
View reviewed changes

@bonacheabonachea left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made one additional suggestion, otherwise LGTM

ktrasand others added 9 commits August 29, 2025 17:51
@ktras@bonachea
Add CONTRIBUTING.md first draft
61c792a
@ktras@bonachea
Update CONTRIBUTING.MD
b2da2d1
Co-authored-by: Dan Bonachea <dobonachea@lbl.gov>
@ktras@bonachea
Update CONTRIBUTING.MD
0340683
Co-authored-by: Dan Bonachea <dobonachea@lbl.gov>
@ktras@bonachea
Update CONTRIBUTING.MD
502fa50
Co-authored-by: Dan Bonachea <dobonachea@lbl.gov>
@ktras@bonachea
Update CONTRIBUTING.MD
0827efa
Co-authored-by: Dan Bonachea <dobonachea@lbl.gov>
@ktras@bonachea
Fix ORCID image url
17286d2
@ktras@bonachea
Update CONTRIBUTING.md issue instructions
21b60e0
@ktras@bonachea
Fix file extension for CONTRIBUTING.md
8fbe2cf
@ktras@bonachea
Update contributors list in CONTRIBUTING.md
439af53
@bonachea
bonacheaforce-pushed the add-contributing-doc branch from 8de3644 to 439af53CompareAugust 29, 2025 21:51
rouson
rouson approved these changes Aug 29, 2025
View reviewed changes

@rousonrouson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ktras
ktras commented Aug 29, 2025
View reviewed changes
Comment threadCONTRIBUTING.MD
Comment threadCONTRIBUTING.MD Outdated
Comment threadCONTRIBUTING.MD Outdated
Comment threadCONTRIBUTING.MD
Comment threadCONTRIBUTING.md
@ktras
ktras merged commit 1ae88f1 into BerkeleyLab:mainAug 29, 2025
2 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bonacheabonacheabonachea approved these changes
@rousonrousonrouson approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[JOSS review]: Community guidelines

3 participants

@ktras@bonachea@rouson