Uh oh!
There was an error while loading. Please reload this page.
Improved assertions: update demo to Julienne 3.2.1 assertions - #278
Merged
Conversation
This commit replaces all occurrences of the `call_assert` and `call_assert_diagnose` macros with either the `call_julienne_assert` macro or the `call julienne_assert` subroutine invocation. Doing so allows for rich, automatically constructed diagnostic information provided by Julienne idioms. Where desirable, using calling the directly facilitates insertion of custom diagnostic information.
This commit finishes updating the assertions in the src, example, demo, and test subdirectories using Julienne 3.2.1 idioms.
rouson
marked this pull request as ready for review
October 20, 2025 02:04
This commit removes the last of the solo uses of _CRAYFTN in Fiats. The only remaining uses are in the example subdirectory, where some programs contain `#ifdef _CRAYFTN || _GFORTRAN_`.
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces all occurrences of the Assert macros
call_assertandcall_assert_diagnosewith either the Juliennecall_julienne_assertmacro or thecall julienne_assertsubroutine invocation. Doing so allows the automatic construction of diagnostic information via Julienne idioms. In many cases, the direct subroutine invocation is chosen over the macro to allow for insertion of custom diagnostic information. This commit also removes many custom diagnostic strings that simply provided the submodule and procedure names, which effectively redundant because Julienne/Assert assertions automatically insert the file name and line number.Subdirectories converted:
demosrctestexample