Skip to content

fix: add classifier offset pagination#101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BigSimmo merged 1 commit into from
Jun 29, 2026
Merged

fix: add classifier offset pagination #101

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 36 additions & 3 deletions scripts/classify-documents.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,8 +12,10 @@ type ClassifyArgs = {
ownerId?: string;
documentId?: string;
limit: number;
offset: number;
write: boolean;
confirm: boolean;
help: boolean;
};

type SupabaseAdmin = Awaited<ReturnType<typeof loadAdminClient>>;
Expand All@@ -37,8 +39,10 @@ function parseArgs(argv: string[]): ClassifyArgs {
allOwners: false,
ownerId: process.env.RAG_EVAL_OWNER_ID ?? process.env.LOCAL_NO_AUTH_OWNER_ID,
limit: 100,
offset: 0,
write: false,
confirm: false,
help: false,
};

for (let index = 0; index < argv.length; index += 1) {
Expand All@@ -55,23 +59,48 @@ function parseArgs(argv: string[]): ClassifyArgs {
args.confirm = true;
continue;
}
if (token === "--help" || token === "-h") {
args.help = true;
continue;
}

const value = argv[index + 1];
if (!value || value.startsWith("--")) throw new Error(`Missing value for ${token}`);
index += 1;
if (token === "--owner-id") args.ownerId = value;
if (token === "--document-id") args.documentId = value;
if (token === "--limit") args.limit = Number.parseInt(value, 10);
else if (token === "--document-id") args.documentId = value;
else if (token === "--limit") args.limit = Number(value);
else if (token === "--offset") args.offset = Number(value);
else throw new Error(`Unknown option: ${token}`);
}

if (args.help) return args;
if (!Number.isInteger(args.limit) || args.limit <= 0) throw new Error("--limit must be a positive integer.");
if (!Number.isInteger(args.offset) || args.offset < 0) throw new Error("--offset must be a non-negative integer.");
if (!args.allOwners && !args.ownerId && !args.documentId) {
throw new Error("Pass --owner-id, --document-id, or --all-owners. Dry-run is still the default.");
}
if (args.write && !args.confirm) throw new Error("Writing requires --write --confirm after reviewing a dry-run.");
return args;
}

function usage() {
return [
"Usage: npm run classify:documents -- [scope] [options]",
"",
"Scopes:",
" --owner-id <uuid> Classify indexed documents for one owner.",
" --document-id <uuid> Classify one indexed document.",
" --all-owners Classify across all owners.",
"",
"Options:",
" --limit <count> Batch size for scoped runs. Default: 100.",
" --offset <count> Skip this many indexed documents before the batch. Default: 0.",
" --write --confirm Persist reviewed classifications. Dry-run is the default.",
" --help, -h Show this help.",
].join("\n");
}

function metadataRecord(value: unknown) {
return value && typeof value === "object" && !Array.isArray(value) ? { ...(value as Record<string, unknown>) } : {};
}
Expand All@@ -82,7 +111,7 @@ async function loadDocuments(supabase: SupabaseAdmin, args: ClassifyArgs) {
.select("id,owner_id,title,file_name,source_path,status,metadata")
.eq("status", "indexed")
.order("created_at", { ascending: true })
.limit(args.documentId ? 1 : args.limit);
.range(args.documentId ? 0 : args.offset, args.documentId ? 0 : args.offset + args.limit - 1);
Comment on lines 113 to +114

@chatgpt-codex-connectorchatgpt-codex-connectorBotJun 29, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Add a stable tie-breaker before offset paging

When --offset is used across batches, ordering only by created_at is not deterministic for indexed documents that share the same timestamp, which can happen with bulk imports using the created_at default now() column. Postgres is free to return tied rows in different orders between invocations, so --limit 100 --offset 100 can skip or reprocess documents. Add a unique secondary order, such as id, before applying .range(...) so paginated classifier runs walk a stable sequence.

Useful? React with 👍 / 👎.


if (args.documentId) query = query.eq("id", args.documentId);
if (!args.allOwners && args.ownerId) query = query.eq("owner_id", args.ownerId);
Expand DownExpand Up@@ -219,6 +248,10 @@ function printPlan(

async function main() {
const args = parseArgs(process.argv.slice(2));
if (args.help) {
console.log(usage());
return;
}
const supabase = await loadAdminClient();
const documents = await loadDocuments(supabase, args);
const plans = [];
Expand Down