- Notifications
You must be signed in to change notification settings - Fork 0
fix: deployment boot smoke fails with 500 due to missing production env vars#110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Uh oh!
There was an error while loading. Please reload this page.
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
cb8153a
Refine answer formatting and search flow
BigSimmo 67949de
Harden document label coverage and UI cleanup
BigSimmo 0eb2fbd
refactor: component extraction polish and luxury black-first color re…
BigSimmo cf4fa67
Merge branch 'main' into codex/RAG_FIX
BigSimmo c5696a4
fix: add GITHUB_TOKEN to gitleaks-action for PR scanning
Copilot 4ad7885
fix: pass placeholder creds to smoke server and fix log cleanup ordering
Copilot 8e242ca
test: align UI smoke expectations with current app modes and upload/p…
Copilot fcf686e
chore: retrigger ci after bot test update
BigSimmo 8642ee7
test: relax mobile settings fullscreen tolerance
BigSimmo 2993c37
fix: address PR review feedback
BigSimmo 7c0a2fb
Fix flaky fullscreen width assertion in mobile settings UI smoke test
Copilot 1e653d3
Fix flaky mobile settings viewport assertion
Copilot dbeae81
Stabilize mobile settings fullscreen UI assertion
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+136 KB
.codex-screenshots/settings-complete-frontend-design-pass/desktop-1440-guide.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+138 KB
...ex-screenshots/settings-complete-frontend-design-pass/desktop-1440-settings.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+38.4 KB
.codex-screenshots/settings-complete-frontend-design-pass/phone-320-settings.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+46.6 KB
.codex-screenshots/settings-complete-frontend-design-pass/phone-390-guide.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+39.9 KB
.codex-screenshots/settings-complete-frontend-design-pass/phone-390-settings.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,123 @@ | ||
| # Luxury Black-First Color Redesign Plan (Global UI Polish) | ||
| ## 1) Intent | ||
| Apply a refined, premium dark-first visual system across the app with minimal risk: | ||
| - Keep semantics and component behavior unchanged. | ||
| - Keep token architecture centralized in CSS variables. | ||
| - Preserve accessibility and clinical readability. | ||
| - Ensure light mode remains available but visually secondary. | ||
| ## 2) Boundaries and Constraints | ||
| - No functional/logic edits. | ||
| - No route/path rewrites, no new UI behavior. | ||
| - No dependency/toolchain changes. | ||
| - Primary work only in style tokens and tokenized usage in key components. | ||
| - All work is reversible and should be diff-reviewable in 3 small stages. | ||
| ## 3) Success Definition (Done Criteria) | ||
| - Global theme reads as `obsidian/charcoal/luxury` (dark-first) while keeping high contrast. | ||
| - `--surface`, `--text`, `--primary`, `--border`, focus and state tokens are consistently used. | ||
| - Hard-coded production color usage reduced to near-zero in high-impact files. | ||
| - No visual behavior regressions observed on target screens (search, dashboard, viewer, modal/sheet). | ||
| - Diff is split by stage for easy rollback. | ||
| ## 4) Stage Overview | ||
| ### Stage 1 — Token Refresh + Theme Metadata (No behavior change) | ||
| **Goal:** finalize token system to luxury black-first in one controlled sweep. | ||
| #### Files | ||
| - `C:\Dev\Apps\Database\src\app\globals.css` | ||
| - `C:\Dev\Apps\Database\src\app\layout.tsx` | ||
| - `C:\Dev\Apps\Database\src\lib\theme.ts` | ||
| #### Edit checklist | ||
| 1. In `globals.css`, set foundation tokens for dark-first aesthetic: | ||
| - Neutral ramps (`--background`, `--surface*`, `--text*`, `--border*`, `--ring*`, `--shadow*`, `--overlay-backdrop`, `--panel-gloss`) | ||
| - Primary/accent tokens (reduced-brightness, high contrast on dark) | ||
| - Semantic status tokens (`--info`, `--success`, `--warning`, `--danger`) and clinical-specific tokens | ||
| 2. Ensure `.dark` token map remains consistent and richer than `:root` light map. | ||
| 3. Update `@theme` bridges if needed so utility mappings stay clean and exhaustive. | ||
| 4. In `layout.tsx`, revise theme metadata/colors to match palette intent. | ||
| 5. In `theme.ts`, keep server snapshot/default aligned with dark-first philosophy. | ||
| #### Exit checks | ||
| - `rg -n "(background|surface|text|border|primary|ring|shadow|overlay|panel-gloss)" src\app\globals.css` | ||
| - Confirm no token names were removed/renamed (only value changes). | ||
| --- | ||
| ### Stage 2 — Token Migration of Production Color Exceptions | ||
| **Goal:** remove hardcoded/non-token surface/color usage from high-impact components. | ||
| #### Files | ||
| - `C:\Dev\Apps\Database\src\components\ui\sheet.tsx` | ||
| - `C:\Dev\Apps\Database\src\components\ui-primitives.tsx` | ||
| - `C:\Dev\Apps\Database\src\components\DocumentViewer.tsx` | ||
| - `C:\Dev\Apps\Database\src\components\ClinicalDashboard.tsx` | ||
| - `C:\Dev\Apps\Database\src\components\clinical-dashboard\medication-prescribing-workspace.tsx` | ||
| #### Edit checklist | ||
| 1. Replace `bg-white`, `text-white`, `border-white`, direct slate utilities and hex fills with token-backed references. | ||
| 2. Replace hardcoded status badges with semantic variants (`toneDanger`, `toneInfo`, `toneSuccess`, etc.) where available. | ||
| 3. Keep spacing/layout/logic unchanged. | ||
| 4. Confirm sheet, modal, viewer, dashboard, and medication workspace now visually map to token surfaces. | ||
| #### Exit checks | ||
| - Token-first grep in target files: | ||
| - `rg -n "bg-white|text-white|border-white|bg-slate|text-slate|border-slate|#([0-9a-fA-F]{3,8})" src\components\ui\sheet.tsx src\components\ui-primitives.tsx src\components\DocumentViewer.tsx src\components\ClinicalDashboard.tsx src\components\clinical-dashboard\medication-prescribing-workspace.tsx` | ||
| - No behavior edits committed. | ||
| --- | ||
| ### Stage 3 — Depth & Polish + QA Validation | ||
| **Goal:** finalize tactile depth and verify polished output across themes. | ||
| #### Files (primarily) | ||
| - `C:\Dev\Apps\Database\src\app\globals.css` | ||
| - Any residual files flagged in Stage 2 follow-up | ||
| #### Edit checklist | ||
| 1. Fine-tune overlay/gloss/shadow stack: | ||
| - reduce harsh white borders | ||
| - convert glow to low-sheen, alpha-safe ink reflections | ||
| - keep focus ring high contrast and unmistakable | ||
| 2. Normalize any remaining direct color-mix / white-overlay hacks to token values. | ||
| 3. Run final style consistency sweep for production files. | ||
| #### Exit checks | ||
| - Manual visual QA after server boot: | ||
| - `npm run ensure` | ||
| - Browse sample flows: search, dashboard, document viewer, sheet/modal, medication prescribing workspace. | ||
| - Contrast check on dark mode primary surfaces: | ||
| - body text, headings, disabled, links/buttons, focus, and success/info/warning/danger states. | ||
| --- | ||
| ## 5) Suggested Execution Order (Pragmatic) | ||
| 1. Stage 1 tokens + metadata | ||
| 2. Stage 2 component hardcode replacement | ||
| 3. Stage 3 polish + QA | ||
| This keeps risk low and allows rollback at each stage. | ||
| ## 6) Rollback Strategy | ||
| - Stage-specific commits (or checkpoints): Stage1 / Stage2 / Stage3. | ||
| - If any stage causes visual regression, revert only that stage’s files first. | ||
| - Preserve `git status` checkpoints between stages. | ||
| ## 7) Risk Register | ||
| - **Contrast drift (high):** especially in dense clinical content -> verify muted text/disabled states. | ||
| - **Component inconsistency risk:** token-mapped components that rely on literal colors for hierarchy -> preserve local contrast hierarchy via token swaps only. | ||
| - **Theme metadata mismatch:** server/client defaults mismatch -> validate first paint and browser local toggle. | ||
| ## 8) Done Checklist (single source of truth) | ||
| - [ ] Stage 1 complete (tokens + metadata) | ||
| - [ ] Stage 2 complete (component token migration) | ||
| - [ ] Stage 3 complete (polish + QA) | ||
| - [ ] Final review with screenshot evidence of main routes in dark mode | ||
| ## 9) Current status (from this session) | ||
| - Stage 1 is partially started in `globals.css`. | ||
| - `layout.tsx` and `theme.ts` still need completion before Stage 1 is final. | ||
| - No files outside the plan scope should be edited until this document is approved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Oops, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.