Skip to content

feat(ui): codebase review improvements and design system ratcheting - #1286

Merged
BigSimmo merged 19 commits into
mainfrom
fix-test-run-lock
Jul 28, 2026
Merged

feat(ui): codebase review improvements and design system ratcheting#1286
BigSimmo merged 19 commits into
mainfrom
fix-test-run-lock

Conversation

@BigSimmo

Copy link
Copy Markdown
Owner

Summary

  • Ratcheted design system literal shadow baseline to 0 (literalShadowClasses: 0).
  • Added accessible UI primitives (button.tsx, input.tsx) in src/components/ui/.
  • Enhanced forced-colors:border support for Windows High Contrast mode in ui-primitives.tsx.
  • All automated gates passed (verify:cheap, typecheck, test, contract checks).

RAG impact: no retrieval behaviour change -- codebase review and design system ratcheting.

BigSimmoand others added 7 commits July 25, 2026 22:31
Append merge-readiness and prlanded outcome for remediate-repository-audit-findings @ 8637fec: DO NOT MERGE, not landed, CONFLICTING vs main.
Capture the 2026-07-26 close decisions and merge-ready keep list after
re-triaging the Antigravity/Cursor queue.
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@supabase

supabaseBot commented Jul 27, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@coderabbitai

coderabbitaiBot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

@cursor[bot], you've reached your PR review limit, so we couldn't start this review.

Next review available in:9 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: ec7cb3e0-755f-45a1-858f-f70fc5c1b894

📥 Commits

Reviewing files that changed from the base of the PR and between ec04f17 and 091b433.

📒 Files selected for processing (5)
  • docs/branch-review-ledger.md
  • scripts/design-system-contract-baseline.json
  • src/components/differentials/diagnosis-map-panel.tsx
  • src/components/ui-primitives.tsx
  • tests/ui-smoke.spec.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-test-run-lock

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@BigSimmo

Copy link
Copy Markdown
OwnerAuthor

@cursoragent please review for the merge conflicts and fix these. Please also run bugbot looking for any issues. Please resolve any comments and failing CI checks also.

@cursor

cursorBot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

PR #1286 is mergeable and CI-green again.

Merge conflicts

Was CONFLICTING vs main. Resolved by keeping main’s soft-glass phone chrome, shared test-run-lock coordinator, tokenized document-nav mockups, and accessible-name Playwright contract. Kept this PR’s unique deltas:

  • forced-colors:border on control/field primitives
  • literalShadowClasses: 0 + diagnosis-map shadow token
  • ledger updates

Also synced through later main advances (#1293, #1290, #1289) and cleared union-merge ledger duplicate rows that broke Static PR.

Bugbot

No remaining P0–P2 on the unique product delta. Earlier P1s (phone CSS regression, lock coordinator rewrite, truncated phone-scroll suite, fragile mockup toHaveText) were avoided by keeping main’s versions.

Comments / CI

  • No unresolved review threads (Codex/CodeRabbit were rate-limited; nothing actionable).
  • Fixed Production UI flake: favourites-hub hydration duplicate → expectSingleSettledOwner.
  • Current tip 091b433c: PR required, Production UI, Static PR, Unit, Build, Safety all pass; mergeable_state: clean.

Ready for your merge when you want.

Open in WebOpen in Cursor

Keep main's soft-glass phone chrome, shared test-run-lock coordinator,
tokenized document-nav mockups, and accessible-name Playwright contract.
Preserve this PR's forced-colors:border control/field styles, design-system
literal-shadow ratchet, and knip tailwindcss ignore.
Remove nine exact duplicate branch-review-ledger rows created by the
union merge with main, which failed Static PR checks. Append the
conflict-repair and Bugbot outcome for fix-test-run-lock.
Append the superseding ledger row for bef2377 after the duplicate-row
cleanup so Static PR and review throttle see the current tip.
Append the approve row for tip b9ac162 after hosted PR required and
Production UI passed post merge-conflict repair.
Append a superseding ledger row after shell backtick expansion dropped
the fix-test-run-lock branch cell from the prior closeout entry.
@github-actions

Copy link
Copy Markdown
Contributor

CI triage

CI failed on this PR. Automated classification of the 2 failed job(s):

  • Production UIneeds investigation: inspect the failing step and uploaded diagnostics; rerun only after classifying the cause.
  • PR requiredneeds investigation: inspect the failing step and uploaded diagnostics; rerun only after classifying the cause.

Compared with main CI run #6020 (success).

Classification is evidence routing, not permission to ignore a failure. Exact quarantined Playwright identities remain governed by the flake ledger.

Production hydration can briefly overlap server and client favourites
trees, so getByTestId('favourites-hub') resolves to two mains and trips
Playwright strict mode. Reuse expectSingleSettledOwner before hub
assertions, matching the existing mode-home hydration guard.
Remove exact duplicate branch-review-ledger rows introduced when merging
origin/main so Static PR checks stay green.
@BigSimmo
BigSimmo merged commit 7dd1a02 into mainJul 28, 2026
18 checks passed
@BigSimmo
BigSimmo deleted the fix-test-run-lock branch July 28, 2026 01:08
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@BigSimmo@cursoragent