Skip to content

perf(bundle): precompute cross-mode differentials index to slim the lazy chunk (#012)#1287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BigSimmo merged 24 commits into from
Jul 28, 2026
Merged

perf(bundle): precompute cross-mode differentials index to slim the lazy chunk (#012) #1287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
f430466
perf(bundle): precompute cross-mode differentials index to slim the l…
claude Jul 27, 2026
3dcc314
ci: enforce check:cross-mode-index in the static-pr job
claude Jul 27, 2026
97ab067
Merge branch 'main' into claude/site-audit-quick-wins-21v9gb
BigSimmo Jul 27, 2026
70d140e
docs(ledger): record Bugbot review for PR #1287
cursoragent Jul 27, 2026
18fcfae
test/docs: guard the cross-mode index import graph; fix stale refs (B…
claude Jul 27, 2026
b0b3fdf
test/docs: deepen the import-graph guard; refresh review ledger (Code…
claude Jul 27, 2026
09dbd2d
test(perf): lock cross-mode differentials off the full snapshot
cursoragent Jul 27, 2026
34e9fc6
docs(ledger): record Bugbot P2 fix for PR #1287
cursoragent Jul 27, 2026
82f7394
merge: integrate remote Bugbot import-graph guard for #1287
cursoragent Jul 27, 2026
d9284bd
docs(ledger): record reconciled Bugbot P2 fix for #1287
cursoragent Jul 27, 2026
5c2816d
test(ui): settle differentials-home before strict redirect assert
cursoragent Jul 27, 2026
f738f08
docs(ledger): record Production UI hydration fix for #1287
cursoragent Jul 27, 2026
f266738
merge(main): sync #1287 with ledger appends from #1284
cursoragent Jul 27, 2026
88d8638
test(perf): walk resolved cross-mode lazy-chunk import graph
cursoragent Jul 27, 2026
5704a9d
docs(ledger): close out #1287 review/sync disposition
cursoragent Jul 27, 2026
662a93f
style: prettier-format cross-mode differentials index test
cursoragent Jul 27, 2026
cec73fe
docs(ledger): record Static PR format fix for #1287
cursoragent Jul 27, 2026
562bce2
merge(main): sync #1287; resolve outstanding-issues conflict
cursoragent Jul 28, 2026
1b31607
docs(ledger): record #1287 main-sync conflict repair
cursoragent Jul 28, 2026
742b0d1
issues: complete #012 queue closeout after main sync
cursoragent Jul 28, 2026
860dd80
docs(ledger): record Bugbot #012 queue closeout for #1287
cursoragent Jul 28, 2026
d4edd4f
merge(main): sync #1287 with numeric claim-truncation fix
cursoragent Jul 28, 2026
b90d659
style: prettier-format outstanding-issues after #012 queue closeout
cursoragent Jul 28, 2026
78897c1
docs(ledger): record #1287 format+main-sync fix
cursoragent Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -251,6 +251,9 @@ jobs:
- name: Therapy data index drift
run: npm run check:therapy-data-index

- name: Cross-mode differentials index drift
run: npm run check:cross-mode-index

- name: Design-system contract
run: npm run check:design-system-contract

Expand Down
10 changes: 10 additions & 0 deletions docs/branch-review-ledger.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -1157,13 +1157,20 @@ This file is append-only. Never rewrite or delete an existing review record; app
| 2026-07-27 | PR #1275 / `codex/identify-and-fix-performance-issues-during-mode-switch` | `24605b57e288` | Bugbot + merge-tree review | NOT READY. Prefetch product change looks auth-safe/correct. GitHub DIRTY is staleness (merge-tree CLEAN). Blockers: ledger rewrite/corruption (~95 historical rows) + incomplete required CI. Sync main, restore ledger from origin/main, append one row, then recheck. | merge-tree CLEAN; ledger byte/corruption inspect; unresolved Codex/CodeRabbit threads; no provider checks. |
| 2026-07-27 | PR #1280 / `claude/top-search-design-mockups-w53znc` | `93a9f90ff287` | Bugbot + CI debug | NOT READY until Production UI green. Product band rebuild looks sound; Advisory UI green. Hosted failure is Answer Suspense `Loading answer` strict-mode (2 nodes / one hidden) in ui-smoke — not caused by band diff. Optional P2: `useRailOverflow` can miss child-list changes. | Production UI log job 90037898852; unique diff vs main; focused band unit 9/9 on tip; no provider checks. |
| 2026-07-27 | PR #1281 / `claude/safety-planning-tools-page-tsq4vs` | `a26e95fc9ac9` | Bugbot clinical review | APPROVE pending exact-head required CI + minor P2 polish. Incomplete plans get draft banner/clipboard marking; contact reach methods required for Ready/Finalise. P2: StepBuilderCard green check still uses entries.length; clipboard DRAFT text untested. No P0/P1. | unique diff review; GraphQL no cursor[bot] threads; no provider checks. |
| 2026-07-27 | PR #1287 / `claude/site-audit-quick-wins-21v9gb` | `97ab067bfdca644e0750bfbc717da7d58ecd27ee` | Bugbot defect hunt (cursoragent request; no hosted cursor[bot] threads) | APPROVE pending exact-head required CI. No P0/P1. Projection ≡ live helpers (201 diagnoses / 31 presentations / 20 alias keys); `--check` compares parsed values (Prettier-safe); CI `static-pr` + `verify:cheap` wire `check:cross-mode-index`. Residual P2: re-importing `@/lib/differentials` into `cross-mode-differentials.ts` would restore the ~1.2 MB lazy-chunk weight while data gates stay green — no import-graph lock yet. P3: stale comment in `cross-mode-links.tsx`; scripts-index omits new generator. | `check:cross-mode-index` PASS; vitest `cross-mode-differentials-index` 2/2; gate-manifest PASS; drift/invalid-JSON proofs FAIL closed; import-graph grep clean today; no provider-backed checks. |
Comment thread
coderabbitai[bot] marked this conversation as resolved.
| 2026-07-27 | PR #1287 / `claude/site-audit-quick-wins-21v9gb` | `09dbd2dcc5126e4ae7d6f9e99e7325853047f749` | Bugbot P2 follow-up: import-graph lock for cross-mode differentials | FIXED. Added a client-performance-boundaries source assertion that `cross-mode-differentials.ts` stays on the trimmed JSON index (no value-import of `@/lib/differentials` / snapshot / fixtures) and that `cross-mode-links.tsx` keeps the dynamic import. Updated the stale 1.2 MB comment. Residual: dual projection logic still lives in the build script and `differentials.ts` (caught by the existing deep-equal test). | Focused `tests/client-performance-boundaries.test.ts` PASS (7/7); no provider-backed checks. |
Comment thread
coderabbitai[bot] marked this conversation as resolved.
| 2026-07-27 | PR #1287 / `claude/site-audit-quick-wins-21v9gb` | `18fcfae24b41cdd5caebd2780afa963a2a1335a5` | Follow-up — Bugbot/CodeRabbit residuals addressed (supersedes the 97ab067 Bugbot row) | Residual P2 closed: import-graph lock added — an allowlist test asserts `cross-mode-differentials.ts` may import ONLY the precomputed index + the (type-only) catalog type, catching direct, transitive-via-new-import, and dynamic `import()`/`require` reintroductions of `@/lib/differentials`. P3s closed: stale `cross-mode-links.tsx` comment fixed; `build-cross-mode-differentials-index.mjs` listed in `scripts-index.md`. CodeRabbit's two Minor nits (guard depth + this ledger refresh) addressed. | vitest `cross-mode-differentials-index` 3/3; typecheck + lint PASS; `docs:check-scripts` + `docs:check-links` PASS; `check:cross-mode-index` PASS; no provider-backed checks. |
| 2026-07-27 | PR #1287 / `claude/site-audit-quick-wins-21v9gb` | `82f73943a88fdccf8226344bbb5a0bf52f665ede` | Bugbot P2 reconcile after parallel remote fix | FIXED (reconciled). Remote already landed an allowlist import-graph guard in `tests/cross-mode-differentials-index.test.ts` plus scripts-index/comment refresh. Merged that work and retained a consumer-side lock: `cross-mode-links.tsx` must dynamically import the catalog module (not statically). | Focused vitest `client-performance-boundaries` + `cross-mode-differentials-index` PASS (10/10); no provider-backed checks. |
| 2026-07-27 | PR #1287 / `claude/site-audit-quick-wins-21v9gb` | `5c2816d1dc2e7a99c37d27310b487bcac5232db3` | Production UI CI fix: differentials-home hydration strict-mode | FIXED. Hosted Production UI failed solely on `dashboard differentials mode param redirects…`: `getByTestId(differentials-home)` hit 2 nodes (server+client overlap). Applied `expectSingleSettledOwner` before the visibility assert. No product change. | Focused production Playwright journey PASS 1/1 via `npm run test:e2e` (system Chrome); no provider-backed checks. |

| 2026-07-27 | open-PR recommendation implementation (Cursor) | multi-head | Implement review recommendations safely | CLOSED #1261/#1262/#1263 without merge (unsafe audit lineage). Pushed fixes: #1273 type-scale + phone-frame scroll + PriorityDock selection; #1275 prefetch source-contract tighten; #1280 rail MutationObserver + main sync; #1281 StepBuilderCard completeness + clipboard draft test (automerge temporarily disabled to land polish). Opened #PDF-137 salvage branch for exit-code 137. Dependabot #1267-1269 left HOLD — workflow approve/update-branch 403 for this integration token; no merge to main. | type-scale strict PASS; focused Vitest safety-plan 3/3 and prefetch contract 1/1 and band 9/9; PDF extractor pymupdf tests skipped in this VM; no provider-backed checks; no main merges. |
| 2026-07-27 | PR #1273 / `codex/create-mobile-navigation-mockups` | `f6964aeb` | Implemented review fixes | Type-scale tokens, phone-frame inner scroll, PriorityDock overflow selection. Rebased onto concurrent tip. | `check:type-scale --strict` PASS; no provider checks. |
| 2026-07-27 | PR #1275 / `codex/identify-and-fix-performance-issues-during-mode-switch` | `6c544c16` | Implemented review follow-up | Prefetch contract now requires both `openModeMenuWithFocus` and `toggleModeMenu` bodies. Prior tip already restored ledger + synced main. | Focused Vitest prefetch contract PASS; no provider checks. |
| 2026-07-27 | PR #1280 / `claude/top-search-design-mockups-w53znc` | `980b4298` | Implemented review follow-up | Synced main; rail overflow observes childList mutations. Temporarily disabled auto-merge to land polish without squash race. | Focused band Vitest 9/9; no provider checks. |
| 2026-07-27 | PR #1281 / `claude/safety-planning-tools-page-tsq4vs` | `f7e616d1` | Implemented review polish | StepBuilderCard filled uses `isStepComplete`; clipboard DRAFT assertion added. Auto-merge temporarily disabled to land polish. | Focused safety-plan Vitest 3/3; no provider checks. |
| 2026-07-27 | PR #1261/#1262/#1263 audit cluster | closed tips | Close without merge | Closed per review: unsafe lineage / tip markers / privacy+RAG P1s / parallel verify:cheap rewrite. Thin PDF exit-137 salvage opened separately. | Prior Bugbot + merge-tree evidence; no provider checks. |
| 2026-07-27 | PR #1287 / `claude/site-audit-quick-wins-21v9gb` | `88d8638974075fa91334c2bb4a0e6b54fda00176` | Review closeout: main sync + resolved-graph guard + ledger attribution | FIXED. Cause of GitHub CONFLICTING/DIRTY: both tips appended `docs/branch-review-ledger.md` (union); `git merge-tree` was clean — merged `origin/main` (#1284 ledger rows). CodeRabbit recursive import-graph ask: walk resolved runtime imports from `cross-mode-differentials.ts` (services/forms boundary pattern) + keep entry allowlist. Supersedes residual wording on rows 1148/1149: import-graph lock + scripts-index + comment already landed; `client-performance-boundaries` guards the consumer dynamic import, `cross-mode-differentials-index` guards the catalog module/graph. Hosted Production UI already green after hydration settle. | Focused vitest index+boundaries 10/10; `check:cross-mode-index` PASS; merge-tree CLEAN vs origin/main; prior Production UI PASS on `f738f083`; no provider-backed checks. |
| 2026-07-27 | PR #1287 / `claude/site-audit-quick-wins-21v9gb` | `662a93f826ea6ba34df9d15677ef5ae2446a2e40` | Static PR Format check fix | FIXED. Hosted `static-pr` Format check failed on Prettier for `tests/cross-mode-differentials-index.test.ts` after the resolved-graph guard. Reformatted; no behaviour change. Mergeable vs main (merge-tree CLEAN, 0 behind). Prior review threads already dispositioned. | `prettier --check` local PASS for the file; vitest index test 3/3; no provider-backed checks. |
| 2026-07-28 | PR #1292 / `codex/chat-clinical-grounding-cap-bbc4` | `2e5ee9f891d9f251adffb6a15bc2ab13e0f18b23` | CI babysit + Bugbot | Blocking PR policy fixed via temporary `PR_POLICY_BODY.md` sync (Clinical Governance Preflight all checked, Risk/Verification completed), then template removed. Merge with main clean. Bugbot: zero `cursor[bot]` findings; offline scan of unique claim-cap fail-closed diff found no high-confidence defect. No review threads. Residual: human approving review once exact-head required checks finish. | Local: `npx vitest run tests/rag-claim-support.test.ts` 40/40; `evaluatePullRequestPolicy` ok. Hosted prior tip `19495e7c`: PR policy + Sync SUCCESS. No OpenAI/live Supabase. |
| 2026-07-28 | PR #1292 / `codex/chat-clinical-grounding-cap-bbc4` | `1d43484ad56bde756ecdc9c98d448779836b2f97` | CI babysit + Bugbot (SHA correction) | SUPERSEDES prior #1292 row that recorded pre-amend `2e5ee9f8`. Same outcome: PR policy remediated, `PR_POLICY_BODY.md` removed, Bugbot clean, no review threads. Residual: human approving review after exact-head CI. | Same local evidence; awaiting hosted checks on tip `1d43484a`. |
| 2026-07-28 | PR #1292 / `codex/chat-clinical-grounding-cap-bbc4` | `cb73b200ccbafa4378df8d7ae103beb8e464e783` | CI babysit + Bugbot closeout | COMPLETED for current tip. Required CI green (PR policy, Static, Unit, Build, PR required, SAST, Gitleaks). Body retains checked Clinical Governance Preflight. Bugbot: no findings. No unresolved review threads. Residual: human approving review only. | Hosted tip `cb73b200`: all required checks SUCCESS. Local claim-support Vitest 40/40. No providers. |
Expand All@@ -1188,4 +1195,7 @@ This file is append-only. Never rewrite or delete an existing review record; app
| 2026-07-27 | PR #1275 / `codex/identify-and-fix-performance-issues-during-mode-switch` | `f4b55751` | CodeRabbit behavioral prefetch-test disposition | RESOLVED. Behavioral DOM coverage for menu-open prefetch paths (later adapted to per-option model). | focused vitest PASS; no provider checks. |
| 2026-07-27 | PR #1275 / `codex/identify-and-fix-performance-issues-during-mode-switch` | `81005d18` | Codex mojibake-ledger disposition | RESOLVED. Historical rows restored byte-for-byte from origin/main; append-only thereafter. | exact prefix check; check:branch-review-ledger PASS; no provider checks. |
| 2026-07-28 | PR #1275 / `codex/identify-and-fix-performance-issues-during-mode-switch` | `01469840` | CI/merge conflict closeout + Bugbot triage | RESOLVED merge conflict with origin/main (7ae4eb49 per-option prefetchModeHome). Dropped superseded bulk prefetchModeHomes; menu-open warms only highlighted option; focus/pointer scanning retained. CodeRabbit duplicate/malformed ledger threads dispositioned (main-owned). No open cursor[bot] Bugbot product defects. | merge-tree clean; focused vitest 12/12; ledger restored from main + appends; no provider checks. |
| 2026-07-28 | PR #1287 / `claude/site-audit-quick-wins-21v9gb` | `562bce2b3c90bf1790da9683077915cd3f8fdb17` | Main sync + conflict repair + Bugbot closeout | FIXED. Real CONFLICTING vs advanced main was `docs/outstanding-issues.md` only (ledger/ui-smoke auto-merged). Resolution keeps `#012` in Resolved with this PR's outcome while retaining main's newer open/archive rows. CI on prior tip was fully green (Static/Production UI/PR required); re-runs after sync. Review threads already dispositioned (resolved-graph guard, ledger residuals, attribution). | merge-tree CLEAN; focused vitest index+boundaries 10/10; `check:cross-mode-index` PASS; `prettier --check` on touched tests PASS; Bugbot pass pending agent; no provider-backed checks. |
| 2026-07-28 | PR #1287 / `claude/site-audit-quick-wins-21v9gb` | `742b0d154f7058800c945b3ec6e720eef24ce4c0` | Bugbot P2: finish #012 recommended-queue closeout | FIXED. After main-sync conflict repair, `#012` was correctly Resolved/Open-clean but the Recommended execution queue still listed it (order 20 composite + #017 Before hint). Applied `/issues done` queue rewrite: order 20 is now `#013`, `#016`; #017 timing is Before `#013`/`#016`. | Bugbot review on `1b31607b`; queue/Open/Resolved audit; focused vitest previously green; no provider-backed checks. |
| 2026-07-28 | PR #1292 / `codex/chat-clinical-grounding-cap-bbc4` | ff40a2b945caf657b45cec0d662317057c63abe3 | CI babysit + main sync + Bugbot | GitHub DIRTY/CONFLICTING with clean `merge-tree` (2 behind main). Merged `origin/main` with no content conflicts. CI already green on prior tip; no product test failures. Bugbot: reviewThreads=0; product fail-closed scan clean. No comments to resolve. | Local overflow Vitest 1/1; ledger guard pass; awaiting exact-head hosted CI. No providers. |
| 2026-07-28 | PR #1287 / `claude/site-audit-quick-wins-21v9gb` | `b90d659be12efedd339297daa2d289c2bd7ebb03` | Sync main + Format check on outstanding-issues | FIXED. Cause of GitHub CONFLICTING/DIRTY: branch 1 behind main (`11a4ed74` numeric claim truncation); `git merge-tree` CLEAN — ledger union auto-merge. Cause of Static PR red: Prettier on `docs/outstanding-issues.md` after queue closeout rewrite. Merged main; reformatted file; `#012` remains Resolved and out of the recommended queue. | merge-tree CLEAN; `prettier --check` PASS; `check:branch-review-ledger` PASS; no provider-backed checks. |
Loading
Loading