issues: capture #085 — upload-limit client/server sync is unguarded

[BigSimmo]

Summary

Captures one outstanding recommendation into the durable issues ledger (docs/outstanding-issues.md): #84 — the upload-limit client/server sync is unguarded. Ledger-only; no code changes.

Surfaced by the FV-04 adversarial review during PRs #1064/#1069. NEXT_PUBLIC_MAX_UPLOAD_MB (client, build-time inlined) and MAX_UPLOAD_MB (server, runtime) both default to 150 but nothing keeps them in sync — no zod link, gate, or test. Lowering server-only reintroduces the 413-after-full-transfer UX that FV-04 existed to prevent; lowering client-only falsely rejects files the server would accept, breaking #1064''s client-is-a-strict-superset invariant. Both are documented in .env.example/docs/deployment-architecture.md but unenforced, and the client value is frozen at next build so a Railway service-var change without an image rebuild silently no-ops.

Filed P3/rec — the cheapest guard is a check:* script that fails when the two configured values disagree.

Verification

• npm run docs:check-links — passes (1264 references resolve)
• npx prettier --check docs/outstanding-issues.md — clean
• Ledger table integrity: new row has the correct 8 pipes; issues:next-id bumped 084 → 085.

Risk and rollout

• Risk: none. Documentation-only; a single table row in the outstanding-issues ledger.
• Provider or production effects: none.

🤖 Generated with Claude Code

Summary by CodeRabbit

• Documentation
  • Updated the outstanding issues documentation with a new recommendation regarding upload-size configuration consistency.
  • Corrected the issue counter and removed an unintended formatting marker.

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

[supabase]

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

---

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

[coderabbitai]

Warning

Review limit reached

@cursor[bot], you've reached your PR review limit, so we couldn't start this review.

Next review available in:53 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: de2ec434-dd47-4178-a595-6827cd69f669

📥 Commits

Reviewing files that changed from the base of the PR and between f6fa76b and fde03cd.

📒 Files selected for processing (2)

• docs/branch-review-ledger.md
• docs/outstanding-issues.md

📝 Walkthrough

Walkthrough

Updates docs/outstanding-issues.md by removing its BOM, advancing the issue counter to 085, and adding issue #084 about client/server upload-limit configuration drift.

Changes

Outstanding issues ledger

Layer / File(s)	Summary
Update issue ledger docs/outstanding-issues.md	Removes the leading BOM, increments the next issue ID from 084 to 085, and documents upload-limit synchronization risks between NEXT_PUBLIC_MAX_UPLOAD_MB and MAX_UPLOAD_MB with a proposed CI assertion.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

• BigSimmo/Database#1043: Updates the same issue ledger by advancing its counter and adding recommendations.
• BigSimmo/Database#1046: Makes similar docs/outstanding-issues.md ledger changes.
• BigSimmo/Database#1069: Implements client-side alignment logic related to the newly documented upload-limit drift.

Suggested reviewers:cursoragent

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title is concise and matches the docs-only issue-ledger update about unguarded upload-limit sync.
Description check	✅ Passed	The description follows the template sections and includes summary, verification, and rollout notes, with only the Notes section left minimal.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch claude/issues-upload-limit-sync-123366

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/outstanding-issues.md`:
- Line 124: Update the Added date in the ledger row for issue `#084` to the actual
insertion date, July 27, 2026; if the change is intentionally made on July 28,
retain 2026-07-28 instead.

🪄 Autofix (Beta)

✅ Autofix completed

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 2ad937f9-a705-4145-a554-09872685f56d

📥 Commits

Reviewing files that changed from the base of the PR and between 86e86af and f6fa76b.

📒 Files selected for processing (1)

• docs/outstanding-issues.md

[coderabbitai]

Note

Autofix is a beta feature. Expect some limitations and changes as we gather feedback and continue to improve it.

Fixes Applied Successfully

Fixed 1 file(s) based on 1 unresolved review comment.

Files modified:

• docs/outstanding-issues.md

Commit:d7829f92f3a80ea83dac34a850a2edbfdce89fc1

The changes have been pushed to the claude/issues-upload-limit-sync-123366 branch.

Time taken:1m 24s

[BigSimmo]

@cursoragent please resolve all CI failing tests after understanding the issue. Please also fix any comments and resolve them and also ensure that you fix with smallest required fix with best coding practice and u derstabding the fix rather than simple patch. Please fix any merge conflicts and ensure any issues are found. Please resolve any issues you find. Please also run bugbot. Please mark comments resolved also once you resolve them.

[cursor]

PR #1291 is merged (268ca18a). The real blocker was a ledger ID conflict, not failing tests.

What was wrong

• GitHub showed CONFLICTING on docs/outstanding-issues.md
• main had already used #084 for completed per-result grading evidence
• This PR tried to reuse #084 for the upload-limit recommendation

What I fixed

• Merged origin/main and kept main’s ledger
• Renumbered the upload-limit capture to #085 and set issues:next-id=086
• Updated the PR title to #085
• Required CI went green (Change scope / Static PR checks / PR required)
• Bugbot: no cursor[bot] findings
• CodeRabbit date thread was already resolved

On main now

• Open item #085 — upload-limit client/server sync is unguarded
• Archive still owns #084 for grading evidence

One post-merge branch-review-ledger “CI green” row landed on the feature branch after squash-merge and is not on main; product/docs capture is already landed.

[cursor]

Resolved merge conflict with main on docs/outstanding-issues.md.

Root cause:main had already claimed #084 for the completed per-result irrelevant-at-10 grading evidence task, so this PR’s upload-limit capture collided on ID.

Fix: kept main’s ledger, renumbered the upload-limit recommendation to #085, and advanced issues:next-id to 086. Diff vs main remains ledger-only.

Review comments: CodeRabbit date nit was already addressed/resolved. Bugbot triage found zero cursor[bot] findings on head 8fb64686.

CI: re-running on the merged tip; will sync again if main advances.