Skip to content

Fix test run lock - #1304

Merged
BigSimmo merged 17 commits into
mainfrom
fix-test-run-lock
Jul 28, 2026
Merged

Fix test run lock#1304
BigSimmo merged 17 commits into
mainfrom
fix-test-run-lock

Conversation

@BigSimmo

@BigSimmoBigSimmo commented Jul 28, 2026

Copy link
Copy Markdown
Owner

Summary

Verification

  • npm run verify:pr-local

During development, use npm run verify:cheap as the faster iteration gate before the final PR-local preflight.

  • npm run verify:ui when UI, routing, styling, browser behavior, reduced-motion, or forced-colors behavior changed
  • npm run verify:release before release or handoff confidence claims

For retrieval, ranking, selection, chunking, source/citation rendering, or answer-contract changes, verify:pr-local runs eval:rag:offline automatically. Run the offline command directly during iteration before spending a live eval.

  • npm run eval:retrieval:quality (must stay 36/36) when retrieval, ranking, selection, chunking, or scoring behavior changed — CI cannot run it (needs live keys), so run it locally and paste the summary. A metadata/governance-weighting change once buried correct docs (recall 1.0→0.76) and only this eval caught it.
  • npm run eval:rag -- --limit 15 + npm run eval:quality -- --rag-only when answer generation, the synthesis prompt, or answer post-processing changed (grounded-supported must not drop; citation-failure 0)
  • npm run check:production-readiness when clinical workflow, privacy, environment, Supabase, source governance, or deployment behavior changed
  • npm run check:deployment-readiness when deployment startup, hosting, or rollout behavior changed

Risk and rollout

Complete this section for clinical, data, API, auth/privacy, workflow, dependency, build, or deployment changes.

  • Risk:
  • Rollback:
  • Provider or production effects: None / describe the explicitly authorized effect

Clinical Governance Preflight

Complete this section when the change touches ingestion, answer generation, search/ranking, source rendering, document access, privacy, production env, or clinical output.

  • Source-backed claims still require linked source verification before clinical use
  • No patient-identifiable document workflow was introduced or expanded without explicit governance approval
  • Supabase target remains Clinical KB Database (sjrfecxgysukkwxsowpy)
  • Service-role keys and private document access remain server-only
  • Demo/synthetic content remains clearly separated from real clinical sources
  • Source metadata, review status, and outdated/unknown-source behavior remain conservative
  • Deployment classification/TGA SaMD impact was checked when clinical decision-support behavior changed

Notes

Summary by CodeRabbit

  • Chores
    • Updated project quality checks by removing an outdated ignore setting related to Tailwind CSS.
  • Documentation
    • Refreshed the branch review ledger with new entries covering the latest test-run lock resolution and follow-up main synchronization status.

BigSimmoand others added 7 commits July 25, 2026 22:31
Append merge-readiness and prlanded outcome for remediate-repository-audit-findings @ 8637fec: DO NOT MERGE, not landed, CONFLICTING vs main.
Capture the 2026-07-26 close decisions and merge-ready keep list after
re-triaging the Antigravity/Cursor queue.
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@supabase

supabaseBot commented Jul 28, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@coderabbitai

coderabbitaiBot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

The PR removes the tailwindcss dependency ignore from Knip and appends review, conflict-resolution, CI, and synchronization records for PR #1304 to the branch review ledger.

Changes

Configuration and review closeout

Layer / File(s)Summary
Remove tailwindcss dependency exception
knip.json
Removes the ignoreDependencies setting for tailwindcss.
Record review closeout
docs/branch-review-ledger.md
Adds conflict-resolution, merge-readiness, CI, synchronization, and Bugbot/review status records for PR #1304, alongside related ledger entries for PRs #1310 and #1305.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers:cursoragent, claude

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Description check⚠️ WarningThe description is just the template with empty sections and no verification, risk, rollout, or governance details.Fill in the Summary, Verification, Risk and rollout, and Notes sections with the actual change details and completed checks.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Title check✅ PassedThe title clearly matches the PR's main change: fixing the test run lock issue.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

@BigSimmo

Copy link
Copy Markdown
OwnerAuthor

@CodeRabbit run review

@coderabbitai

Copy link
Copy Markdown
Contributor

Custom finishing touch recipe not found: review.

@BigSimmo

Copy link
Copy Markdown
OwnerAuthor

@cursoragent please resolve all CI failing tests after understanding the issue. Please also fix any comments and resolve them and also ensure that you fix with smallest required fix with best coding practice and u derstabding the fix rather than simple patch. Please fix any merge conflicts and ensure any issues are found. Please resolve any issues you find. Please also run bugbot. Please mark comments resolved also once you resolve them.

@cursor

cursorBot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

PR #1304 is mergeable again with required CI green.

Root cause: GitHub CONFLICTING was real — 9 content conflicts with main (261 behind). Required CI was missing on the tip; the earlier green run was on an older SHA.

What I did

  • Merged origin/main and resolved conflicts by taking main where this branch was already superseded (test-run-lock lease/heartbeat rewrite, phone chrome CSS/tests, document-top-nav mockups, ui-primitives, ultra-review prompts)
  • Kept the only remaining product delta: knip.json drops unused ignoreDependencies: ["tailwindcss"]
  • Ran Bugbot: no cursor[bot] findings; 0 unresolved review threads (CodeRabbit ledger note already resolved)
  • Local verify:cheap passed (4114 tests); hosted PR required SUCCESS on tip e6b826ed
  • Status: mergeable=MERGEABLE, mergeStateStatus=CLEAN

No review comments left to resolve. Ready for your merge when you want.

Open in WebOpen in Cursor

cursoragentand others added 2 commits July 28, 2026 04:27
Take main's test-run-lock rewrite (lease/heartbeat already present), phone
chrome CSS/tests, document-top-navigation mockups, ui-primitives forced-
colors tokens, and ultra-review prompts. Keep the knip.json cleanup that
drops the unused tailwindcss ignoreDependencies entry.
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/branch-review-ledger.md`:
- Line 1216: Update the PR `#1304` entry in the branch-review ledger to remove the
“FIXED” closeout status while hosted CI is still pending. Record the hosted CI
result and only mark the entry fixed after that result confirms completion; keep
mergeable status separate from CI validation.
🪄 Autofix (Beta)

❌ Autofix failed (check again to retry)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 2363d62a-268f-487c-9aae-95880a62870e

📥 Commits

Reviewing files that changed from the base of the PR and between 352eedf and 6300b02.

📒 Files selected for processing (1)
  • docs/branch-review-ledger.md

Comment threaddocs/branch-review-ledger.md
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
@BigSimmo
BigSimmo enabled auto-merge (squash) July 28, 2026 06:48
@coderabbitai

Copy link
Copy Markdown
Contributor

Note

Autofix is a beta feature. Expect some limitations and changes as we gather feedback and continue to improve it.

Autofix skipped. No unresolved CodeRabbit review comments with fix instructions found.

@BigSimmo

Copy link
Copy Markdown
OwnerAuthor

@cursoragent fix CI

@cursor

cursorBot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

CI is fixed and stable on tip 7add2b5e.

What was wrong: Required checks were already green. GitHub showed CONFLICTING/DIRTY because main kept moving — git merge-tree was clean every time (staleness, not real conflicts).

What I did: Synced origin/main through the churn until the tip stayed current through a full CI run.

Current status

  • mergeable=MERGEABLE, 0 behind main
  • Hosted PR required SUCCESS
  • Unique product change still just knip.json (drop unused tailwindcss knip ignore)

mergeStateStatus=BLOCKED is from review/approval gates, not failing CI. Ready to merge when you approve.

Open in WebOpen in Cursor

cursoragentand others added 2 commits July 28, 2026 06:49
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/branch-review-ledger.md`:
- Line 1155: Update the ledger entry for PR `#1304` / fix-test-run-lock so it does
not mark commit 7cc32c053c752bef19f3de408a1376428e54af74 as FIXED based on CI
from prior commit e6b826ed; record required-CI results for the current tip, or
keep the entry pending until those checks pass.
🪄 Autofix (Beta)

✅ Autofix completed


ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 87909a20-8509-415a-8e1b-b527e98b7e32

📥 Commits

Reviewing files that changed from the base of the PR and between e6b826e and f7d86c2.

📒 Files selected for processing (1)
  • docs/branch-review-ledger.md

Comment threaddocs/branch-review-ledger.md
@BigSimmo
BigSimmo disabled auto-merge July 28, 2026 06:52
@BigSimmo
BigSimmo enabled auto-merge (squash) July 28, 2026 06:52
@coderabbitai

coderabbitaiBot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Note

Autofix is a beta feature. Expect some limitations and changes as we gather feedback and continue to improve it.

Cannot run autofix: This PR has merge conflicts.

Please resolve the conflicts with the base branch and try again.

Alternatively, use @coderabbitai resolve merge conflict to automatically resolve the conflicts.

cursoragentand others added 2 commits July 28, 2026 06:54
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

♻️ Duplicate comments (1)
docs/branch-review-ledger.md (1)

1162-1162: 🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win

Do not mark these tips FIXED using CI from older commits.

The 7cc32c053c752bef19f3de408a1376428e54af74 row cites CI from e6b826ed, and the 2abe39506f9f0ceaf8cf638bfa2b6dc37dc0ed2c row cites CI from f7d86c27. Keep each closeout pending, or record hosted required-CI success for the exact tip before marking it fixed; merge-tree cleanliness is not CI validation.

Also applies to: 1165-1165

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/branch-review-ledger.md` at line 1162, Update the closeout entries for
tips 7cc32c053c752bef19f3de408a1376428e54af74 and
2abe39506f9f0ceaf8cf638bfa2b6dc37dc0ed2c so they remain pending unless hosted
required CI succeeded for those exact commits. Remove or revise any FIXED status
based only on older commit CI, and do not treat merge-tree cleanliness as CI
validation.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Duplicate comments:
In `@docs/branch-review-ledger.md`:
- Line 1162: Update the closeout entries for tips
7cc32c053c752bef19f3de408a1376428e54af74 and
2abe39506f9f0ceaf8cf638bfa2b6dc37dc0ed2c so they remain pending unless hosted
required CI succeeded for those exact commits. Remove or revise any FIXED status
based only on older commit CI, and do not treat merge-tree cleanliness as CI
validation.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: e5f417c9-2871-4d34-b3d8-532fc0fefeb1

📥 Commits

Reviewing files that changed from the base of the PR and between f7d86c2 and 463e5c0.

📒 Files selected for processing (1)
  • docs/branch-review-ledger.md

Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
@coderabbitai

coderabbitaiBot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Note

Autofix is a beta feature. Expect some limitations and changes as we gather feedback and continue to improve it.

Fixes Applied Successfully

Fixed 1 file(s) based on 1 unresolved review comment.

Files modified:

  • docs/branch-review-ledger.md

Commit:8b762b4dac779f1528b94f8ccd322aef3ff6218e

The changes have been pushed to the fix-test-run-lock branch.

Time taken:3m 35s

@coderabbitai

Copy link
Copy Markdown
Contributor

Note

Autofix is a beta feature. Expect some limitations and changes as we gather feedback and continue to improve it.

Autofix skipped. No unresolved CodeRabbit review comments with fix instructions found.

Fixed 1 file(s) based on 1 unresolved review comment.
Co-authored-by: CodeRabbit <noreply@coderabbit.ai>
@BigSimmo
BigSimmo merged commit 8917466 into mainJul 28, 2026
19 checks passed
@BigSimmo
BigSimmo deleted the fix-test-run-lock branch July 28, 2026 07:36
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@BigSimmo@cursoragent