docs(agents): add external skill precedence and evidence rules - #1306
Conversation
The Front-End Checklist skill corpus (~390 skills) and the caveman output-style plugin are installed user-global and know nothing about this repo's contracts. Adds a tie-breaker section so generic guidance never overrides committed docs or tests. - Repo docs win on conflict: wiring-conventions, search-chrome-behaviour, rag-behaviour, the @theme tokens in globals.css, and any committed test. - Records the touch-target collision: generic WCAG 44px guidance maps to min-h-11, which hit a sub-pixel rounding flake in ui-smoke, so production tap targets use min-h-12. Design-scratch mockups still carry min-h-11 and remain gate-exempt. - Output-style compression never applies to verification evidence or calibration: paste the decisive gate line, state verified vs assumed, and treat third-party fix claims as unverified until checked. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
📝 WalkthroughWalkthroughAGENTS.md adds guidance for prioritizing repository documentation and tests over external instructions, and requires explicit evidence when reporting verification results or third-party fix claims. ChangesAgent guidance updates
Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This pull request has been ignored for the connected project Preview Branches by Supabase. |
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
AGENTS.md (1)
229-236: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winScope “always win” to external guidance.
Clarify that repository contracts override generic skills/plugins only within this context and remain subordinate to higher-priority system, developer, user, security, and compliance requirements.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@AGENTS.md` around lines 229 - 236, Update the “Repo contracts outrank generic rules” guidance in AGENTS.md to limit its precedence to external or generic skills and output-style plugins. Explicitly state that repository contracts remain subordinate to higher-priority system, developer, user, security, and compliance requirements.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@AGENTS.md`:
- Around line 237-241: Update the guidance in the “Never regress a fixed flake…”
section to accurately distinguish WCAG 2.2’s 24×24 AA minimum from the 44×44 AAA
enhanced criterion. Describe min-h-12 as the repository’s tested, stronger
production baseline, while preserving the existing ui-smoke exception and mockup
exemption.
- Around line 256-257: Update the “Third-party fix claims stay unverified until
checked” guidance to prioritize inspecting available local refs and make git
fetch conditional on explicit user authorization. State that network access,
including GitHub/GitLab or provider-backed workflows, must not be used without
confirmation, while preserving the requirement to verify the ref before treating
claims as fact.
---
Nitpick comments:
In `@AGENTS.md`:
- Around line 229-236: Update the “Repo contracts outrank generic rules”
guidance in AGENTS.md to limit its precedence to external or generic skills and
output-style plugins. Explicitly state that repository contracts remain
subordinate to higher-priority system, developer, user, security, and compliance
requirements.
🪄 Autofix (Beta)
✅ Autofix completed
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Note Autofix is a beta feature. Expect some limitations and changes as we gather feedback and continue to improve it. Fixes Applied SuccessfullyFixed 1 file(s) based on 2 unresolved review comments. Files modified:
Commit: The changes have been pushed to the Time taken: |
Fixed 1 file(s) based on 2 unresolved review comments. Co-authored-by: CodeRabbit <noreply@coderabbit.ai>
Uh oh!
There was an error while loading. Please reload this page.
Squash-merged; remote branch auto-deleted. Records the CodeRabbit outcome (2 of 3 findings autofixed pre-merge, third landed in #1308) and that verify:cheap never completed past check:installed-lock-parity. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The Front-End Checklist skill corpus (~390 skills) and the caveman output-style plugin are installed user-global and know nothing about this repo's contracts. Adds a tie-breaker section so generic guidance never overrides committed docs or tests.
Summary
Verification
npm run verify:pr-localDuring development, use
npm run verify:cheapas the faster iteration gate before the final PR-local preflight.npm run verify:uiwhen UI, routing, styling, browser behavior, reduced-motion, or forced-colors behavior changednpm run verify:releasebefore release or handoff confidence claimsFor retrieval, ranking, selection, chunking, source/citation rendering, or answer-contract changes,
verify:pr-localrunseval:rag:offlineautomatically. Run the offline command directly during iteration before spending a live eval.npm run eval:retrieval:quality(must stay 36/36) when retrieval, ranking, selection, chunking, or scoring behavior changed — CI cannot run it (needs live keys), so run it locally and paste the summary. A metadata/governance-weighting change once buried correct docs (recall 1.0→0.76) and only this eval caught it.npm run eval:rag -- --limit 15+npm run eval:quality -- --rag-onlywhen answer generation, the synthesis prompt, or answer post-processing changed (grounded-supported must not drop; citation-failure 0)npm run check:production-readinesswhen clinical workflow, privacy, environment, Supabase, source governance, or deployment behavior changednpm run check:deployment-readinesswhen deployment startup, hosting, or rollout behavior changedRisk and rollout
Complete this section for clinical, data, API, auth/privacy, workflow, dependency, build, or deployment changes.
Clinical Governance Preflight
Complete this section when the change touches ingestion, answer generation, search/ranking, source rendering, document access, privacy, production env, or clinical output.
Clinical KB Database(sjrfecxgysukkwxsowpy)Notes
Summary by CodeRabbit