Skip to content

test(search): validate focused live document search - #1320

Merged
BigSimmo merged 2 commits into
mainfrom
codex/universal-search-live-test-fix
Jul 28, 2026
Merged

test(search): validate focused live document search#1320
BigSimmo merged 2 commits into
mainfrom
codex/universal-search-live-test-fix

Conversation

@BigSimmo

Copy link
Copy Markdown
Owner

Summary

  • Align the live universal-search owner test with the intentional 750 ms federated document timeout.
  • Validate authenticated document search separately through the existing 6-second focused timeout path.
  • Guarantee Supabase sign-out with finally; production search and RAG behavior are unchanged.
  • Append the required branch review ledger record.

Verification

  • npm run verify:pr-local

Verification not run: the isolated worktree has no installed dependencies and another worktree holds the repository's exclusive verification lease. Required hosted CI must pass on the exact PR head before merge.

  • npm run verify:ui when UI, routing, styling, browser behavior, reduced-motion, or forced-colors behavior changed

UI verification not run: no UI, routing, styling, browser, or phone-chrome files changed.

  • npm run verify:release before release or handoff confidence claims

Release verification not run: this test-only PR does not authorize Supabase/OpenAI provider checks; merge confidence is limited to exact-head required hosted CI and the final merge audit.

Local checks completed:

  • node --experimental-strip-types --check tests/universal-search-owner.live.test.ts — PASS
  • git diff --check — PASS
  • npm run check:branch-review-ledger — PASS (1107 records, union merge active, no conflicts or duplicates)
  • npm run verify:pr-local -- --dry-run --files tests/universal-search-owner.live.test.ts — PASS; selected runtime, lock parity, format, lint, typecheck, unit, and offline RAG fixture gates
  • npm run verify:phone-chrome -- --dry-run --files tests/universal-search-owner.live.test.ts — PASS; no phone-chrome-affecting file detected

Retrieval, answer-generation, production-readiness, deployment-readiness, and UI gates are not applicable because no production behavior changed.

Risk and rollout

  • Risk: Low, test-only. The live test performs one additional authenticated, documents-only search request and no longer misclassifies an intentional federated timeout as a product failure.
  • Rollback: Revert this PR; no data, schema, configuration, or application migration is involved.
  • Provider or production effects: No provider test was run locally. GitHub CI/check reads and merge operations are explicitly authorized for this PR.

RAG impact: no retrieval behaviour change — test-only universal-search live assertion update.

Clinical Governance Preflight

  • Source-backed claims still require linked source verification before clinical use
  • No patient-identifiable document workflow was introduced or expanded without explicit governance approval
  • Supabase target remains Clinical KB Database (sjrfecxgysukkwxsowpy)
  • Service-role keys and private document access remain server-only
  • Demo/synthetic content remains clearly separated from real clinical sources
  • Source metadata, review status, and outdated/unknown-source behavior remain conservative
  • Deployment classification/TGA SaMD impact was checked when clinical decision-support behavior changed

Notes

  • The earlier retrieval-quality report was generated from a superseded pre-Harden RAG retrieval and answer reliability #1289 tree; this PR does not alter ranking or answer behavior.
  • Physical iPhone acceptance remains a separate real-device evidence task and is not claimed by this test-only PR.

@supabase

supabaseBot commented Jul 28, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@coderabbitai

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in:16 minutes

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 90795d2a-5506-49a3-ad3c-f354e403bd4f

📥 Commits

Reviewing files that changed from the base of the PR and between 422e43d and 2d5bfa2.

📒 Files selected for processing (2)
  • docs/branch-review-ledger.md
  • tests/universal-search-owner.live.test.ts

Comment @coderabbitai help to get the list of available commands.

@BigSimmo
BigSimmo merged commit e3294c1 into mainJul 28, 2026
19 checks passed
@BigSimmo
BigSimmo deleted the codex/universal-search-live-test-fix branch July 28, 2026 06:14
@BigSimmo

Copy link
Copy Markdown
OwnerAuthor

@codex cursoragent please review PR for any issues? Check all testing would have passed.

@BigSimmo

Copy link
Copy Markdown
OwnerAuthor

@codex please review for any issues.

@BigSimmo

Copy link
Copy Markdown
OwnerAuthor

@cursoragent please review PR for any issues? Check all testing would have passed.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Another round soon, please!

Reviewed commit:e3294c10c4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@BigSimmo