- Notifications
You must be signed in to change notification settings - Fork 0
docs: keep PR titles/descriptions uncompressed under caveman mode#1322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Uh oh!
There was an error while loading. Please reload this page.
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
29c5869
chore: organize dirty work from claude/pr-policy-caveman-fix-6875bb
BigSimmo ebd1693
Merge remote-tracking branch 'origin/main' into claude/pr-policy-cave…
BigSimmo 7e96cc3
Merge branch 'main' into claude/pr-policy-caveman-fix-6875bb
BigSimmo 0706211
Merge branch 'main' into claude/pr-policy-caveman-fix-6875bb
BigSimmo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -262,6 +262,18 @@ Output-style plugins such as caveman mode may compress prose. They must never co | ||
| inspecting already-fetched local refs (`git log`, `git show`) first; `git fetch` or other | ||
| network/provider access requires explicit user confirmation per the "API and provider confirmation | ||
| boundary" section. | ||
| - **PR titles and descriptions are parsed input, not prose.** `.github/workflows/pr-policy.yml` | ||
| runs `scripts/pr-policy.mjs` against the exact PR title/body text and hard-blocks the merge | ||
| when a clinical-risk diff lacks a complete `## Clinical Governance Preflight` (every item from | ||
| `requiredClinicalGovernanceItems` checked) or a RAG-ranking-surface diff lacks a satisfying | ||
| `RAG impact:` line (see "RAG ranking protection" below). Caveman-style fragment-dropping breaks | ||
| this exact-format contract — a paraphrased checklist item or a shortened `RAG impact:` reason can | ||
| silently fail `governanceItemSatisfied`/`ragImpactDeclared` even though the PR is otherwise fine. | ||
| `gh pr create`/`gh pr edit` bodies and any `PR_POLICY_BODY.md` content therefore always get | ||
| written in full normal prose from `.github/pull_request_template.md`, regardless of the active | ||
| output style — this is "commits" territory under the caveman carve-out, not chat. Before | ||
BigSimmo marked this conversation as resolved.
Uh oh!There was an error while loading. Please reload this page. | ||
| push, sanity-check clinical-risk/RAG-ranking bodies against `scripts/pr-policy.mjs`'s | ||
| `evaluatePullRequestPolicy` shape (run `npm run check:pr-policy` if the script itself changed). | ||
| <!-- END:external-skill-precedence --> | ||
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.